fix: update env problem

Author: masb0ymas

src/config/env.ts

@@ -34,8 +34,8 @@ export const env = {
   MAIL_DRIVER: process.env.MAIL_DRIVER || 'smtp',
   MAIL_HOST: process.env.MAIL_HOST || 'smtp.mailtrap.io',
   MAIL_PORT: validate.number(process.env.MAIL_PORT) || 587,
-  MAIL_FROM: process.env.MAIL_FROM || ' ',
-  MAIL_USERNAME: process.env.MAIL_USERNAME || ' ',
-  MAIL_PASSWORD: process.env.MAIL_PASSWORD || ' ',
-  MAIL_ENCRYPTION: process.env.MAIL_ENCRYPTION || ' ',
+  MAIL_FROM: process.env.MAIL_FROM,
+  MAIL_USERNAME: process.env.MAIL_USERNAME,
+  MAIL_PASSWORD: process.env.MAIL_PASSWORD,
+  MAIL_ENCRYPTION: process.env.MAIL_ENCRYPTION,
 }

src/lib/storage/gcs.ts

@@ -4,6 +4,7 @@ import { addDays } from 'date-fns'
 import fs from 'fs'
 import path from 'path'
 import { logger } from '~/config/logger'
+import { storageExists } from '../boolean'
 import { ms } from '../date'
 import { currentDir } from '../string'
 import { GoogleCloudStorageParams, UploadFileParams } from './types'
@@ -22,9 +23,10 @@ export default class GoogleCloudStorage {
     this._expires = params.expires
     this._filepath = path.resolve(`${currentDir}/${params.filepath}`)
 
+    const isStorageEnabled = storageExists()
     const msgType = `${green('storage - google cloud storage')}`
 
-    if (!this._access_key && !fs.existsSync(this._filepath)) {
+    if (isStorageEnabled && !this._access_key && !fs.existsSync(this._filepath)) {
       const message = `${msgType} serviceAccount is missing on root directory`
       logger.error(message)