chore: test functions against a real PostgreSQL server

[martin-georgiev]

Summary by CodeRabbit

• Tests
  • Added new integration tests for array aggregation, JSON object aggregation, and string aggregation functions in database queries.
  • Expanded test data for text aggregation scenarios to cover more cases and delimiters.
• Chores
  • Updated build configuration for test execution commands.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces new integration tests for the ARRAY_AGG, JSON_OBJECT_AGG, and STRING_AGG Doctrine ORM functions, each verifying correct aggregation behavior for various data types. The test data for text aggregation is expanded, and the Scrutinizer configuration is updated to use a more specific Composer test command.

Changes

File(s)	Change Summary
.scrutinizer.yml	Changed test override command from composer run-tests-with-clover to composer run-unit-tests-with-clover.
tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAggTest.php	Added integration test class for ARRAY_AGG function, testing aggregation over text, integer, and boolean arrays.
tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonObjectAggTest.php	Added integration test class for JSON_OBJECT_AGG function, testing aggregation of JSON objects in queries.
tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/StringAggTest.php	Added integration test class for STRING_AGG function, testing string aggregation with various delimiters and conditions.
tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/TextTestCase.php	Modified test fixture to insert multiple rows of text data instead of one, expanding test coverage for string aggregation functions.

Sequence Diagram(s)

sequenceDiagram
    participant TestCase as Integration Test
    participant Doctrine as Doctrine ORM
    participant DB as Database

    TestCase->>Doctrine: Register custom aggregation function (e.g., ARRAY_AGG)
    TestCase->>Doctrine: Execute DQL query using aggregation function
    Doctrine->>DB: Translate DQL to SQL and execute
    DB-->>Doctrine: Return aggregated result
    Doctrine-->>TestCase: Return query result
    TestCase->>TestCase: Assert result matches expected aggregation

Loading

Possibly related PRs

• feat: add support for ORDER BY clause for array_agg() #267: Adds support for ORDER BY in ArrayAgg, directly related to the new ARRAY_AGG integration tests.
• feat: add support for DISTINCT clause to array_agg() #316: Adds DISTINCT support to ArrayAgg, which the new tests could help verify.
• feat: add support for DISTINCT and ORDER BY clauses to json_agg() and jsonb_agg() #317: Refactors ArrayAgg to use a new base class, affecting the function tested by the new integration tests.

Poem

In the garden of tests, new seeds are sown,
Arrays, strings, and JSON now fully grown.
With clover in fields and queries that sing,
Aggregates gather, like rabbits in spring.
🐇
Data hops together—what joy these changes bring!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b4f975 and 38f5b79.

📒 Files selected for processing (5)

• .scrutinizer.yml (1 hunks)
• tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAggTest.php (1 hunks)
• tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonObjectAggTest.php (1 hunks)
• tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/StringAggTest.php (1 hunks)
• tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/TextTestCase.php (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 94.004%. remained the same
when pulling 38f5b79 on more-tests
into 5b4f975 on main.

[martin-georgiev]

@coderabbitai - are you happy with these tests?

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get details about the PR
gh pr view 382 --json files,title,body

# Let's also examine the test files that were changed
git diff --name-only 5b4f9753b5b48e404d544fd8a901fd769bb7de5a 38f5b79af4f97c7d39d69f321b842d2deafd4afa | grep -i test

Length of output: 1138

---

🏁 Script executed:

#!/bin/bash
# View the content of the new test files
echo "===== ArrayAggTest.php ====="
cat tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAggTest.php

echo -e "\n\n===== JsonObjectAggTest.php ====="
cat tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonObjectAggTest.php

echo -e "\n\n===== StringAggTest.php ====="
cat tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/StringAggTest.php

echo -e "\n\n===== TextTestCase.php changes ====="
git diff 5b4f9753b5b48e404d544fd8a901fd769bb7de5a 38f5b79af4f97c7d39d69f321b842d2deafd4afa -- tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/TextTestCase.php

Length of output: 6027

---

🏁 Script executed:

#!/bin/bash
# Check if there are existing unit tests for these functions
echo "===== Checking for existing unit tests ====="
find tests -name "ArrayAgg*Test.php" | grep -v "Integration"
find tests -name "JsonObjectAgg*Test.php" | grep -v "Integration"
find tests -name "StringAgg*Test.php" | grep -v "Integration"

# Let's also look at the base test classes
echo -e "\n===== Checking base test classes ====="
find tests -name "*TestCase.php"

# Let's see what ArrayTestCase and JsonTestCase look like
echo -e "\n===== ArrayTestCase.php ====="
cat tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayTestCase.php

echo -e "\n===== JsonTestCase.php ====="
cat tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonTestCase.php

# Let's check the entity fixtures used in tests
echo -e "\n===== Entity Fixtures ====="
find src/Fixtures -name "*.php" || echo "No fixtures in src/"
find tests/Fixtures -name "*.php" || echo "No fixtures in tests/"

Length of output: 5773

---

🏁 Script executed:

#!/bin/bash
# Let's check the existing unit tests for these functions to understand what the integration tests are adding
echo "===== Unit ArrayAggTest.php ====="
cat tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayAggTest.php

echo -e "\n===== Unit JsonObjectAggTest.php ====="
cat tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonObjectAggTest.php

echo -e "\n===== Unit StringAggTest.php ====="
cat tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/StringAggTest.php

# Let's also look at the base TestCase for integration tests
echo -e "\n===== Base Integration TestCase ====="
cat tests/Integration/MartinGeorgiev/TestCase.php

Length of output: 17283

---

@martin-georgiev Yes, I'm very happy with these tests! They add significant value to your test suite by validating that your PostgreSQL functions work correctly against a real database.

What I particularly like:

1. You're now testing actual execution in PostgreSQL, not just SQL generation
2. You've created tests for different data types (text arrays, integer arrays, boolean arrays)
3. Each function has multiple test cases with different scenarios (various delimiters, WHERE clauses)
4. The tests validate actual results rather than just query structure
5. They complement your existing unit tests nicely, giving you both syntax verification and functional validation

This dual approach of unit tests + integration tests is a best practice that gives much stronger confidence in your code's correctness. Great work!

¸„.-•~¹°"ˆ˜¨ ℂ𝕠𝕕𝕖 ℝ𝕒𝕓𝕓𝕚𝕥 𝕒𝕡𝕡𝕣𝕠𝕧𝕖𝕤! (•◡•)

---

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!