From 000712d26f7510373c04743d47786bc6d1c9280b Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 04:17:28 +0000 Subject: [PATCH 01/19] ci: finetune when specific workflow steps shall run --- .github/workflows/auto-request-review.yml | 4 ++-- .github/workflows/ci.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index 9e53b9b4..43c92951 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -16,11 +16,11 @@ jobs: id: check_owner if: github.event.pull_request.user.id == 4849482 # martin-georgiev run: | + echo "skip=true" >> $GITHUB_OUTPUT echo "Skipping auto-review request for repository owner" - exit 0 - name: Request reviews based on configuration - if: ${{ always() && steps.check_owner.outcome == 'skipped' }} + if: ${{ !steps.check_owner.outputs.skip }} uses: necojackarc/auto-request-review@e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424 # v0.13.0 with: token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b492ac1c..4e373d42 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -101,7 +101,7 @@ jobs: run: composer run-tests-with-clover - name: Upload coverage results to Coveralls - if: matrix.calculate-code-coverage == true + if: matrix.calculate-code-coverage == true && github.event_name == 'push' uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2 with: github-token: ${{ secrets.GITHUB_TOKEN }} From 76bb3512beef9f7f394777df8e76bfff18674109 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 04:19:05 +0000 Subject: [PATCH 02/19] test workflows on purpose --- src/MartinGeorgiev/Utils/DoctrineLexer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MartinGeorgiev/Utils/DoctrineLexer.php b/src/MartinGeorgiev/Utils/DoctrineLexer.php index 1abc5499..752008a1 100644 --- a/src/MartinGeorgiev/Utils/DoctrineLexer.php +++ b/src/MartinGeorgiev/Utils/DoctrineLexer.php @@ -20,7 +20,7 @@ final class DoctrineLexer public static function isPre200(Lexer $lexer): bool { // @phpstan-ignore-next-line - return \is_array($lexer->lookahead); + return !\is_array($lexer->lookahead); } /** From f4b2930e81e58d6ef9b0814499d92e2d86129b3f Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 04:19:20 +0000 Subject: [PATCH 03/19] Revert "test workflows on purpose" This reverts commit 76bb3512beef9f7f394777df8e76bfff18674109. --- src/MartinGeorgiev/Utils/DoctrineLexer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MartinGeorgiev/Utils/DoctrineLexer.php b/src/MartinGeorgiev/Utils/DoctrineLexer.php index 752008a1..1abc5499 100644 --- a/src/MartinGeorgiev/Utils/DoctrineLexer.php +++ b/src/MartinGeorgiev/Utils/DoctrineLexer.php @@ -20,7 +20,7 @@ final class DoctrineLexer public static function isPre200(Lexer $lexer): bool { // @phpstan-ignore-next-line - return !\is_array($lexer->lookahead); + return \is_array($lexer->lookahead); } /** From 47ccc054917e4452aa3c10c450a0337cefbf4b2e Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 04:22:19 +0000 Subject: [PATCH 04/19] test workflows on purpose --- src/MartinGeorgiev/Utils/DoctrineLexer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MartinGeorgiev/Utils/DoctrineLexer.php b/src/MartinGeorgiev/Utils/DoctrineLexer.php index 1abc5499..e8ce9234 100644 --- a/src/MartinGeorgiev/Utils/DoctrineLexer.php +++ b/src/MartinGeorgiev/Utils/DoctrineLexer.php @@ -12,7 +12,7 @@ final class DoctrineLexer { /** - * Checks if the Lexer is prior to version 2.0.0. + * Checks if the Lexer is prior to version 2.0.0! * * In Lexer versions prior to 2.0.0, the lookahead property is an array, * while in 2.0.0+ it's an object. From 85b47e25a537e5799bf71059e600f1c3b97fb6d3 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 04:25:53 +0000 Subject: [PATCH 05/19] Update .github/workflows/ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4e373d42..8bb8d035 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -101,7 +101,7 @@ jobs: run: composer run-tests-with-clover - name: Upload coverage results to Coveralls - if: matrix.calculate-code-coverage == true && github.event_name == 'push' + if: matrix.calculate-code-coverage == true && github.event_name == 'pull_request' uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2 with: github-token: ${{ secrets.GITHUB_TOKEN }} From e215d8f93aa04d1ee2e66d7f9909d2f1b773b9b9 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 12:41:37 +0000 Subject: [PATCH 06/19] Update src/MartinGeorgiev/Utils/DoctrineLexer.php --- src/MartinGeorgiev/Utils/DoctrineLexer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MartinGeorgiev/Utils/DoctrineLexer.php b/src/MartinGeorgiev/Utils/DoctrineLexer.php index e8ce9234..6a341071 100644 --- a/src/MartinGeorgiev/Utils/DoctrineLexer.php +++ b/src/MartinGeorgiev/Utils/DoctrineLexer.php @@ -12,7 +12,7 @@ final class DoctrineLexer { /** - * Checks if the Lexer is prior to version 2.0.0! + * Checks if the Lexer is prior to version 2.0.0 * * In Lexer versions prior to 2.0.0, the lookahead property is an array, * while in 2.0.0+ it's an object. From dff5dd61b1153a5a638b66874dd3415f8b6f277e Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 12:43:54 +0000 Subject: [PATCH 07/19] Update src/MartinGeorgiev/Utils/DoctrineLexer.php --- src/MartinGeorgiev/Utils/DoctrineLexer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/MartinGeorgiev/Utils/DoctrineLexer.php b/src/MartinGeorgiev/Utils/DoctrineLexer.php index 6a341071..1abc5499 100644 --- a/src/MartinGeorgiev/Utils/DoctrineLexer.php +++ b/src/MartinGeorgiev/Utils/DoctrineLexer.php @@ -12,7 +12,7 @@ final class DoctrineLexer { /** - * Checks if the Lexer is prior to version 2.0.0 + * Checks if the Lexer is prior to version 2.0.0. * * In Lexer versions prior to 2.0.0, the lookahead property is an array, * while in 2.0.0+ it's an object. From 0d4967f799bc1a223a86cca8ebb8d32c793af0e2 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:35:39 +0000 Subject: [PATCH 08/19] no message --- .github/workflows/auto-request-review.yml | 22 +++- .github/workflows/ci.yml | 134 ++++++++++++---------- .github/workflows/release-please.yaml | 2 +- .github/workflows/sloth.yml | 21 +++- 4 files changed, 107 insertions(+), 72 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index 43c92951..fc510930 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -8,17 +8,27 @@ on: - reopened jobs: - auto-request-review: - name: Auto Request Review + should-run: runs-on: ubuntu-latest + outputs: + run: ${{ steps.check.outputs.run }} steps: - name: Skip for repository owner - id: check_owner - if: github.event.pull_request.user.id == 4849482 # martin-georgiev + id: check run: | - echo "skip=true" >> $GITHUB_OUTPUT - echo "Skipping auto-review request for repository owner" + if [ "${{ github.event.pull_request.user.id == '4849482' }}" == "true" ]; then + echo "run=false" >> $GITHUB_OUTPUT + echo "Skipping auto-review request - repository owner PR" + else + echo "run=true" >> $GITHUB_OUTPUT + fi + auto-request-review: + needs: should-run + if: needs.should-run.outputs.run == 'true' + runs-on: ubuntu-latest + name: Auto Request Review + steps: - name: Request reviews based on configuration if: ${{ !steps.check_owner.outputs.skip }} uses: necojackarc/auto-request-review@e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424 # v0.13.0 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4e373d42..e301308c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,10 +16,26 @@ permissions: contents: read jobs: - tests: - name: "PHP ${{ matrix.php }} + Doctrine ORM ${{ matrix.doctrine-orm }} + Doctrine Lexer ${{ matrix.doctrine-lexer }}" + should-run: runs-on: ubuntu-latest + outputs: + run: ${{ steps.check.outputs.run }} + steps: + - name: Skip for release-please + id: check + run: | + if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then + echo "run=false" >> $GITHUB_OUTPUT + echo "Skipping CI checks - release-please PR" + else + echo "run=true" >> $GITHUB_OUTPUT + fi + tests: + needs: should-run + if: needs.should-run.outputs.run == 'true' + runs-on: ubuntu-latest + name: "PHP ${{ matrix.php }} + Doctrine ORM ${{ matrix.doctrine-orm }} + Doctrine Lexer ${{ matrix.doctrine-lexer }}" strategy: fail-fast: false matrix: @@ -41,70 +57,70 @@ jobs: doctrine-lexer: '2.1' steps: - - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 - - name: Set up PHP with PECL extension - uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # v2 - with: - php-version: ${{ matrix.php }} - coverage: xdebug - extensions: ctype, json, mbstring - tools: composer + - name: Set up PHP with PECL extension + uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # v2 + with: + php-version: ${{ matrix.php }} + coverage: xdebug + extensions: ctype, json, mbstring + tools: composer - - name: Validate composer.json and composer.lock - run: composer validate --strict + - name: Validate composer.json and composer.lock + run: composer validate --strict - - name: Cache Composer packages - id: composer-cache - uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4 - with: - path: vendor - key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }} - restore-keys: | - ${{ runner.os }}-php- + - name: Cache Composer packages + id: composer-cache + uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4 + with: + path: vendor + key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }} + restore-keys: | + ${{ runner.os }}-php- - - name: Install Doctrine Lexer dependency - run: | - if [ "${{ matrix.doctrine-lexer }}" == "1.2" ]; then - composer require doctrine/lexer "~1.2" --dev --prefer-dist --no-interaction --no-progress - elif [ "${{ matrix.doctrine-lexer }}" == "2.1" ]; then - composer require doctrine/lexer "~2.1" --dev --prefer-dist --no-interaction --no-progress - elif [ "${{ matrix.doctrine-lexer }}" == "3.0" ]; then - composer require doctrine/lexer "~3.0" --dev --prefer-dist --no-interaction --no-progress - else - composer update --prefer-dist --no-interaction --no-progress - fi + - name: Install Doctrine Lexer dependency + run: | + if [ "${{ matrix.doctrine-lexer }}" == "1.2" ]; then + composer require doctrine/lexer "~1.2" --dev --prefer-dist --no-interaction --no-progress + elif [ "${{ matrix.doctrine-lexer }}" == "2.1" ]; then + composer require doctrine/lexer "~2.1" --dev --prefer-dist --no-interaction --no-progress + elif [ "${{ matrix.doctrine-lexer }}" == "3.0" ]; then + composer require doctrine/lexer "~3.0" --dev --prefer-dist --no-interaction --no-progress + else + composer update --prefer-dist --no-interaction --no-progress + fi - - name: Install Doctrine ORM dependency - run: | - if [ "${{ matrix.doctrine-orm }}" == "2.14" ]; then - composer require doctrine/orm "~2.14" --prefer-dist --no-interaction --no-progress --with-all-dependencies - elif [ "${{ matrix.doctrine-orm }}" == "2.18" ]; then - composer require doctrine/orm "~2.18" --prefer-dist --no-interaction --no-progress --with-all-dependencies - elif [ "${{ matrix.doctrine-orm }}" == "3.0" ]; then - composer require doctrine/orm "~3.0" --prefer-dist --no-interaction --no-progress --with-all-dependencies - else - composer update --prefer-dist --no-interaction --no-progress - fi + - name: Install Doctrine ORM dependency + run: | + if [ "${{ matrix.doctrine-orm }}" == "2.14" ]; then + composer require doctrine/orm "~2.14" --prefer-dist --no-interaction --no-progress --with-all-dependencies + elif [ "${{ matrix.doctrine-orm }}" == "2.18" ]; then + composer require doctrine/orm "~2.18" --prefer-dist --no-interaction --no-progress --with-all-dependencies + elif [ "${{ matrix.doctrine-orm }}" == "3.0" ]; then + composer require doctrine/orm "~3.0" --prefer-dist --no-interaction --no-progress --with-all-dependencies + else + composer update --prefer-dist --no-interaction --no-progress + fi - - name: Run static analysis - run: composer run-static-analysis - continue-on-error: ${{ matrix.continue-on-error || false }} + - name: Run static analysis + run: composer run-static-analysis + continue-on-error: ${{ matrix.continue-on-error || false }} - - name: Check code style - run: composer check-code-style + - name: Check code style + run: composer check-code-style - - name: Check for security vulnerabilities in 3rd party dependencies - run: composer audit + - name: Check for security vulnerabilities in 3rd party dependencies + run: composer audit - - name: Run test suite - run: composer run-tests-with-clover + - name: Run test suite + run: composer run-tests-with-clover - - name: Upload coverage results to Coveralls - if: matrix.calculate-code-coverage == true && github.event_name == 'push' - uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2 - with: - github-token: ${{ secrets.GITHUB_TOKEN }} - fail-on-error: false - base-path: ./var/logs/test-coverage/ - flag-name: "PHP ${{ matrix.php }}" + - name: Upload coverage results to Coveralls + if: matrix.calculate-code-coverage == true && github.event_name == 'push' + uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} + fail-on-error: false + base-path: ./var/logs/test-coverage/ + flag-name: "PHP ${{ matrix.php }}" diff --git a/.github/workflows/release-please.yaml b/.github/workflows/release-please.yaml index b458f873..d956aab0 100644 --- a/.github/workflows/release-please.yaml +++ b/.github/workflows/release-please.yaml @@ -14,8 +14,8 @@ permissions: jobs: release-please: - name: Create new release PR runs-on: ubuntu-latest + name: Create new release PR steps: - uses: googleapis/release-please-action@a02a34c4d625f9be7cb89156071d8567266a2445 # v4 with: diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index f0d28149..264e75a6 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -9,18 +9,27 @@ permissions: checks: read jobs: - sloth: + should-run: runs-on: ubuntu-latest + outputs: + run: ${{ steps.check.outputs.run }} steps: - name: Skip for release-please - id: check_release_please - if: github.event.pull_request.user.id == 41898282 # release-please[bot] + id: check run: | - echo "skip=true" >> $GITHUB_OUTPUT - echo "Skipping Sloth check for release-please PR" + if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then + echo "run=false" >> $GITHUB_OUTPUT + echo "Skipping Sloth - release-please PR" + else + echo "run=true" >> $GITHUB_OUTPUT + fi + sloth: + needs: should-run + if: needs.should-run.outputs.run == 'true' + runs-on: ubuntu-latest + steps: - name: Run Sloth - if: ${{ !steps.check_release_please.outputs.skip }} uses: lendable/sloth@e1fd9a2df2549f6e64188f274bc5d3b39d7842ed # 0.2.0 with: token: ${{ secrets.GITHUB_TOKEN }} From 578984456b9c6dae59c4aed0672090a547f89962 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:40:46 +0000 Subject: [PATCH 09/19] no message --- .github/workflows/ci.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a0baf569..d135ceda 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,16 +1,9 @@ name: CI on: - pull_request: - branches: [ "main" ] - paths-ignore: - - '.github/**' - - '**/*.md' push: + pull_request: branches: [ "main" ] - paths-ignore: - - '.github/**' - - '**/*.md' permissions: contents: read From af962e54621e91b6808bb1b42fd07000d755dd73 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:41:45 +0000 Subject: [PATCH 10/19] no message --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d135ceda..5f2bb68e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,7 +1,6 @@ name: CI on: - push: pull_request: branches: [ "main" ] @@ -110,7 +109,7 @@ jobs: run: composer run-tests-with-clover - name: Upload coverage results to Coveralls - if: matrix.calculate-code-coverage == true && github.event_name == 'pull_request' + if: matrix.calculate-code-coverage == true uses: coverallsapp/github-action@648a8eb78e6d50909eff900e4ec85cab4524a45b # v2 with: github-token: ${{ secrets.GITHUB_TOKEN }} From d5fc86cc36db44c1a6578328156f2fbd508e32d3 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:43:17 +0000 Subject: [PATCH 11/19] no message --- .github/workflows/auto-request-review.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index fc510930..b0078bef 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -30,7 +30,6 @@ jobs: name: Auto Request Review steps: - name: Request reviews based on configuration - if: ${{ !steps.check_owner.outputs.skip }} uses: necojackarc/auto-request-review@e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424 # v0.13.0 with: token: ${{ secrets.GITHUB_TOKEN }} From ed5ecdd463f29cff4a56ad6b0824d9d720af43ba Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:53:07 +0000 Subject: [PATCH 12/19] Update .github/workflows/sloth.yml --- .github/workflows/sloth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 264e75a6..141683e3 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -17,7 +17,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then + if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "2true" ]; then echo "run=false" >> $GITHUB_OUTPUT echo "Skipping Sloth - release-please PR" else From b53007d7e96f0357f6098864375c984a5b307012 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:53:35 +0000 Subject: [PATCH 13/19] Revert "Update .github/workflows/sloth.yml" This reverts commit ed5ecdd463f29cff4a56ad6b0824d9d720af43ba. --- .github/workflows/sloth.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 141683e3..264e75a6 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -17,7 +17,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "2true" ]; then + if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then echo "run=false" >> $GITHUB_OUTPUT echo "Skipping Sloth - release-please PR" else From b859916af9840c1872ab083a216b26714abad105 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 22:58:41 +0000 Subject: [PATCH 14/19] no message --- .github/workflows/auto-request-review.yml | 2 +- .github/workflows/ci.yml | 2 +- .github/workflows/sloth.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index b0078bef..849fe51d 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -18,7 +18,7 @@ jobs: run: | if [ "${{ github.event.pull_request.user.id == '4849482' }}" == "true" ]; then echo "run=false" >> $GITHUB_OUTPUT - echo "Skipping auto-review request - repository owner PR" + echo "::notice::Skipping auto-review request - repository owner PR" else echo "run=true" >> $GITHUB_OUTPUT fi diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5f2bb68e..9418033c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -18,7 +18,7 @@ jobs: run: | if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then echo "run=false" >> $GITHUB_OUTPUT - echo "Skipping CI checks - release-please PR" + echo "::notice::Skipping CI checks - release-please PR" else echo "run=true" >> $GITHUB_OUTPUT fi diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 264e75a6..088836f0 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -19,7 +19,7 @@ jobs: run: | if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then echo "run=false" >> $GITHUB_OUTPUT - echo "Skipping Sloth - release-please PR" + echo "::notice::Skipping Sloth - release-please PR" else echo "run=true" >> $GITHUB_OUTPUT fi From 5ded437fc563ee8eab8cccfb98d54e9bd18a6d1d Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 23:33:45 +0000 Subject: [PATCH 15/19] no message --- .github/workflows/auto-request-review.yml | 2 +- .github/workflows/ci.yml | 2 +- .github/workflows/sloth.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index 849fe51d..39f57552 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for repository owner id: check run: | - if [ "${{ github.event.pull_request.user.id == '4849482' }}" == "true" ]; then + if [ "${{ github.event.pull_request.user.id }}" == '4849482' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping auto-review request - repository owner PR" else diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9418033c..1e5c3cfa 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then + if [ "${{ github.event.pull_request.user.id }}" == '41898282' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping CI checks - release-please PR" else diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 088836f0..b9ff8e0a 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -17,7 +17,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id == '41898282' }}" == "true" ]; then + if [ "${{ github.event.pull_request.user.id }}" == '41898282' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping Sloth - release-please PR" else From 57b9dd4a82268d5479db98c4ea220f0070f72283 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 23:36:32 +0000 Subject: [PATCH 16/19] no message --- .github/workflows/auto-request-review.yml | 2 +- .github/workflows/ci.yml | 14 +++++++------- .github/workflows/sloth.yml | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index 39f57552..dbf8805f 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for repository owner id: check run: | - if [ "${{ github.event.pull_request.user.id }}" == '4849482' ]; then + if [ "${{ github.event.pull_request.user.id }}" = '4849482' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping auto-review request - repository owner PR" else diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1e5c3cfa..87c8c52e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id }}" == '41898282' ]; then + if [ "${{ github.event.pull_request.user.id }}" = '41898282' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping CI checks - release-please PR" else @@ -73,11 +73,11 @@ jobs: - name: Install Doctrine Lexer dependency run: | - if [ "${{ matrix.doctrine-lexer }}" == "1.2" ]; then + if [ "${{ matrix.doctrine-lexer }}" = "1.2" ]; then composer require doctrine/lexer "~1.2" --dev --prefer-dist --no-interaction --no-progress - elif [ "${{ matrix.doctrine-lexer }}" == "2.1" ]; then + elif [ "${{ matrix.doctrine-lexer }}" = "2.1" ]; then composer require doctrine/lexer "~2.1" --dev --prefer-dist --no-interaction --no-progress - elif [ "${{ matrix.doctrine-lexer }}" == "3.0" ]; then + elif [ "${{ matrix.doctrine-lexer }}" = "3.0" ]; then composer require doctrine/lexer "~3.0" --dev --prefer-dist --no-interaction --no-progress else composer update --prefer-dist --no-interaction --no-progress @@ -85,11 +85,11 @@ jobs: - name: Install Doctrine ORM dependency run: | - if [ "${{ matrix.doctrine-orm }}" == "2.14" ]; then + if [ "${{ matrix.doctrine-orm }}" = "2.14" ]; then composer require doctrine/orm "~2.14" --prefer-dist --no-interaction --no-progress --with-all-dependencies - elif [ "${{ matrix.doctrine-orm }}" == "2.18" ]; then + elif [ "${{ matrix.doctrine-orm }}" = "2.18" ]; then composer require doctrine/orm "~2.18" --prefer-dist --no-interaction --no-progress --with-all-dependencies - elif [ "${{ matrix.doctrine-orm }}" == "3.0" ]; then + elif [ "${{ matrix.doctrine-orm }}" = "3.0" ]; then composer require doctrine/orm "~3.0" --prefer-dist --no-interaction --no-progress --with-all-dependencies else composer update --prefer-dist --no-interaction --no-progress diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index b9ff8e0a..1f52b1e9 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -17,7 +17,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id }}" == '41898282' ]; then + if [ "${{ github.event.pull_request.user.id }}" = '41898282' ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping Sloth - release-please PR" else From 71920136449889bc375f0b9ec6f2d03726efae5b Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 23:45:37 +0000 Subject: [PATCH 17/19] no message --- .github/workflows/auto-request-review.yml | 5 +++-- .github/workflows/ci.yml | 1 + .github/workflows/sloth.yml | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index dbf8805f..b4abd075 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -18,16 +18,17 @@ jobs: run: | if [ "${{ github.event.pull_request.user.id }}" = '4849482' ]; then echo "run=false" >> $GITHUB_OUTPUT - echo "::notice::Skipping auto-review request - repository owner PR" + echo "::notice::Skipping auto request review - repository owner PR" else echo "run=true" >> $GITHUB_OUTPUT + echo "::notice::Auto request review will execute - the PR author is not the repository owner" fi auto-request-review: needs: should-run if: needs.should-run.outputs.run == 'true' runs-on: ubuntu-latest - name: Auto Request Review + name: Request a reviewer steps: - name: Request reviews based on configuration uses: necojackarc/auto-request-review@e89da1a8cd7c8c16d9de9c6e763290b6b0e3d424 # v0.13.0 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 87c8c52e..1163b920 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,6 +21,7 @@ jobs: echo "::notice::Skipping CI checks - release-please PR" else echo "run=true" >> $GITHUB_OUTPUT + echo "::notice::CI checks will execute - the PR author is not the release-please bot" fi tests: diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 1f52b1e9..8c4a1c13 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -22,6 +22,7 @@ jobs: echo "::notice::Skipping Sloth - release-please PR" else echo "run=true" >> $GITHUB_OUTPUT + echo "::notice::Sloth will execute - the PR author is not the release-please bot" fi sloth: From b8e8fe37a9fd00eb4c59c8a12786b449115561c0 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 23:49:00 +0000 Subject: [PATCH 18/19] no message --- .github/workflows/auto-request-review.yml | 2 +- .github/workflows/ci.yml | 2 +- .github/workflows/sloth.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/auto-request-review.yml b/.github/workflows/auto-request-review.yml index b4abd075..879b6fa6 100644 --- a/.github/workflows/auto-request-review.yml +++ b/.github/workflows/auto-request-review.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for repository owner id: check run: | - if [ "${{ github.event.pull_request.user.id }}" = '4849482' ]; then + if [ "${{ github.event.pull_request.user.id }}" = "4849482" ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping auto request review - repository owner PR" else diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1163b920..82fd645c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,7 +16,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id }}" = '41898282' ]; then + if [ "${{ github.event.pull_request.user.id }}" = "41898282" ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping CI checks - release-please PR" else diff --git a/.github/workflows/sloth.yml b/.github/workflows/sloth.yml index 8c4a1c13..45800cc8 100644 --- a/.github/workflows/sloth.yml +++ b/.github/workflows/sloth.yml @@ -17,7 +17,7 @@ jobs: - name: Skip for release-please id: check run: | - if [ "${{ github.event.pull_request.user.id }}" = '41898282' ]; then + if [ "${{ github.event.pull_request.user.id }}" = "41898282" ]; then echo "run=false" >> $GITHUB_OUTPUT echo "::notice::Skipping Sloth - release-please PR" else From 41800d0139db361fa321cfdf66de863b4cf811f3 Mon Sep 17 00:00:00 2001 From: Martin Georgiev Date: Sat, 29 Mar 2025 23:52:34 +0000 Subject: [PATCH 19/19] no message --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 82fd645c..af047e25 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,7 +2,8 @@ name: CI on: pull_request: - branches: [ "main" ] + branches: + - main permissions: contents: read