DataStructure::transformPostgresTextArrayToPHPArray (v2) vs PostgresArrayToPHPArrayTransformer::transformPostgresArrayToPHPArray (v3)

[j4r3kb]

Hi.
After upgrading the package from v2 to v3, one of my tests failed. The test saves the string
'⥀!@#$%^&*()_+=-}{[]|":;\'\?><,./'
to DB and then retrieves it using the transformers.
In v2 the return value was the same while using DataStructure::transformPostgresTextArrayToPHPArray.
Inv v3 however the return value is '⥀!@#$%^&*()_+=-}{[]|":;\'\\?><,./' (backslash is escaped) while using PostgresArrayToPHPArrayTransformer::transformPostgresArrayToPHPArray.

Is this an intended change?

[martin-georgiev]

For which data type does this happen?
Can you share more code from your test to determine if this is intended behaviour or a legitimate bug?

V3 introduced breaking changes in some of the escaping logic and the handling of numerical values (more details are described in the change log and the upgrade markdown files).

[j4r3kb]

I can't share the exact code, but the test goes like this:

1. PHP array of tags

$tags = ['⥀!@#$%^&*()_+=-}{[]|":;\'\?><,./']; // with more strings that are unaffected by the change

2. Tags are saved to a Timescale DB using Doctrine (pg_array parameter type)
3. Row is fetched from the DB containing the tags column again using Doctrine DBAL.
4. The tags field is then transformed using PostgresArrayToPHPArrayTransformer::transformPostgresArrayToPHPArray($tags); before returning the row data.
5. Test compares the returned value with the input value (point 1).

Using v2 the value is the same. Using v3 the value has escaped backslash so to pass the test I have to compare it with '⥀!@#$%^&*()_+=-}{[]|":;\'\\\?><,./'

[martin-georgiev]

Can you replicate the issue on the standard PostgreSQL version? If yes - which version is it?

[martin-georgiev]

@j4r3kb I can't help you unless you share more meaningful code from your setup. I'm unable to replicate your issue, but I also make too many assumptions about how your test is being conducted.

[j4r3kb]

Sure, I need some time to prepare a working replication of this issue.

[j4r3kb]

@martin-georgiev https://github.com/j4r3kb/postgresql-doctrine steps in the readme.
The V2 version is copy pasted into the test.

If I add to the https://github.com/martin-georgiev/postgresql-for-doctrine/blob/main/tests/Unit/MartinGeorgiev/Utils/PostgresArrayToPHPArrayTransformerTest.php#L20
such line
self::assertEquals($postgresValue, PHPArrayToPostgresValueTransformer::transformToPostgresTextArray($phpValue));
The tests will fail. In V2 there are tests in both ways with the same data provider https://github.com/martin-georgiev/postgresql-for-doctrine/blob/v2.10.3/tests/MartinGeorgiev/Utils/DataStructureTest.php

[j4r3kb]

@martin-georgiev did you manage to take a look at it?

[martin-georgiev]

@j4r3kb not yet - it will take some time to clear the schedule for this.

[martin-georgiev]

@j4r3kb can you please check out #385 and confirm that it addresses all your issues? Once you let me know, I can release it.

[martin-georgiev]

I released a fix that addresses and validates your issue in the tests.