chore: refactor exceptions for Point's value object (#426)

Author: martin-georgiev

src/MartinGeorgiev/Doctrine/DBAL/Types/Point.php

@@ -7,6 +7,7 @@
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidPointForDatabaseException;
 use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidPointForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Exceptions\InvalidPointException;
 use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Point as PointValueObject;
 
 /**
@@ -46,7 +47,7 @@ public function convertToPHPValue($value, AbstractPlatform $platform): ?PointVal
 
         try {
             return PointValueObject::fromString($value);
-        } catch (\InvalidArgumentException) {
+        } catch (InvalidPointException) {
             throw InvalidPointForDatabaseException::forInvalidFormat($value);
         }
     }

src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php

@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+namespace MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Exceptions;
+
+/**
+ * Exception thrown when creating or manipulating Point value objects with invalid data.
+ *
+ * This exception is specifically for validation errors within the Point value object itself,
+ * separate from DBAL conversion exceptions.
+ *
+ * @since 3.5
+ *
+ * @author Martin Georgiev <martin.georgiev@gmail.com>
+ */
+final class InvalidPointException extends \InvalidArgumentException
+{
+    public static function forInvalidPointFormat(string $pointString, string $expectedPattern): self
+    {
+        return new self(\sprintf(
+            'Invalid point format. Expected format matching %s, got: %s',
+            \var_export($expectedPattern, true),
+            \var_export($pointString, true)
+        ));
+    }
+
+    public static function forInvalidCoordinate(string $coordinateName, string $value): self
+    {
+        return new self(\sprintf(
+            'Invalid %s coordinate format: %s',
+            \var_export($coordinateName, true),
+            \var_export($value, true)
+        ));
+    }
+}

src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Point.php

@@ -4,6 +4,8 @@
 
 namespace MartinGeorgiev\Doctrine\DBAL\Types\ValueObject;
 
+use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Exceptions\InvalidPointException;
+
 /**
  * @since 3.1
  *
@@ -41,9 +43,7 @@ public function getY(): float
     public static function fromString(string $pointString): self
     {
         if (!\preg_match(self::POINT_REGEX, $pointString, $matches)) {
-            throw new \InvalidArgumentException(
-                \sprintf('Invalid point format. Expected format matching %s, got: %s', self::POINT_REGEX, $pointString)
-            );
+            throw InvalidPointException::forInvalidPointFormat($pointString, self::POINT_REGEX);
         }
 
         return new self((float) $matches[1], (float) $matches[2]);
@@ -55,9 +55,7 @@ private function validateCoordinate(float $value, string $name): void
 
         $floatRegex = '/^'.self::COORDINATE_PATTERN.'$/';
         if (!\preg_match($floatRegex, $stringValue)) {
-            throw new \InvalidArgumentException(
-                \sprintf('Invalid %s coordinate format: %s', $name, $stringValue)
-            );
+            throw InvalidPointException::forInvalidCoordinate($name, $stringValue);
         }
     }
 }