YAGNI tests

Author: martin-georgiev

tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DateRangeTest.php

@@ -243,24 +243,6 @@ public function throws_exception_for_invalid_upper_bound(): void
         new DateRange(new \DateTimeImmutable('2023-01-01'), 'invalid');
     }
 
-    #[Test]
-    public function throws_exception_for_invalid_lower_bound_type(): void
-    {
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Lower bound must be DateTimeInterface');
-
-        new DateRange('invalid', new \DateTimeImmutable('2023-12-31'));
-    }
-
-    #[Test]
-    public function throws_exception_for_invalid_upper_bound_type(): void
-    {
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Upper bound must be DateTimeInterface');
-
-        new DateRange(new \DateTimeImmutable('2023-01-01'), 'invalid');
-    }
-
     #[Test]
     public function throws_exception_for_invalid_datetime_in_comparison_via_contains(): void
     {
@@ -275,15 +257,6 @@ public function throws_exception_for_invalid_datetime_in_comparison_via_contains
         $dateRange->contains('invalid');
     }
 
-    #[Test]
-    public function throws_exception_for_invalid_value_in_constructor(): void
-    {
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Lower bound must be DateTimeInterface');
-
-        new DateRange('invalid', new \DateTimeImmutable('2023-12-31'));
-    }
-
     #[Test]
     public function throws_exception_for_invalid_date_string_in_parse_via_from_string(): void
     {

tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/NumericRangeTest.php

@@ -137,15 +137,6 @@ public function throws_exception_for_invalid_numeric_bound_in_comparison_via_con
         $numericRange->contains('invalid');
     }
 
-    #[Test]
-    public function throws_exception_for_invalid_value_in_constructor(): void
-    {
-        $this->expectException(\InvalidArgumentException::class);
-        $this->expectExceptionMessage('Lower bound must be numeric');
-
-        new NumericRange('invalid', 10);
-    }
-
     #[Test]
     public function throws_exception_for_invalid_parse_value_via_from_string(): void
     {

tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/TstzRangeTest.php

@@ -175,45 +175,6 @@ public function handles_microseconds_with_timezone(): void
         self::assertEquals('[2023-01-01 10:00:00.123456+00:00,2023-01-01 18:00:00.654321+00:00)', (string) $tstzRange);
     }
 
-    public static function providesContainsTestCases(): \Generator
-    {
-        $tstzRange = new TstzRange(
-            new \DateTimeImmutable('2023-01-01 10:00:00+00:00'),
-            new \DateTimeImmutable('2023-01-01 18:00:00+00:00')
-        );
-
-        yield 'contains timestamp in range' => [$tstzRange, new \DateTimeImmutable('2023-01-01 14:00:00+00:00'), true];
-        yield 'contains lower bound (inclusive)' => [$tstzRange, new \DateTimeImmutable('2023-01-01 10:00:00+00:00'), true];
-        yield 'does not contain upper bound (exclusive)' => [$tstzRange, new \DateTimeImmutable('2023-01-01 18:00:00+00:00'), false];
-        yield 'does not contain timestamp before range' => [$tstzRange, new \DateTimeImmutable('2023-01-01 09:00:00+00:00'), false];
-        yield 'does not contain timestamp after range' => [$tstzRange, new \DateTimeImmutable('2023-01-01 19:00:00+00:00'), false];
-        yield 'does not contain null' => [$tstzRange, null, false];
-
-        $emptyRange = TstzRange::empty();
-        yield 'empty range contains nothing' => [$emptyRange, new \DateTimeImmutable('2023-01-01 14:00:00+00:00'), false];
-    }
-
-    public static function providesFromStringTestCases(): \Generator
-    {
-        yield 'simple range with timezone' => [
-            '[2023-01-01 10:00:00+00:00,2023-01-01 18:00:00+00:00)',
-            new TstzRange(new \DateTimeImmutable('2023-01-01 10:00:00+00:00'), new \DateTimeImmutable('2023-01-01 18:00:00+00:00')),
-        ];
-        yield 'inclusive range with timezone' => [
-            '[2023-01-01 10:00:00+02:00,2023-01-01 18:00:00+02:00]',
-            new TstzRange(new \DateTimeImmutable('2023-01-01 10:00:00+02:00'), new \DateTimeImmutable('2023-01-01 18:00:00+02:00'), true, true),
-        ];
-        yield 'infinite lower' => [
-            '[,2023-01-01 18:00:00+00:00)',
-            new TstzRange(null, new \DateTimeImmutable('2023-01-01 18:00:00+00:00')),
-        ];
-        yield 'infinite upper' => [
-            '[2023-01-01 10:00:00+00:00,)',
-            new TstzRange(new \DateTimeImmutable('2023-01-01 10:00:00+00:00'), null),
-        ];
-        yield 'empty range' => ['empty', TstzRange::empty()];
-    }
-
     #[Test]
     public function throws_exception_for_invalid_constructor_input(): void
     {