no message

Author: martin-georgiev

tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/BaseNetworkTypeArrayTest.php

@@ -6,6 +6,7 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use MartinGeorgiev\Doctrine\DBAL\Types\BaseNetworkTypeArray;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
@@ -55,24 +56,28 @@ public function has_name(): void
     }
 
     #[Test]
-    public function can_convert_null_to_database_value(): void
+    #[DataProvider('provideValidTransformations')]
+    public function can_convert_to_php_value(?array $phpValue, ?string $postgresValue): void
     {
-        self::assertNull($this->fixture->convertToDatabaseValue(null, $this->platform));
+        self::assertEquals($phpValue, $this->fixture->convertToPHPValue($postgresValue, $this->platform));
     }
 
-    #[Test]
-    public function can_convert_empty_array_to_database_value(): void
+    public static function provideValidTransformations(): array
     {
-        self::assertEquals('{}', $this->fixture->convertToDatabaseValue([], $this->platform));
-    }
-
-    #[Test]
-    public function can_convert_valid_array_to_database_value(): void
-    {
-        self::assertEquals(
-            '{"valid_address","valid_address"}',
-            $this->fixture->convertToDatabaseValue(['valid_address', 'valid_address'], $this->platform)
-        );
+        return [
+            'null' => [
+                'phpValue' => null,
+                'postgresValue' => null,
+            ],
+            'empty array' => [
+                'phpValue' => [],
+                'postgresValue' => '{}',
+            ],
+            'valid array' => [
+                'phpValue' => ['valid_address', 'valid_address'],
+                'postgresValue' => '{"valid_address","valid_address"}',
+            ],
+        ];
     }
 
     #[Test]
@@ -84,23 +89,31 @@ public function throws_exception_for_invalid_type(): void
     }
 
     #[Test]
-    public function can_convert_null_to_php_value(): void
+    #[DataProvider('provideInvalidValues')]
+    public function throws_exception_for_invalid_values(mixed $arrayItem, string $exceptionMessage): void
     {
-        self::assertNull($this->fixture->convertToPHPValue(null, $this->platform));
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage($exceptionMessage);
+        $this->fixture->transformArrayItemForPHP($arrayItem);
     }
 
-    #[Test]
-    public function can_convert_empty_array_to_php_value(): void
+    public static function provideInvalidValues(): array
     {
-        self::assertEquals([], $this->fixture->convertToPHPValue('{}', $this->platform));
+        return [
+            'invalid type' => [
+                'arrayItem' => [],
+                'exceptionMessage' => 'Invalid type',
+            ],
+            'invalid format' => [
+                'arrayItem' => '"invalid_address"',
+                'exceptionMessage' => 'Invalid format',
+            ],
+        ];
     }
 
     #[Test]
-    public function can_convert_valid_string_to_php_value(): void
+    public function transform_array_item_for_php_handles_valid_string(): void
     {
-        self::assertEquals(
-            ['valid_address', 'valid_address'],
-            $this->fixture->convertToPHPValue('{"valid_address","valid_address"}', $this->platform)
-        );
+        $this->assertSame('valid_address', $this->fixture->transformArrayItemForPHP('"valid_address"'));
     }
 }