Skip to content

Commit fb6e678

Browse files
committed
Remove the generic parameter of the Chart component
Currently there's no benefit to having a generic parameter there. I don't know why we didn't remove it before but better now than never.
1 parent 632df4d commit fb6e678

File tree

10 files changed

+16
-19
lines changed

10 files changed

+16
-19
lines changed

ChartJs.Blazor.Samples/Client/Pages/Charts/Bar/Horizontal.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@using System.Drawing
44
@layout SampleLayout
55

6-
<Chart TConfig="BarConfig" Config="_config" @ref="_chart"></Chart>
6+
<Chart Config="_config" @ref="_chart"></Chart>
77

88
<button @onclick="RandomizeData">Randomize Data</button>
99
<button @onclick="AddDataset">Add Dataset</button>
@@ -15,7 +15,7 @@
1515
private const int InitalCount = 7;
1616
private BarConfig _config;
1717
private Random _rng = new Random();
18-
private Chart<BarConfig> _chart;
18+
private Chart _chart;
1919

2020
protected override void OnInitialized()
2121
{

ChartJs.Blazor.Samples/Client/Pages/Charts/Bar/Stacked.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
@using ChartJs.Blazor.BarChart.Axes
44
@layout SampleLayout
55

6-
<Chart TConfig="BarConfig" Config="_config" @ref="_chart"></Chart>
6+
<Chart Config="_config" @ref="_chart"></Chart>
77

88
<button @onclick="RandomizeData">Randomize Data</button>
99

1010
@code {
1111
private const int InitalCount = 7;
1212
private BarConfig _config;
1313
private Random _rng = new Random();
14-
private Chart<BarConfig> _chart;
14+
private Chart _chart;
1515

1616
protected override void OnInitialized()
1717
{

ChartJs.Blazor.Samples/Client/Pages/Charts/Bar/Vertical.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@using System.Drawing
44
@layout SampleLayout
55

6-
<Chart TConfig="BarConfig" Config="_config" @ref="_chart"></Chart>
6+
<Chart Config="_config" @ref="_chart"></Chart>
77

88
<button @onclick="RandomizeData">Randomize Data</button>
99
<button @onclick="AddDataset">Add Dataset</button>
@@ -15,7 +15,7 @@
1515
private const int InitalCount = 7;
1616
private BarConfig _config;
1717
private Random _rng = new Random();
18-
private Chart<BarConfig> _chart;
18+
private Chart _chart;
1919

2020
protected override void OnInitialized()
2121
{

ChartJs.Blazor.Samples/Client/Pages/Charts/Line/Basic.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
@using ChartJs.Blazor.LineChart
33
@layout SampleLayout
44

5-
<Chart TConfig="LineConfig" Config="_config" @ref="_chart"></Chart>
5+
<Chart Config="_config" @ref="_chart"></Chart>
66

77
<button @onclick="RandomizeData">Randomize Data</button>
88
<button @onclick="AddDataset">Add Dataset</button>
@@ -14,7 +14,7 @@
1414
private const int InitalCount = 7;
1515
private LineConfig _config;
1616
private Random _rng = new Random();
17-
private Chart<LineConfig> _chart;
17+
private Chart _chart;
1818

1919
protected override void OnInitialized()
2020
{

ChartJs.Blazor.Samples/Client/Pages/Charts/Line/Stepped.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
@foreach (Variant variant in _variants)
77
{
88
<div class="chart-container">
9-
<Chart TConfig="LineConfig" Config="GetConfig(variant)"></Chart>
9+
<Chart Config="GetConfig(variant)"></Chart>
1010
</div>
1111
}
1212
</div>

ChartJs.Blazor.Samples/Client/Pages/Charts/Pie.razor

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@using System.Drawing
44
@layout SampleLayout
55

6-
<Chart TConfig="PieConfig" Config="_config" @ref="_chart"></Chart>
6+
<Chart Config="_config" @ref="_chart"></Chart>
77

88
<button @onclick="RandomizeData">Randomize Data</button>
99
<button @onclick="AddDataset">Add Dataset</button>
@@ -13,7 +13,7 @@
1313
private const int InitalCount = 5;
1414
private PieConfig _config;
1515
private Random _rng = new Random();
16-
private Chart<PieConfig> _chart;
16+
private Chart _chart;
1717

1818
protected override void OnInitialized()
1919
{

ChartJs.Blazor.Samples/Client/Pages/Workarounds/Gradient.razor

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@layout SampleLayout
44
@inject IJSRuntime jsRuntime
55

6-
<Chart TConfig="LineConfig" Config="_config" SetupCompletedCallback="@SetupCompletedCallback"></Chart>
6+
<Chart Config="_config" SetupCompletedCallback="@SetupCompletedCallback"></Chart>
77

88
@code {
99
private const int InitalCount = 7;

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ In order to use the classes for a pie chart, we need to add `@using ChartJs.Blaz
8383
Then we can add a `Chart` component anywhere in the markup like so:
8484

8585
```html
86-
<Chart TConfig="PieConfig" Config="_config"></Chart>
86+
<Chart Config="_config"></Chart>
8787
```
8888

8989
The only thing left to do now is to provide the data and chart configuration by declaring an instance variable which we reference in the `Chart` component.
@@ -202,7 +202,7 @@ If you run into an issue, we recommend you to do the following steps:
202202
* ***Alternative Option*** - manually invoke the `ReferenceConverter` constructor to avoid the linker optimizing it away. Example:
203203

204204
```csharp
205-
private ReferenceConverter ReferenceConverter = new ReferenceConverter(typeof(Chart<PieConfig>));
205+
private ReferenceConverter ReferenceConverter = new ReferenceConverter(typeof(Chart));
206206
```
207207

208208
# Contributors

src/ChartJs.Blazor/Chart.razor

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1 @@
1-
@typeparam TConfig
2-
31
<canvas id="@Config.CanvasId" width="@Width" height="@Height"></canvas>

src/ChartJs.Blazor/Chart.razor.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ namespace ChartJs.Blazor
1010
/// <summary>
1111
/// Represents a Chart.js chart.
1212
/// </summary>
13-
/// <typeparam name="TConfig">The type of config to pass to Chart.js.</typeparam>
14-
public partial class Chart<TConfig> where TConfig : ConfigBase
13+
public partial class Chart
1514
{
1615
/// <summary>
1716
/// This event is fired when the chart has been setup through interop and
@@ -31,7 +30,7 @@ public partial class Chart<TConfig> where TConfig : ConfigBase
3130
/// Gets or sets the configuration of the chart.
3231
/// </summary>
3332
[Parameter]
34-
public TConfig Config { get; set; }
33+
public ConfigBase Config { get; set; }
3534

3635
/// <summary>
3736
/// Gets or sets the width of the canvas HTML element.

0 commit comments

Comments
 (0)