Improve source location for element access expression #83

Author: marinasundstrom

CheckedExceptions/CheckedExceptionsAnalyzer.Shared.cs

@@ -130,6 +130,9 @@ private static Location GetSignificantLocation(SyntaxNode expression)
         if (expression is InvocationExpressionSyntax)
             return GetSignificantInvocationLocation(expression);
 
+        if (expression is ElementAccessExpressionSyntax)
+            return GetSignificantInvocationLocation(expression);
+
         var node = GetSignificantNodeCore(expression);
         return node.GetLocation();
     }
@@ -141,6 +144,11 @@ private static SyntaxNode GetSignificantNodeCore(SyntaxNode expression)
             return GetSignificantNodeCore(ie.Expression);
         }
 
+        if (expression is ElementAccessExpressionSyntax ea)
+        {
+            return GetSignificantNodeCore(ea.Expression);
+        }
+
         if (expression is MemberAccessExpressionSyntax mae)
         {
             return mae.Name;
@@ -163,6 +171,18 @@ private static Location GetSignificantInvocationLocation(SyntaxNode expression)
             var span = TextSpan.FromBounds(start, end);
             return Location.Create(invocation.SyntaxTree, span);
         }
+        else if (expression is ElementAccessExpressionSyntax elementAccess)
+        {
+            // Get the name part (e.g., bar in foo.bar[2])
+            var nameNode = GetSignificantNodeCore(elementAccess.Expression);
+
+            // Compute the span from name start to the full invocation end
+            var start = nameNode.SpanStart;
+            var end = elementAccess.Span.End;
+
+            var span = TextSpan.FromBounds(start, end);
+            return Location.Create(elementAccess.SyntaxTree, span);
+        }
 
         return expression.GetLocation();
     }