Bug 1992551 - Simplify text editor value getter. r=smaug

Textarea no longer creates newlines in the middle (it only has a
trailing newline for caret positioning purposes), so this is equivalent
but avoids going through nsDocumentEncoder, nsPlainTextSerializer and so
on...

Differential Revision: https://phabricator.services.mozilla.com/D267509

UltraBlame original commit: a099475af71c851f2352f87c9a380b9ed156a392

Author: marco-c

dom/html/TextControlState.cpp

@@ -2468,26 +2468,8 @@ void TextControlState::GetValue(nsAString& aValue, bool aForDisplay) const {
     }
 
     aValue.Truncate();  
-
-    uint32_t flags = nsIDocumentEncoder::OutputLFLineBreak |
-                     nsIDocumentEncoder::OutputPreformatted |
-                     nsIDocumentEncoder::OutputPersistNBSP |
-                     nsIDocumentEncoder::OutputBodyOnly;
-    
-    
-    
-    
-    
-    
-    
-    
-    
-    
-    
-    
     if (mEditorInitialized) {
-      AutoNoJSAPI nojsapi;
-      DebugOnly<nsresult> rv = mTextEditor->ComputeTextValue(flags, aValue);
+      DebugOnly<nsresult> rv = mTextEditor->ComputeTextValue(aValue);
       MOZ_ASSERT(aValue.FindChar(u'\r') == -1);
       NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Failed to get value");
     }
@@ -2829,7 +2811,7 @@ bool TextControlState::SetValueWithTextEditor(
     IMEContentObserver* observer = GetIMEContentObserver();
     if (observer && observer->WasInitializedWith(*textEditor)) {
       nsAutoString currentValue;
-      textEditor->ComputeTextValue(0, currentValue);
+      textEditor->ComputeTextValue(currentValue);
       observer->OnTextControlValueChangedWhileNotObservable(currentValue);
     }
   }

editor/libeditor/TextEditor.cpp

@@ -372,6 +372,22 @@ NS_IMETHODIMP TextEditor::InsertLineBreak() {
   return EditorBase::ToGenericNSResult(rv);
 }
 
+nsresult TextEditor::ComputeTextValue(nsAString& aString) const {
+  Element* anonymousDivElement = GetRoot();
+  if (NS_WARN_IF(!anonymousDivElement)) {
+    return NS_ERROR_NOT_INITIALIZED;
+  }
+
+  auto* text = Text::FromNodeOrNull(anonymousDivElement->GetFirstChild());
+  if (MOZ_UNLIKELY(!text)) {
+    MOZ_ASSERT_UNREACHABLE("how?");
+    return NS_ERROR_UNEXPECTED;
+  }
+
+  text->GetData(aString);
+  return NS_OK;
+}
+
 nsresult TextEditor::InsertLineBreakAsAction(nsIPrincipal* aPrincipal) {
   AutoEditActionDataSetter editActionData(*this, EditAction::eInsertLineBreak,
                                           aPrincipal);

editor/libeditor/TextEditor.h

@@ -185,23 +185,7 @@ class TextEditor final : public EditorBase,
 
 
 
-
-
-
-
-  nsresult ComputeTextValue(uint32_t aDocumentEncoderFlags,
-                            nsAString& aOutputString) const {
-    AutoEditActionDataSetter editActionData(*this, EditAction::eNotEditing);
-    if (NS_WARN_IF(!editActionData.CanHandle())) {
-      return NS_ERROR_NOT_INITIALIZED;
-    }
-    nsresult rv = ComputeValueInternal(u"text/plain"_ns, aDocumentEncoderFlags,
-                                       aOutputString);
-    if (NS_WARN_IF(NS_FAILED(rv))) {
-      return EditorBase::ToGenericNSResult(rv);
-    }
-    return NS_OK;
-  }
+  nsresult ComputeTextValue(nsAString&) const;