MC-36149: [CLOUD] 'Be the first to review this product' link is not changed after admin has approved the review

Author: viktorpetryk

app/code/Magento/Review/Block/Product/ReviewRenderer.php

@@ -13,7 +13,7 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\View\Element\Template;
 use Magento\Framework\View\Element\Template\Context;
-use Magento\Review\Model\AppendSummaryDataToObjectByEntityCodeFactory;
+use Magento\Review\Model\AppendSummaryDataFactory;
 use Magento\Review\Model\Review;
 use Magento\Review\Model\ReviewFactory;
 use Magento\Review\Model\ReviewSummaryFactory;
@@ -48,29 +48,29 @@ class ReviewRenderer extends Template implements ReviewRendererInterface
     private $reviewSummaryFactory;
 
     /**
-     * @var AppendSummaryDataToObjectByEntityCodeFactory
+     * @var AppendSummaryDataFactory
      */
-    private $appendSummaryDataToObjectByEntityCodeFactory;
+    private $appendSummaryDataFactory;
 
     /**
      * @param Context $context
      * @param ReviewFactory $reviewFactory
      * @param array $data
      * @param ReviewSummaryFactory|null $reviewSummaryFactory
-     * @param AppendSummaryDataToObjectByEntityCodeFactory|null $appendSummaryDataToObjectByEntityCodeFactory
+     * @param AppendSummaryDataFactory|null $appendSummaryDataFactory
      */
     public function __construct(
         Context $context,
         ReviewFactory $reviewFactory,
         array $data = [],
         ReviewSummaryFactory $reviewSummaryFactory = null,
-        AppendSummaryDataToObjectByEntityCodeFactory $appendSummaryDataToObjectByEntityCodeFactory = null
+        AppendSummaryDataFactory $appendSummaryDataFactory = null
     ) {
         $this->_reviewFactory = $reviewFactory;
         $this->reviewSummaryFactory = $reviewSummaryFactory ??
             ObjectManager::getInstance()->get(ReviewSummaryFactory::class);
-        $this->appendSummaryDataToObjectByEntityCodeFactory = $appendSummaryDataToObjectByEntityCodeFactory ??
-            ObjectManager::getInstance()->get(AppendSummaryDataToObjectByEntityCodeFactory::class);
+        $this->appendSummaryDataFactory = $appendSummaryDataFactory ??
+            ObjectManager::getInstance()->get(AppendSummaryDataFactory::class);
         parent::__construct($context, $data);
     }
 
@@ -104,7 +104,7 @@ public function getReviewsSummaryHtml(
         $displayIfNoReviews = false
     ) {
         if ($product->getRatingSummary() === null) {
-            $this->appendSummaryDataToObjectByEntityCodeFactory->create()
+            $this->appendSummaryDataFactory->create()
                 ->execute(
                     $product,
                     $this->_storeManager->getStore()->getId(),

…ppendSummaryDataToObjectByEntityCode.php …gento/Review/Model/AppendSummaryData.phpapp/code/Magento/Review/Model/AppendSummaryDataToObjectByEntityCode.php renamed to app/code/Magento/Review/Model/AppendSummaryData.php app/code/Magento/Review/Model/AppendSummaryDataToObjectByEntityCode.php renamed to app/code/Magento/Review/Model/AppendSummaryData.php

@@ -13,7 +13,7 @@
 /**
  * Add review summary data to object by its entity code
  */
-class AppendSummaryDataToObjectByEntityCode
+class AppendSummaryData
 {
     /**
      * @var SummaryCollectionFactory
@@ -30,6 +30,8 @@ public function __construct(
     }
 
     /**
+     * Append summary data to object filtered by its entity code
+     *
      * @param AbstractModel $object
      * @param int $storeId
      * @param string $entityCode
@@ -45,7 +47,7 @@ public function execute(AbstractModel $object, int $storeId, string $entityCode)
                 'main_table.entity_type = review_entity.entity_id',
                 'entity_code'
             )
-            ->where('entity_pk_value IN (?)', $object->getId())
+            ->where('entity_pk_value = ?', $object->getId())
             ->where('entity_code = ?', $entityCode);
         $summaryItem = $summaryCollection->getFirstItem();
 

app/code/Magento/Review/Model/ReviewSummary.php

@@ -14,7 +14,7 @@
  * ReviewSummary model.
  *
  * @deprecated Filtering collection by entity_type ID leads to wrong result if AUTO_INCREMENT begins not form 1.
- * @see \Magento\Review\Model\AppendSummaryDataToObjectByEntityCode
+ * @see \Magento\Review\Model\AppendSummaryData
  */
 class ReviewSummary
 {

…dSummaryDataToObjectByEntityCodeTest.php …est/Unit/Model/AppendSummaryDataTest.phpapp/code/Magento/Review/Test/Unit/Model/AppendSummaryDataToObjectByEntityCodeTest.php renamed to app/code/Magento/Review/Test/Unit/Model/AppendSummaryDataTest.php app/code/Magento/Review/Test/Unit/Model/AppendSummaryDataToObjectByEntityCodeTest.php renamed to app/code/Magento/Review/Test/Unit/Model/AppendSummaryDataTest.php

@@ -9,7 +9,7 @@
 
 use Magento\Catalog\Model\Product;
 use Magento\Framework\DB\Select;
-use Magento\Review\Model\AppendSummaryDataToObjectByEntityCode;
+use Magento\Review\Model\AppendSummaryData;
 use Magento\Review\Model\ResourceModel\Review\Summary as ResourceSummary;
 use Magento\Review\Model\ResourceModel\Review\Summary\Collection as SummaryCollection;
 use Magento\Review\Model\ResourceModel\Review\Summary\CollectionFactory as SummaryCollectionFactory;
@@ -18,9 +18,9 @@
 use PHPUnit\Framework\TestCase;
 
 /**
- * Unit tests for \Magento\Review\Model\AppendSummaryDataToObjectByEntityCode class
+ * Unit tests for \Magento\Review\Model\AppendSummaryData class
  */
-class AppendSummaryDataToObjectByEntityCodeTest extends TestCase
+class AppendSummaryDataTest extends TestCase
 {
     /**
      * @var SummaryCollectionFactory|MockObject
@@ -53,7 +53,7 @@ class AppendSummaryDataToObjectByEntityCodeTest extends TestCase
     private $resourceSummaryMock;
 
     /**
-     * @var AppendSummaryDataToObjectByEntityCode
+     * @var AppendSummaryData
      */
     private $model;
 
@@ -99,7 +99,7 @@ protected function setUp(): void
             ->onlyMethods(['getTable'])
             ->getMock();
 
-        $this->model = new AppendSummaryDataToObjectByEntityCode(
+        $this->model = new AppendSummaryData(
             $this->summaryCollectionFactoryMock
         );
     }