30350:Unable to update the items of a bundle-product in a wishlist- Resolved webAPI test issues

Author: ranaprathapm-kensium

app/code/Magento/WishlistGraphQl/Model/Resolver/UpdateProductsInWishlist.php

@@ -104,7 +104,7 @@ public function resolve(
         $wishlistOutput = "";
 
         foreach ($wishlistItems as $wishlistItem) {
-            $wishlistOutput = $this->updateWishlistItem->execute($wishlistItem->getId(), $wishlistItem, $wishlist);
+            $wishlistOutput = $this->updateWishlistItem->execute($wishlistItem, $wishlist);
         }
 
         if (count($wishlistOutput->getErrors()) !== count($wishlistItems)) {
@@ -174,3 +174,4 @@ private function getWishlist(?int $wishlistId, ?int $customerId): Wishlist
         return $wishlist;
     }
 }
+

app/code/Magento/WishlistGraphQl/Model/UpdateWishlistItem.php

@@ -12,6 +12,7 @@
 use Magento\Wishlist\Model\Wishlist;
 use Magento\Wishlist\Model\Wishlist\Data\WishlistOutput;
 use Magento\Wishlist\Model\Wishlist\BuyRequest\BuyRequestBuilder;
+use Magento\Wishlist\Model\Wishlist\Data\Error;
 
 /**
  * Update wishlist items helper
@@ -34,6 +35,8 @@ class UpdateWishlistItem
      */
     private $buyRequestBuilder;
 
+    private const ERROR_UNDEFINED = 'UNDEFINED';
+
     /**
      * @param WishlistResourceModel $wishlistResource
      * @param BuyRequestBuilder $buyRequestBuilder
@@ -49,61 +52,84 @@ public function __construct(
     /**
      * Update wishlist Item and set data from request
      *
-     * @param int $itemId
      * @param object $options
      * @param Wishlist $wishlist
      *
      * @return WishlistOutput
      * @throws GraphQlInputException
      * @throws \Magento\Framework\Exception\LocalizedException
      */
-    public function execute(int $itemId, object $options, Wishlist $wishlist)
+    public function execute(object $options, Wishlist $wishlist)
     {
-        $buyRequest = $this->buyRequestBuilder->build($options);
-        $item = $wishlist->getItem((int)$itemId);
-
-        if (!$item) {
-            throw new GraphQlInputException(__('We can\'t specify a wish list item.'));
-        }
-
-        $product = $item->getProduct();
-        $productId = $product->getId();
+        $itemId = $options->getId();
+        if ($wishlist->getItem($itemId) == null) {
+            $this->addError(
+                __(
+                    'The wishlist item with ID "%id" does not belong to the wishlist',
+                    ['id' => $itemId]
+                )->render()
+            );
+        } else {
+            $buyRequest = $this->buyRequestBuilder->build($options);
+            $item = $wishlist->getItem((int)$itemId);
+            $product = $item->getProduct();
+            $productId = $product->getId();
 
-        if ($productId) {
-            $buyRequest->setData('action', 'updateItem');
-            $product->setWishlistStoreId($item->getStoreId());
-            $cartCandidates = $product->getTypeInstance()->processConfiguration($buyRequest, clone $product);
+            if ($productId) {
+                $buyRequest->setData('action', 'updateItem');
+                $product->setWishlistStoreId($item->getStoreId());
+                $cartCandidates = $product->getTypeInstance()->processConfiguration($buyRequest, clone $product);
 
-            /**
-             * If the product with options existed or not
-             */
-            if (is_string($cartCandidates)) {
-                throw new GraphQlInputException(__('The product with options does not exist.'));
-            }
+                /**
+                 * If the product with options existed or not
+                 */
+                if (is_string($cartCandidates)) {
+                    throw new GraphQlInputException(__('The product with options does not exist.'));
+                }
 
-            /**
-             * If prepare process return one object
-             */
-            if (!is_array($cartCandidates)) {
-                $cartCandidates = [$cartCandidates];
-            }
+                /**
+                 * If prepare process return one object
+                 */
+                if (!is_array($cartCandidates)) {
+                    $cartCandidates = [$cartCandidates];
+                }
 
-            foreach ($cartCandidates as $candidate) {
-                if ($candidate->getParentProductId()) {
-                    continue;
+                foreach ($cartCandidates as $candidate) {
+                    if ($candidate->getParentProductId()) {
+                        continue;
+                    }
+                    $candidate->setWishlistStoreId($item->getStoreId());
+                    $qty = $buyRequest->getData('qty') ? $buyRequest->getData('qty') : 1;
+                    $item->setOptions($candidate->getCustomOptions());
+                    $item->setQty($qty);
+                    if($options->getDescription()) {
+                        $item->setDescription($options->getDescription());
+                    }
                 }
-                $candidate->setWishlistStoreId($item->getStoreId());
-                $qty = $buyRequest->getData('qty') ? $buyRequest->getData('qty') : 1;
-                $item->setOptions($candidate->getCustomOptions());
-                $item->setQty($qty);
+                $this->wishlistResource->save($wishlist);
+            } else {
+                throw new GraphQlInputException(__('The product does not exist.'));
             }
-            $this->wishlistResource->save($wishlist);
-        } else {
-            throw new GraphQlInputException(__('The product does not exist.'));
         }
         return $this->prepareOutput($wishlist);
     }
 
+    /**
+     * Add wishlist line item error
+     *
+     * @param string $message
+     * @param string|null $code
+     *
+     * @return void
+     */
+    private function addError(string $message, string $code = null): void
+    {
+        $this->errors[] = new Error(
+            $message,
+            $code ?? self::ERROR_UNDEFINED
+        );
+    }
+
     /**
      * Prepare output
      *
@@ -119,3 +145,4 @@ private function prepareOutput(Wishlist $wishlist): WishlistOutput
         return $output;
     }
 }
+

dev/tests/api-functional/testsuite/Magento/GraphQl/Wishlist/UpdateBundleProductsFromWishlistTest.php

@@ -82,6 +82,7 @@ public function testUpdateBundleProductWithOptions(): void
 
         $query = $this->getBundleQuery((int)$wishlistItemId, $qty, $bundleOptions, (int)$wishlistId);
         $response = $this->graphQlMutation($query, [], '', $this->getHeaderMap());
+
         $this->assertArrayHasKey('updateProductsInWishlist', $response);
         $this->assertArrayHasKey('wishlist', $response['updateProductsInWishlist']);
         $response = $response['updateProductsInWishlist']['wishlist'];