MC-38625: Storefront Order History product count is doubled if has more than 10 configurables

Author: Serhii Balko

app/code/Magento/Sales/Block/Order/Items.php

@@ -9,18 +9,29 @@
  */
 namespace Magento\Sales\Block\Order;
 
+use Magento\Framework\App\ObjectManager;
+use Magento\Framework\DataObject;
+use Magento\Framework\Registry;
+use Magento\Framework\View\Element\AbstractBlock;
+use Magento\Framework\View\Element\Template\Context;
+use Magento\Sales\Block\Items\AbstractItems;
+use Magento\Sales\Model\Order;
+use Magento\Sales\Model\ResourceModel\Order\Item\Collection;
+use Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory;
+use Magento\Theme\Block\Html\Pager;
+
 /**
  * Sales order view items block.
  *
  * @api
  * @since 100.0.2
  */
-class Items extends \Magento\Sales\Block\Items\AbstractItems
+class Items extends AbstractItems
 {
     /**
      * Core registry
      *
-     * @var \Magento\Framework\Registry
+     * @var Registry
      */
     protected $_coreRegistry = null;
 
@@ -32,30 +43,30 @@ class Items extends \Magento\Sales\Block\Items\AbstractItems
     private $itemsPerPage;
 
     /**
-     * @var \Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory
+     * @var CollectionFactory
      */
     private $itemCollectionFactory;
 
     /**
-     * @var \Magento\Sales\Model\ResourceModel\Order\Item\Collection|null
+     * @var Collection|null
      */
     private $itemCollection;
 
     /**
-     * @param \Magento\Framework\View\Element\Template\Context $context
-     * @param \Magento\Framework\Registry $registry
+     * @param Context $context
+     * @param Registry $registry
      * @param array $data
-     * @param \Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory|null $itemCollectionFactory
+     * @param CollectionFactory|null $itemCollectionFactory
      */
     public function __construct(
-        \Magento\Framework\View\Element\Template\Context $context,
-        \Magento\Framework\Registry $registry,
+        Context $context,
+        Registry $registry,
         array $data = [],
-        \Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory $itemCollectionFactory = null
+        CollectionFactory $itemCollectionFactory = null
     ) {
         $this->_coreRegistry = $registry;
-        $this->itemCollectionFactory = $itemCollectionFactory ?: \Magento\Framework\App\ObjectManager::getInstance()
-            ->get(\Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory::class);
+        $this->itemCollectionFactory = $itemCollectionFactory ?: ObjectManager::getInstance()
+            ->get(CollectionFactory::class);
         parent::__construct($context, $data);
     }
 
@@ -68,19 +79,12 @@ public function __construct(
     protected function _prepareLayout()
     {
         $this->itemsPerPage = $this->_scopeConfig->getValue('sales/orders/items_per_page');
+        $this->itemCollection = $this->createItemsCollection();
 
-        $this->itemCollection = $this->itemCollectionFactory->create();
-        $this->itemCollection->setOrderFilter($this->getOrder());
-        $this->itemCollection->addFieldToFilter('parent_item_id', ['null' => true]);
-
-        /** @var \Magento\Theme\Block\Html\Pager $pagerBlock */
+        /** @var Pager $pagerBlock */
         $pagerBlock = $this->getChildBlock('sales_order_item_pager');
         if ($pagerBlock) {
-            $pagerBlock->setLimit($this->itemsPerPage);
-            //here pager updates collection parameters
-            $pagerBlock->setCollection($this->itemCollection);
-            $pagerBlock->setAvailableLimit([$this->itemsPerPage]);
-            $pagerBlock->setShowAmounts($this->isPagerDisplayed());
+            $this->preparePager($pagerBlock);
         }
 
         return parent::_prepareLayout();
@@ -105,7 +109,7 @@ public function isPagerDisplayed()
      *
      * To be called from templates(after _prepareLayout()).
      *
-     * @return \Magento\Framework\DataObject[]
+     * @return DataObject[]
      * @since 100.1.7
      */
     public function getItems()
@@ -123,18 +127,47 @@ public function getItems()
      */
     public function getPagerHtml()
     {
-        /** @var \Magento\Theme\Block\Html\Pager $pagerBlock */
+        /** @var Pager $pagerBlock */
         $pagerBlock = $this->getChildBlock('sales_order_item_pager');
         return $pagerBlock ? $pagerBlock->toHtml() : '';
     }
 
     /**
      * Retrieve current order model instance
      *
-     * @return \Magento\Sales\Model\Order
+     * @return Order
      */
     public function getOrder()
     {
         return $this->_coreRegistry->registry('current_order');
     }
+
+    /**
+     * Prepare pager block
+     *
+     * @param AbstractBlock $pagerBlock
+     */
+    private function preparePager(AbstractBlock $pagerBlock): void
+    {
+        $collectionToPager = $this->createItemsCollection();
+        $collectionToPager->addFieldToFilter('parent_item_id', ['null' => true]);
+        $pagerBlock->setCollection($collectionToPager);
+
+        $pagerBlock->setLimit($this->itemsPerPage);
+        $pagerBlock->setAvailableLimit([$this->itemsPerPage]);
+        $pagerBlock->setShowAmounts($this->isPagerDisplayed());
+    }
+
+    /**
+     * Create items collection
+     *
+     * @return Collection
+     */
+    private function createItemsCollection(): Collection
+    {
+        $collection = $this->itemCollectionFactory->create();
+        $collection->setOrderFilter($this->getOrder());
+
+        return $collection;
+    }
 }