B2B-1671: Detect Missing Primary Key in Table Schema Test

Author: joanhe

dev/tests/static/testsuite/Magento/Test/Integrity/DBSchema/PrimaryKeyTest.php

@@ -14,21 +14,19 @@
 use PHPUnit\Framework\TestCase;
 
 /**
- * Test for existance of primary key in database tables
+ * Test for finding database tables missing primary key
  */
 class PrimaryKeyTest extends TestCase
 {
-    private $blockWhitelist;
-
     /**
-     * Check existance of database tables' primary key
+     * Check missing database tables' primary key
      *
      * @throws LocalizedException
      */
     public function testMissingPrimaryKey()
     {
-        $exemptionList = $this->getExemptionlist();
-        $tablesSchemaDeclaration = $this->getDbSchemaDeclaration()['table'];
+        $exemptionList = $this->getExemptionList();
+        $tablesSchemaDeclaration = $this->getDbSchemaDeclarations()['table'];
         $exemptionList = array_intersect(array_keys($tablesSchemaDeclaration), $exemptionList);
         foreach ($exemptionList as $exemptionTableName) {
             unset($tablesSchemaDeclaration[$exemptionTableName]);
@@ -91,9 +89,9 @@ private function getDbSchemaDeclarationByFile(string $filePath): array
      * @return array
      * @throws LocalizedException
      */
-    private function getDbSchemaDeclaration(): array
+    private function getDbSchemaDeclarations(): array
     {
-        $declaration = [];
+        $declarations = [];
         foreach (Files::init()->getDbSchemaFiles() as $filePath) {
             $filePath = reset($filePath);
             preg_match('#app/code/(\w+/\w+)#', $filePath, $result);
@@ -107,23 +105,24 @@ private function getDbSchemaDeclaration(): array
                 array_push($tableDeclaration['modules'], $moduleName);
                 $moduleDeclaration = array_replace_recursive(
                     $moduleDeclaration,
-                    ['table' => [
-                        $tableName => $tableDeclaration,
-                    ]
+                    [
+                        'table' => [
+                            $tableName => $tableDeclaration,
+                        ]
                     ]
                 );
             }
-            $declaration = array_merge_recursive($declaration, $moduleDeclaration);
+            $declarations = array_merge_recursive($declarations, $moduleDeclaration);
         }
-        return $declaration;
+        return $declarations;
     }
 
     /**
      * Return primary key exemption tables list
      *
      * @return string[]
      */
-    private function getExemptionlist(): array
+    private function getExemptionList(): array
     {
         $exemptionListFiles = str_replace(
             '\\',