Merge pull request #14 from mcspronko/header-link-template

Removed ObjectManager dependency from the header_link.phtml

Author: magefan

Block/Link.php

@@ -6,24 +6,34 @@
 
 namespace Magefan\HtmlSitemap\Block;
 
+use Magefan\HtmlSitemap\Model\Config;
+
 class Link extends \Magento\Framework\View\Element\Html\Link
 {
     /**
      * @var \Magefan\HtmlSitemap\Model\Url
      */
     protected $_url;
 
+    /**
+     * @var Config
+     */
+    private Config $config;
+
     /**
      * @param \Magento\Framework\View\Element\Template\Context $context
-     * @param \Magefan\HtmlSitemap\Model\Url $url
+     * @param \Magento\Framework\UrlInterface $url
+     * @param Config $config
      * @param array $data
      */
     public function __construct(
         \Magento\Framework\View\Element\Template\Context $context,
         \Magento\Framework\UrlInterface $url,
+        Config $config,
         array $data = []
     ) {
         $this->_url = $url;
+        $this->config = $config;
         parent::__construct($context, $data);
     }
 
@@ -72,4 +82,20 @@ protected function _toHtml()
         }
         return parent::_toHtml();
     }
+
+    /**
+     * @return bool
+     */
+    public function canShowSitemapLink(): bool
+    {
+        return in_array('1', $this->getDisplayIn());
+    }
+
+    /**
+     * @return array
+     */
+    private function getDisplayIn(): array
+    {
+        return explode(',', $this->config->displayIn());
+    }
 }

view/frontend/templates/header_link.phtml

@@ -4,23 +4,18 @@
  * Please visit Magefan.com for license details (https://magefan.com/end-user-license-agreement).
  */
 
-/**
- * @var $block \Magefan\HtmlSitemap\Block\Link
- */
-?>
+use Magefan\HtmlSitemap\Block\Link;
+use Magento\Framework\Escaper;
 
-<?php
-$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
-$config = $objectManager->create(\Magefan\HtmlSitemap\Model\Config::class);
-$displayInArray = explode(',', $config->displayIn());
-$openLinks = ($block->getOpenLinks() == 1) ? '' : 'target="_blank"';
+/** @var Link $block */
+/** @var Escaper $escaper */
+
+$openLinks = $block->getOpenLinks() == 1 ? '' : 'target="_blank"';
 ?>
-<?php if ($config->isEnabled()): ?>
-    <?php if (in_array('1', $displayInArray)): ?>
+<?php if ($block->canShowSitemapLink()): ?>
     <li>
-        <a href="<?= $block->escapeUrl($block->getHref()) ?>" name="header_htmlsitemap_link" <?= $openLinks ?>>
-            <?= $block->escapeHtml($block->getLabel()) ?>
+        <a href="<?= $escaper->escapeUrl($block->getHref()) ?>" name="header_htmlsitemap_link" <?= $openLinks ?>>
+            <?= $escaper->escapeHtml($block->getLabel()) ?>
         </a>
     </li>
-    <?php endif ?>
 <?php endif ?>