POC for laravel/framework#31778 bulletproofing incrementOrDecrement

Author: Pantea Marius-ciclistu

src/Models/BaseModel.php

@@ -469,7 +469,7 @@ public function getCasts()
      */
     protected function incrementOrDecrement($column, $amount, $extra, $method): int
     {
-        $return = parent::incrementOrDecrement($column, $amount, $extra, $method);
+        $return = (int)parent::incrementOrDecrement($column, $amount, $extra, $method);
 
         if ($this->exists) {
             $this->incrementsToRefresh[$column] = true;
@@ -782,18 +782,18 @@ protected function performUpdate(Builder $query): bool
         // Once we have run the update operation, we will fire the "updated" event for
         // this model instance. This will allow developers to hook into these after
         // models are updated, giving them a chance to do any special processing.
-        $dirty = $this->getDirtyForUpdate();
+        if ([] === $dirty = $this->getDirtyForUpdate()) {
+            return false;
+        }
 
-        if ([] !== $dirty) {
-            $this->setKeysForSaveQuery($query)->update($dirty);
+        $this->setKeysForSaveQuery($query)->update($dirty);
 
-            $this->syncChanges();
+        $this->syncChanges();
 
-            $this->tmpDirtyIfAttributesAreSyncedFromCashedCasts = null;
-            $this->tmpOriginalBeforeAfterEvents = $this->attributes;
+        $this->tmpDirtyIfAttributesAreSyncedFromCashedCasts = null;
+        $this->tmpOriginalBeforeAfterEvents = $this->attributes;
 
-            $this->fireModelEvent('updated', false);
-        }
+        $this->fireModelEvent('updated', false);
 
         return true;
     }