Fixed bug in AuthenticationAPI. Token refresh requires an existing, valid token which collided with the current auto-login functionality. Session authorization status will now only be set when calling the "/login" route.

Author: m0nk3y2k4

src/main/java/com/github/m0nk3y2k4/thetvdb/internal/resource/impl/AuthenticationAPI.java

@@ -38,16 +38,16 @@ public static void login(@Nonnull APIConnection con) throws APIException {
             authentication.put("username", con.getUserName().get());
         }
 
+        con.setStatus(APISession.Status.AUTHORIZATION_IN_PROGRESS);
         setToken(con, () -> con.sendPOST("/login", authentication.toString()));
+        con.setStatus(APISession.Status.AUTHORIZED);
     }
 
     public static void refreshSession(@Nonnull APIConnection con) throws APIException {
         setToken(con, () -> con.sendGET("/refresh_token"));
     }
 
     private static void setToken(APIConnection con, ThrowingSupplier<JsonNode> sendRequest) throws APIException {
-        con.setStatus(APISession.Status.AUTHORIZATION_IN_PROGRESS);
-
         // Request token
         JsonNode response = sendRequest.get();              // Throws exception if authorization fails
         String token = response.get("token").asText();
@@ -57,8 +57,6 @@ private static void setToken(APIConnection con, ThrowingSupplier<JsonNode> sendR
 
         // Set token on connection
         con.setToken(token);
-
-        con.setStatus(APISession.Status.AUTHORIZED);
     }
 
     /**