From f672be089420f6ce46c7586571ea9c962a4bc541 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 14 Dec 2022 12:23:23 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- src/updater/Updater.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/updater/Updater.py b/src/updater/Updater.py index 5847f6f..d269284 100644 --- a/src/updater/Updater.py +++ b/src/updater/Updater.py @@ -171,7 +171,26 @@ def extract_archive(self) -> None: pass with tarfile.open("pymoda-temp.tar.gz") as f: - f.extractall("pymoda-temp") + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(f, "pymoda-temp") os.remove("pymoda-temp.tar.gz")