update Ellalgo version to 1.3.5; add set_witness_vec()

Author: luk036

CMakeLists.txt

@@ -12,7 +12,7 @@ option(INSTALL_ONLY "Enable for installation only" OFF)
 # Note: update this to your new project's name and version
 project(
   LmiSolver
-  VERSION 1.3.3
+  VERSION 1.3.4
   LANGUAGES CXX
 )
 

include/lmisolver/ldlt_ext.hpp

@@ -120,6 +120,12 @@ template <typename Arr036> class ldlt_ext {
    */
   auto witness() -> double;
 
+  auto set_witness_vec(Arr036 &v) const -> void {
+    for (auto i = 0U; i != this->_n; ++i) {
+      v[i] = this->witness_vec[i];
+    }
+  }
+
   /**
    * @brief Calculate v'*{A}(p,p)*v
    *

specific.cmake

@@ -19,7 +19,7 @@ endif(xtensor_ADDED)
 
 CPMAddPackage(
   NAME EllAlgo
-  GIT_TAG 1.3.4
+  GIT_TAG 1.3.5
   GITHUB_REPOSITORY luk036/ellalgo-cpp
   OPTIONS "INSTALL_ONLY YES" # create an installable target
 )

test/CMakeLists.txt

@@ -24,7 +24,7 @@ set_target_properties(${PROJECT_NAME}Tests PROPERTIES CXX_STANDARD 17)
 # enable compiler warnings
 if(CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
   # target_compile_options(${PROJECT_NAME} PUBLIC -Wall -Wpedantic -Wextra -Werror)
-  target_compile_options(${PROJECT_NAME} PUBLIC -Wall -Wextra)
+  target_compile_options(${PROJECT_NAME} PUBLIC -Wall -Wextra -Wconversion)
 elseif(MSVC)
   target_compile_options(${PROJECT_NAME} PUBLIC /W4 /WX /wd4819 /wd4146 /wd4127)
   target_compile_definitions(${PROJECT_NAME}Tests PUBLIC DOCTEST_CONFIG_USE_STD_HEADERS)

test/source/test_ldlt.cpp

@@ -32,6 +32,10 @@ TEST_CASE("Cholesky test 3") {
   Q3.factorize(m3);
   CHECK(!Q3.is_spd());
   const auto ep3 = Q3.witness();
+  Arr v = xt::zeros<double>({m3.shape()[0]});
+  Q3.set_witness_vec(v);
+
   // CHECK(Q3.p.second == 1);
-  CHECK(ep3 == 0.);
+  CHECK_EQ(ep3, 0.0);
+  CHECK_EQ(v[0], 1.0);
 }