chore: remove obsolete collection properties (#14)

Author: lucassouzavieira

src/Collection/Collection.php

@@ -127,12 +127,9 @@ class Collection implements JsonSerializable
      * Default values when creating collections
      */
     private array $defaults = [
-        'journalSize' => 1048576,
         'replicationFactor' => 1,
         'waitForSync' => false,
-        'doCompact' => true,
         'shardingStrategy' => 'community-compat',
-        'isVolatile' => false,
         'shardKeys' => ["_key"],
         'numberOfShards' => 1,
         'isSystem' => false,
@@ -142,7 +139,6 @@ class Collection implements JsonSerializable
             'type' => 'traditional',
             'lastValue' => 0
         ],
-        'indexBuckets' => 16
     ];
 
     /**
@@ -501,7 +497,7 @@ public function dropIndex(IndexInterface $index): bool
 
     /**
      * Saves or update the collection.
-     * Except for 'waitForSync', 'journalSize' and 'name', a collection can not be modified after creation.
+     * Except for 'waitForSync' and 'name', a collection can not be modified after creation.
      * For change 'name', the method 'rename' must be used.
      *
      * @return bool
@@ -596,7 +592,7 @@ public function load(bool $count = true): bool
     }
 
     /**
-     * Find a document by it's key
+     * Find a document by its key
      *
      * @param string $key Document key
      * @param bool $isVertex If the collection is a vertex in a graph, passing true will return document as Vertex object.
@@ -729,7 +725,6 @@ protected function getUpdateParameters(): array
     {
         return [
             'waitForSync' => $this->attributes['waitForSync'],
-            'journalSize' => $this->attributes['journalSize']
         ];
     }
 
@@ -740,7 +735,7 @@ protected function getUpdateParameters(): array
      *
      * @throws GuzzleException
      */
-    private function update()
+    private function update(): bool
     {
         $uri = Api::buildDatabaseUri($this->connection->getBaseUri(), $this->getDatabase()->getDatabaseName(), Api::COLLECTION);
         $response = $this->connection->put(sprintf("%s/%s%s", $uri, $this->getName(), Api::COLLECTION_PROPERTIES), $this->getUpdateParameters());

src/Validation/Collection/CollectionValidator.php

@@ -41,18 +41,14 @@ public function rules(): array
     {
         return [
             'name' => Rules::string(),
-            'journalSize' => Rules::integer(),
             'replicationFactor' => Rules::equalsOrGreaterThan(1),
             'waitForSync' => Rules::boolean(),
-            'doCompact' => Rules::boolean(),
             'shardingStrategy' => Rules::in(['community-compat', 'enterprise-compat', 'enterprise-smart-edge-compat', 'hash', 'enterprise-hash-smart-edge']),
-            'isVolatile' => Rules::boolean(),
             'shardKeys' => Rules::arr(),
             'numberOfShards' => Rules::equalsOrGreaterThan(1),
             'isSystem' => Rules::boolean(),
             'type' => Rules::in([2, 3]),
             'keyOptions' => Rules::arr(),
-            'indexBuckets' => Rules::in([2, 4, 8, 16, 32, 64, 128, 256, 512, 1024])
         ];
     }
 }

tests/Collection/CollectionTest.php

@@ -55,7 +55,6 @@ public function testGetter()
         $this->assertEquals('any', $collection->name);
 
         $this->assertFalse($collection->waitForSync);
-        $this->assertTrue($collection->doCompact);
         $this->assertNull($collection->id);
 
         $this->assertNull($collection->randomProperty);
@@ -66,12 +65,10 @@ public function testSetter()
         $collection = new Collection('any', $this->getConnectionObject()->getDatabase());
         $this->assertEquals('any', $collection->name);
         $collection->waitForSync = true;
-        $collection->doCompact = false;
         $collection->name = 'newAny';
 
         $this->assertNull($collection->id);
         $this->assertTrue($collection->waitForSync);
-        $this->assertFalse($collection->doCompact);
         $this->assertEquals('newAny', $collection->name);
 
         $this->assertNull($collection->randomProperty);

tests/Validation/Collection/CollectionValidatorTest.php

@@ -14,12 +14,9 @@ protected function mockCollectionArray(): array
         $buckets = [2, 4, 8, 16, 32, 64, 128, 256, 512, 1024];
         return [
             'name' => random_bytes(10),
-            'journalSize' => rand(1048576, 2097152),
             'replicationFactor' => rand(1, 10),
             'waitForSync' => (bool)rand(0, 1),
-            'doCompact' => (bool)rand(0, 1),
             'shardingStrategy' => 'community-compat',
-            'isVolatile' => (bool)rand(0, 1),
             'shardKeys' => ["_key"],
             'numberOfShards' => rand(1, 10),
             'isSystem' => (bool)rand(0, 1),
@@ -29,7 +26,6 @@ protected function mockCollectionArray(): array
                 'type' => 'traditional',
                 'lastValue' => 0
             ],
-            'indexBuckets' => $buckets[rand(0, 9)]
         ];
     }