Skip to content

Commit e651f37

Browse files
author
Piotr
committed
small improvements
1 parent e69c4fa commit e651f37

File tree

2 files changed

+25
-17
lines changed

2 files changed

+25
-17
lines changed

src/app.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,7 @@
228228
}
229229

230230
.column-name {
231+
z-index: 100;
231232
span {
232233
pointer-events: none;
233234
user-select: none;

src/stores/contextMenu.ts

Lines changed: 24 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -45,23 +45,30 @@ export const useContextMenuStore = defineStore("context_menu", () => {
4545
}
4646
})
4747
}
48-
actions.value?.push({
49-
label: "Search by value",
50-
fn: () => {
51-
let v = type.value
52-
switch (typeof v) {
53-
case "string":
54-
v = `"${v}"`
55-
break
56-
case "number":
57-
case "boolean":
58-
v = `${v}`
59-
break
60-
}
61-
globalEventBus.emit('searchbar-update', `data.${column.name} == ${v}`)
62-
hide()
63-
}
64-
})
48+
/**
49+
* The feature of filtering by value is currently disabled due to the fact that
50+
* we're unable to effectively trace the source field only by using name.
51+
* It requires a bigger change in functionality where we select a field to display in the column
52+
* by allowing to provide it as a string path ie. `field.foo.bar` would correspond to {field:{foo:{bar:"baz"}}}
53+
* In addition it should be taken into account when the object is flatten to {"field.foo.bar": "baz"}
54+
*/
55+
// actions.value?.push({
56+
// label: "Search by value",
57+
// fn: () => {
58+
// let v = type.value
59+
// switch (typeof v) {
60+
// case "string":
61+
// v = `"${v}"`
62+
// break
63+
// case "number":
64+
// case "boolean":
65+
// v = `${v}`
66+
// break
67+
// }
68+
// globalEventBus.emit('searchbar-update', `data.${column.name} == ${v}`)
69+
// hide()
70+
// }
71+
// })
6572
actions.value?.push({
6673
label: "Copy value",
6774
fn: () => {

0 commit comments

Comments
 (0)