fix escaping

Author: ckrause

CHANGELOG.md

@@ -2,11 +2,14 @@ To install or update LODA, please follow the [installation instructions](https:/
 
 ## [Unreleased]
 
+# v22.7.22
+
 ### Bugfixes
 
 * Interrupt long-running evaluations if time limit is reached
 * Fix handling of protected programs
 * Fix progress monitor for native mining (non-BOINC)
+* Fix escaping in Slack messages and metric labels
 
 ### Enhancements
 

src/metrics.cpp

@@ -43,7 +43,7 @@ void Metrics::write(const std::vector<Entry> entries) const {
     out << entry.field;
     for (auto &l : entry.labels) {
       auto v = l.second;
-      std::replace(v.begin(), v.end(), ' ', '_');
+      replaceAll(v, " ", "\\ ");
       out << "," << l.first << "=" << v;
     }
     out << " value=" << entry.value << "\n";

src/util.cpp

@@ -106,8 +106,9 @@ void Log::alert(const std::string &msg, AlertDetails details) {
 void Log::slack(const std::string &msg, AlertDetails details) {
   std::string cmd;
   if (!details.text.empty()) {
-    std::replace(details.text.begin(), details.text.end(), '"', ' ');
-    std::replace(details.title.begin(), details.title.end(), '"', ' ');
+    replaceAll(details.text, "\\", "\\\\");  // first escape backslashes
+    replaceAll(details.text, "\"", "\\\"");  // then the rest
+    replaceAll(details.title, "\"", "\\\"");
     size_t index = 0;
     while (true) {
       index = details.text.find("$", index);