fix empty programs dir error (#363)

Author: ckrause

CHANGELOG.md

@@ -2,6 +2,10 @@ To install or update LODA, please follow the [installation instructions](https:/
 
 ## [Unreleased]
 
+### Bugfixes
+
+* Fix empty programs directory error in BOINC
+
 ## v24.12.27
 
 ### Enhancements

src/sys/setup.cpp

@@ -150,6 +150,16 @@ void Setup::setProgramsHome(const std::string& home) {
   checkDir(PROGRAMS_HOME);
 }
 
+bool Setup::existsProgramsHome() {
+  // We cannot use getProgramsHome() here because it checks for existence
+  return isDir(getLodaHome() + "programs");
+}
+
+void Setup::cloneProgramsHome(const std::string& git_url) {
+  // We cannot use getProgramsHome() here because it checks for existence
+  Git::clone(git_url, getLodaHome() + "programs");
+}
+
 void Setup::checkDir(const std::string& home) {
   if (!isDir(home)) {
     Log::get().error(
@@ -424,14 +434,6 @@ bool Setup::checkEnvVars() {
   return true;
 }
 
-bool Setup::existsProgramsHome() {
-  return isDir(LODA_HOME + "programs" + FILE_SEP + ".git");
-}
-
-void Setup::cloneProgramsHome(std::string git_url) {
-  Git::clone(git_url, getLodaHome() + "programs");
-}
-
 bool Setup::checkProgramsHome() {
   std::string line;
   if (!existsProgramsHome()) {

src/sys/setup.hpp

@@ -36,15 +36,16 @@ class Setup {
 
   static const std::string& getOeisHome();
 
-  static bool existsProgramsHome();
-
-  static void cloneProgramsHome(
-      std::string git_url = "https://github.com/loda-lang/loda-programs.git");
-
   static const std::string& getProgramsHome();
 
   static void setProgramsHome(const std::string& home);
 
+  static bool existsProgramsHome();
+
+  static void cloneProgramsHome(
+      const std::string& git_url =
+          "https://github.com/loda-lang/loda-programs.git");
+
   static std::string getSetupValue(const std::string& key);
 
   static bool getSetupFlag(const std::string& key, bool default_value);