various small fixes

Author: ckrause

CHANGELOG.md

@@ -2,10 +2,16 @@ To install or update LODA, please follow the [installation instructions](https:/
 
 ## [Unreleased]
 
+### Bugfixes
+
+* Fix error message in `check` command
+
 ### Enhancements
 
 * Improve handling of loops with constant number of iterations
 * Improve detection of fake "better" programs
+* Disable incremental evaluation in `check` command for consistency
+* Adjust maximum big int size to handle A000336
 
 # v22.6.19
 

src/commands.cpp

@@ -143,8 +143,9 @@ void Commands::check(const std::string& path) {
   }
   Evaluator evaluator(settings);
   auto terms = seq.getTerms(OeisSequence::FULL_SEQ_LENGTH);
-  auto result =
-      evaluator.check(program, terms, OeisSequence::DEFAULT_SEQ_LENGTH, seq.id);
+  // don't use incremental evaluation in maintenance to detect bugs
+  auto result = evaluator.check(
+      program, terms, OeisSequence::DEFAULT_SEQ_LENGTH, seq.id, false);
   switch (result.first) {
     case status_t::OK:
       std::cout << "ok" << std::endl;

src/main.cpp

@@ -140,7 +140,7 @@ int dispatch(Settings settings, const std::vector<std::string>& args) {
     Log::get().error("Option -s only allowed in evaluate command", true);
   }
   if (settings.print_as_b_file && cmd != "evaluate" && cmd != "eval" &&
-      cmd != "check" && cmd != "maintain") {
+      cmd != "check") {
     Log::get().error("Option -b not allowed for this command", true);
   }
   if (settings.parallel_mining && cmd != "mine") {

src/oeis_sequence.cpp

@@ -23,7 +23,8 @@ bool OeisSequence::isTooBig(const Number& n) {
     return true;
   }
   if (USE_BIG_NUMBER) {
-    return n.getNumUsedWords() > static_cast<int64_t>(BigNumber::NUM_WORDS / 2);
+    return n.getNumUsedWords() >
+           static_cast<int64_t>(BigNumber::NUM_WORDS / 4);  // magic number
   } else {
     static const int64_t NUM_INF = std::numeric_limits<int64_t>::max();
     return (n.value > (NUM_INF / 1000)) || (n.value < (NUM_INF / -1000));

tests/programs/oeis/full_check.txt

@@ -0,0 +1 @@
+A000572: A Beatty sequence: [ n(e+1) ].