Skip to content

Commit 5f3498b

Browse files
balasundaram.jayaramankarthikeyansatrox28
authored andcommitted
Adding tsc issue fixes
1 parent 69b2066 commit 5f3498b

File tree

7 files changed

+13
-10
lines changed

7 files changed

+13
-10
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "@loblaw/backstage-plugin-gitlab",
2+
"name": "@internal/plugin-backstage-plugin-gitlab",
33
"version": "0.1.16",
44
"main": "src/index.ts",
55
"types": "src/index.ts",

src/api/GitlabCIClient.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,13 @@ export class GitlabCIClient implements GitlabCIApi {
141141
}
142142

143143
async getProjectDetails(projectSlug?: string): Promise<Object | undefined> {
144-
let projectDetails: any = await this.callApi<Object>(
145-
'projects/' + encodeURIComponent(projectSlug),
146-
{},
147-
);
144+
let projectDetails: any;
145+
if(projectSlug){
146+
projectDetails = await this.callApi<Object>(
147+
'projects/' + encodeURIComponent(projectSlug),
148+
{},
149+
);
150+
}
148151
return projectDetails;
149152
}
150153

src/components/widgets/ContributorsCard/ContributorsCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const ContributorsCard = ({}) => {
2727
const { value, loading, error } = useAsync(async (): Promise<
2828
ContributorData[]
2929
> => {
30-
const projectDetails = await GitlabCIAPI.getProjectDetails(project_slug);
30+
let projectDetails: any = await GitlabCIAPI.getProjectDetails(project_slug);
3131
let projectId = project_id ? project_id : projectDetails?.id;
3232
const gitlabObj = await GitlabCIAPI.getContributorsSummary(projectId);
3333
const data = gitlabObj?.getContributorsData;

src/components/widgets/LanguagesCard/LanguagesCard.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ export const LanguagesCard = ({}) => {
5252
const { project_slug } = gitlabAppSlug();
5353

5454
const { value, loading, error } = useAsync(async (): Promise<Language> => {
55-
const projectDetails = await GitlabCIAPI.getProjectDetails(project_slug);
55+
let projectDetails: any = await GitlabCIAPI.getProjectDetails(project_slug);
5656
let projectId = project_id ? project_id : projectDetails?.id;
5757
const gitlabObj = await GitlabCIAPI.getLanguagesSummary(projectId);
5858
const data = gitlabObj?.getLanguagesData;

src/components/widgets/MergeRequestStats/MergeRequestStats.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ const MergeRequestStats = (props: Props) => {
6666
mergedCount: 0,
6767
};
6868
const { value, loading, error } = useAsync(async (): Promise<MergeStats> => {
69-
const projectDetails = await GitlabCIAPI.getProjectDetails(project_slug);
69+
let projectDetails: any = await GitlabCIAPI.getProjectDetails(project_slug);
7070
let projectId = project_id ? project_id : projectDetails?.id;
7171
const gitlabObj = await GitlabCIAPI.getMergeRequestsStatusSummary(
7272
projectId,

src/components/widgets/MergeRequestsTable/MergeRequestsTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export const MergeRequestsTable = ({}) => {
5050
const { value, loading, error } = useAsync(async (): Promise<
5151
MergeRequest[]
5252
> => {
53-
const projectDetails = await GitlabCIAPI.getProjectDetails(project_slug);
53+
let projectDetails: any = await GitlabCIAPI.getProjectDetails(project_slug);
5454
let projectId = project_id ? project_id : projectDetails?.id;
5555
const gitlabObj = await GitlabCIAPI.getMergeRequestsSummary(projectId);
5656
const data = gitlabObj?.getMergeRequestsData;

src/components/widgets/PipelinesTable/PipelinesTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const PipelinesTable = ({}) => {
5353
const { value, loading, error } = useAsync(async (): Promise<
5454
PipelineObject[]
5555
> => {
56-
const projectDetails = await GitlabCIAPI.getProjectDetails(project_slug);
56+
let projectDetails: any = await GitlabCIAPI.getProjectDetails(project_slug);
5757
let projectId = project_id ? project_id : projectDetails?.id;
5858
const gitlabObj = await GitlabCIAPI.getPipelineSummary(projectId);
5959
const data = gitlabObj?.getPipelinesData;

0 commit comments

Comments
 (0)