Remove an unused API; NFC

AaronBallman · AaronBallman · commit 89592061a4d5 · 2024-01-19T15:15:24.000-05:00
Not only is this unused, it's really confusing having
getAPValueResult() and getResultAsAPValue() as sibling APIs
diff --git a/clang/include/clang/AST/Expr.h b/clang/include/clang/AST/Expr.h
@@ -1136,7 +1136,6 @@ class ConstantExpr final
     return ConstantExprBits.APValueKind != APValue::None;
   }
   APValue getAPValueResult() const;
-  APValue &getResultAsAPValue() const { return APValueResult(); }
   llvm::APSInt getResultAsAPSInt() const;
   // Iterators
   child_range children() { return child_range(&SubExpr, &SubExpr+1); }

Original file line number	Diff line number	Diff line change
`@@ -1136,7 +1136,6 @@ class ConstantExpr final`
`1136`	`1136`	`return ConstantExprBits.APValueKind != APValue::None;`
`1137`	`1137`	`}`
`1138`	`1138`	`APValue getAPValueResult() const;`
`1139`		`- APValue &getResultAsAPValue() const { return APValueResult(); }`
`1140`	`1139`	`llvm::APSInt getResultAsAPSInt() const;`
`1141`	`1140`	`// Iterators`
`1142`	`1141`	`child_range children() { return child_range(&SubExpr, &SubExpr+1); }`