Skip to content

Commit 040f557

Browse files
authored
fix(logging): make field indexer logs debug level (#108)
- Turning off debug log level by default. - Changing field indexer log messages to only print in debug mode. Approved-by: VaishnaviHire
1 parent 7456639 commit 040f557

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

controllers/llamastackdistribution_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -288,11 +288,11 @@ func (r *LlamaStackDistributionReconciler) createConfigMapFieldIndexer(ctx conte
288288
r.configMapIndexFunc,
289289
); err != nil {
290290
// Log warning but don't fail startup - older Kubernetes versions may not support this
291-
mgr.GetLogger().Info("Field indexer for ConfigMap references not supported, will use manual search fallback",
291+
mgr.GetLogger().V(1).Info("Field indexer for ConfigMap references not supported, will use manual search fallback",
292292
"error", err.Error())
293293
return nil
294294
}
295-
mgr.GetLogger().Info("Successfully created field indexer for ConfigMap references - will use efficient lookups")
295+
mgr.GetLogger().V(1).Info("Successfully created field indexer for ConfigMap references - will use efficient lookups")
296296
return nil
297297
}
298298

@@ -445,7 +445,7 @@ func (r *LlamaStackDistributionReconciler) isConfigMapReferenced(configMap clien
445445
if err != nil {
446446
// Field indexer failed (likely due to older Kubernetes version not supporting custom field labels)
447447
// Fall back to a manual check instead of assuming all ConfigMaps are referenced
448-
logger.Info("Field indexer not supported, falling back to manual ConfigMap reference check", "error", err.Error())
448+
logger.V(1).Info("Field indexer not supported, falling back to manual ConfigMap reference check", "error", err.Error())
449449
return r.manuallyCheckConfigMapReference(configMap)
450450
}
451451

@@ -519,7 +519,7 @@ func (r *LlamaStackDistributionReconciler) tryFieldIndexerLookup(ctx context.Con
519519
attachedLlamaStacks := llamav1alpha1.LlamaStackDistributionList{}
520520
err := r.List(ctx, &attachedLlamaStacks, client.MatchingFields{"spec.server.userConfig.configMapName": indexKey})
521521
if err != nil {
522-
logger.Info("Field indexer not supported, will fall back to a manual search for ConfigMap event processing",
522+
logger.V(1).Info("Field indexer not supported, will fall back to a manual search for ConfigMap event processing",
523523
"indexKey", indexKey, "error", err.Error())
524524
return attachedLlamaStacks, false
525525
}

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func main() {
8989
"Enable leader election for controller manager. "+
9090
"Enabling this will ensure there is only one active controller manager.")
9191
opts := zap.Options{
92-
Development: true,
92+
Development: false,
9393
StacktraceLevel: zapcore.PanicLevel, // Set higher than ErrorLevel to avoid stack traces in logs
9494
}
9595
opts.BindFlags(flag.CommandLine)

0 commit comments

Comments
 (0)