Remove the double plugin activation hook and write a regression test for it.

Previously, wc_custom_order_table_install() — which is called via register_activation_hook() — was then calling register_activation_hook() a second time, preventing the WC_Custom_Order_Table_Install::activate() method from ever firing on plugin activation.

Fixes #5, closes #7.

Author: stevegrunwell

tests/bootstrap.php

@@ -29,3 +29,4 @@ function _manually_load_plugin() {
 
 // Start up the WP testing environment.
 require $_tests_dir . '/includes/bootstrap.php';
+require __DIR__ . '/testcase.php';

tests/test-installation.php

@@ -0,0 +1,28 @@
+<?php
+/**
+ * Tests for the plugin installation.
+ *
+ * @package Woocommerce_Order_Tables
+ * @author  Liquid Web
+ */
+
+class InstallationTest extends TestCase {
+
+	public function setUp() {
+		self::drop_orders_table();
+	}
+
+	public function test_table_is_created_on_plugin_activation() {
+		$this->assertFalse(
+			self::orders_table_exists(),
+			'The wp_woocommerce_orders table should not exist at the beginning of this test.'
+		);
+
+		self::reactivate_plugin();
+
+		$this->assertTrue(
+			self::orders_table_exists(),
+			'Upon activation, the table should be created.'
+		);
+	}
+}

tests/testcase.php

@@ -0,0 +1,45 @@
+<?php
+/**
+ * Base test case for WooCommerce Custom Order Tables.
+ *
+ * @package Woocommerce_Order_Tables
+ * @author  Liquid Web
+ */
+
+class TestCase extends WP_UnitTestCase {
+
+	/**
+	 * Determine if the custom orders table exists.
+	 *
+	 * @global $wpdb
+	 */
+	protected static function orders_table_exists() {
+		global $wpdb;
+
+		return (bool) $wpdb->get_var( $wpdb->prepare(
+			'SELECT COUNT(*) FROM information_schema.tables WHERE table_name = %s LIMIT 1',
+			$wpdb->prefix . 'woocommerce_orders'
+		) );
+	}
+
+	/**
+	 * Drop the wp_woocommerce_orders table.
+	 *
+	 * @global $wpdb
+	 */
+	protected static function drop_orders_table() {
+		global $wpdb;
+
+		$wpdb->query( "DROP TABLE IF EXISTS {$wpdb->prefix}woocommerce_orders" );
+	}
+
+	/**
+	 * Emulate deactivating, then subsequently reactivating the plugin.
+	 */
+	protected static function reactivate_plugin() {
+		$plugin = plugin_basename( dirname( __DIR__ ) . '/wc-custom-order-table.php' );
+
+		do_action( 'deactivate_' . $plugin, false );
+		do_action( 'activate_' . $plugin, false );
+	}
+}

wc-custom-order-table.php

@@ -32,7 +32,7 @@
  */
 function wc_custom_order_table_install() {
 	$installer = new WC_Custom_Order_Table_Install();
-	register_activation_hook( __FILE__, array( $installer, 'activate' ) );
+	$installer->activate();
 }
 
 register_activation_hook( __FILE__, 'wc_custom_order_table_install' );