rename HTTPException to JIRAException

Author: lesstif

README.md

@@ -20,7 +20,7 @@ function getConfig() {
         'CURLOPT_SSL_VERIFYHOST' => false,
         'CURLOPT_SSL_VERIFYPEER' => false,	
         'CURLOPT_VERBOSE' => true,
-        'LOG_FILE' => 'QQjira-rest-client.log',
+        'LOG_FILE' => 'jira-rest-client.log',
         'LOG_LEVEL' => 'DEBUG'
     );
 }
@@ -45,7 +45,7 @@ try {
 	$p = $proj->get('TEST');
 
 	print_r($p);			
-} catch (HTTPException $e) {
+} catch (JIRAException $e) {
 	print("Error Occured! " . $e->getMessage());
 }
 ?>
@@ -64,14 +64,13 @@ try {
 
 	$prjs = $proj->getAllProjects();
 
-	$i = 0;
 	foreach ($prjs as $p) {
 		echo sprintf("Project Key:%s, Id:%s, Name:%s, projectCategory: %s\n",
 			$p->key, $p->id, $p->name, $p->projectCategory['name']
 			);
 
 	}			
-} catch (HTTPException $e) {
+} catch (JIRAException $e) {
 	print("Error Occured! " . $e->getMessage());
 }
 ?>
@@ -91,7 +90,7 @@ try {
 	$issue = $issueService->get('TEST-867');
 
 	print_r($issue->fields);	
-} catch (HTTPException $e) {
+} catch (JIRAException $e) {
 	print("Error Occured! " . $e->getMessage());
 }
 
@@ -109,7 +108,7 @@ use JiraRestApi\Issue\IssueService;
 use JiraRestApi\Issue\IssueField;
 try {
 	$issueField = new IssueField();
-	$issueField->setProjectId("12000")
+	$issueField->setProjectKey("TEST")
 				->setSummary("something's wrong")
 				->setAssigneeName("lesstif")
 				->setPriorityName("Critical")
@@ -124,7 +123,7 @@ try {
 
 	//If success, Returns a link to the created issue.
 	print_r($ret);
-} catch (HTTPException $e) {
+} catch (JIRAException $e) {
 	print("Error Occured! " . $e->getMessage());
 }
 

src/JiraClient.php

@@ -4,7 +4,7 @@
 
 require 'vendor/autoload.php';
 
-class HTTPException extends \Exception { }
+class JIRAException extends \Exception { }
 
 use \Monolog\Logger as Logger;
 use \Monolog\Handler\StreamHandler;
@@ -134,7 +134,7 @@ public function exec($context, $post_data = null, $custom_request = null) {
 			curl_close($ch);
 			// HostNotFound, No route to Host, etc Network error
 			$this->log->addError("CURL Error: = " . $body);
-			throw new HTTPException("CURL Error: = " . $body);
+			throw new JIRAException("CURL Error: = " . $body);
 		} else {
 			// if request was ok, parsing http response code.
 			$this->http_response = curl_getinfo($ch, CURLINFO_HTTP_CODE);
@@ -143,9 +143,9 @@ public function exec($context, $post_data = null, $custom_request = null) {
 
 			// don't check 301, 302 because setting CURLOPT_FOLLOWLOCATION 
 			if ($this->http_response != 200 && $this->http_response != 201) {
-				throw new HTTPException("CURL HTTP Request Failed: Status Code : "
-				 . $this->http_response . " URL:" . $url
-				 . "\nError Message : " . $response);
+				throw new JIRAException("CURL HTTP Request Failed: Status Code : "
+				 . $this->http_response . ", URL:" . $url
+				 . "\nError Message : " . $response, $this->http_response);
 			}			
 		}		
 

src/issue/IssueField.php

@@ -13,8 +13,16 @@ public function __construct() {
         $this->issuetype = new \JiraRestApi\Issue\IssueType();
     }
 
-    public function setProjectName($name) {
-    	$this->project->name = $name;
+    public function getProjectKey() {
+    	return $this->project->key;
+    }
+
+    public function getProjectId() {
+    	return $this->project->id;
+    }
+
+    public function setProjectKey($key) {
+    	$this->project->key = $key;
     	return $this;
     }
     public function setProjectId($id) {

src/issue/IssueService.php

@@ -15,7 +15,7 @@ public function __construct() {
      * @return Issue class
      */
     public function get($issueIdOrKey) {
-    	$ret = $this->exec("$this->uri/$issueIdOrKey", null);
+    	$ret = $this->exec($this->uri . "/$issueIdOrKey", null);
 
         $this->log->addInfo("Result=\n" . $ret );
 
@@ -41,6 +41,7 @@ public function create($issueField) {
             return !is_null($val);
         });
 
+
         $data = json_encode($issue);
 
         $this->log->addInfo("Create Issue=\n" . $data );

tests/IssueTest.php

@@ -32,7 +32,7 @@ public function testCreateIssue()
 		try {
 			$issueField = new IssueField();
 
-			$issueField->setProjectId("12000")
+			$issueField->setProjectKey("TEST")
 						->setSummary("something's wrong")
 						->setAssigneeName("lesstif")
 						->setPriorityName("Critical")
@@ -47,7 +47,7 @@ public function testCreateIssue()
 
 			//If success, Returns a link to the created issue.
 			print_r($ret);
-		} catch (HTTPException $e) {
+		} catch (JIRAException $e) {
 			$this->assertTrue(FALSE, "Create Failed : " . $e->getMessage());
 		}
 	}