Skip to content

Commit 67da50b

Browse files
committed
change to builder pattern.
1 parent c3d82b7 commit 67da50b

File tree

3 files changed

+33
-18
lines changed

3 files changed

+33
-18
lines changed

README.md

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ function getOptions() {
4646
## Get Project Info
4747

4848
````php
49+
use JiraRestApi\Project\ProjectService;
50+
4951
try {
5052
$proj = new ProjectService();
5153

@@ -59,6 +61,8 @@ try {
5961

6062
## Get All Project list
6163
````php
64+
use JiraRestApi\Project\ProjectService;
65+
6266
try {
6367
$proj = new ProjectService();
6468

@@ -79,6 +83,7 @@ try {
7983
## Get Issue Info
8084

8185
````php
86+
use JiraRestApi\Issue\IssueService;
8287
try {
8388
$issueService = new IssueService();
8489

@@ -93,17 +98,18 @@ try {
9398
## Create Issue
9499

95100
````php
101+
use JiraRestApi\Issue\IssueService;
102+
use JiraRestApi\Issue\IssueField;
96103
try {
97104
$issueField = new IssueField();
98-
$issueField->setProjectId("12000");
99-
$issueField->setSummary("something's wrong");
100-
$issueField->setAssigneeName("lesstif");
101-
$issueField->setPriorityName("Critical");
102-
$issueField->setIssueType("Bug");
103-
$issueField->setDescription("Full description for issue");
104-
105-
$issueField->addVersion(null, "1.0.1");
106-
$issueField->addVersion(null, "1.0.3");
105+
$issueField->setProjectId("12000")
106+
->setSummary("something's wrong")
107+
->setAssigneeName("lesstif")
108+
->setPriorityName("Critical")
109+
->setIssueType("Bug")
110+
->setDescription("Full description for issue")
111+
->addVersion(null, "1.0.1")
112+
->addVersion(null, "1.0.3");
107113

108114
$issueService = new IssueService();
109115

src/issue/IssueField.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,44 @@ public function __construct() {
1515

1616
public function setProjectName($name) {
1717
$this->project->name = $name;
18+
return $this;
1819
}
1920
public function setProjectId($id) {
2021
$this->project->id = $id;
22+
return $this;
2123
}
2224

2325
public function setIssueType($name) {
2426
$this->issuetype->name = $name;
27+
return $this;
2528
}
2629

2730
public function setSummary($summary) {
2831
$this->summary = $summary;
32+
return $this;
2933
}
3034

3135
public function setReporterName($name) {
3236
if (is_null($this->reporter))
3337
$this->reporter = new \JiraRestApi\Issue\Reporter();
3438

3539
$this->reporter->name = $name;
40+
return $this;
3641
}
3742

3843
public function setAssigneeName($name) {
3944
$this->assignee->name = $name;
45+
return $this;
4046
}
4147

4248
public function setPriorityName($name) {
4349
$this->priority->name = $name;
50+
return $this;
4451
}
4552

4653
public function setDescription($description) {
4754
$this->description = $description;
55+
return $this;
4856
}
4957

5058
public function addVersion($id, $name) {
@@ -56,6 +64,7 @@ public function addVersion($id, $name) {
5664
$v->name = $name;
5765

5866
array_push($this->versions, $v);
67+
return $this;
5968
}
6069

6170
/** @var string */

tests/IssueTest.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,15 @@ public function testCreateIssue()
3131
//$this->markTestIncomplete();
3232
try {
3333
$issueField = new IssueField();
34-
$issueField->setProjectId("12000");
35-
$issueField->setSummary("something's wrong");
36-
$issueField->setAssigneeName("lesstif");
37-
$issueField->setPriorityName("Critical");
38-
$issueField->setIssueType("Bug");
39-
$issueField->setDescription("Full description for issue");
40-
41-
$issueField->addVersion(null, "1.0.1");
42-
$issueField->addVersion(null, "1.0.3");
34+
35+
$issueField->setProjectId("12000")
36+
->setSummary("something's wrong")
37+
->setAssigneeName("lesstif")
38+
->setPriorityName("Critical")
39+
->setIssueType("Bug")
40+
->setDescription("Full description for issue")
41+
->addVersion(null, "1.0.1")
42+
->addVersion(null, "1.0.3");
4343

4444
$issueService = new IssueService();
4545

0 commit comments

Comments
 (0)