addressing more clang compiler warnings

Author: jananifernandez

framework/modules/saf_sofa_reader/libmysofa/internal/hdf_dataobject.c

@@ -648,7 +648,7 @@ static int readOHDRHeaderMessageGroupInfo(struct READER *reader,
 static int readOHDRHeaderMessageFilterPipelineV1(struct READER *reader,
                                                  uint8_t filters) {
   int i, j;
-  uint16_t filter_identification_value, number_client_data_values, namelength, flags;
+    uint16_t filter_identification_value, number_client_data_values, namelength;//, flags;
 
   if (readValue(reader, 6) != 0) {
     mylog("reserved values not zero\n");
@@ -670,7 +670,7 @@ static int readOHDRHeaderMessageFilterPipelineV1(struct READER *reader,
       // LCOV_EXCL_STOP
     }
     namelength = (uint16_t)readValue(reader, 2);
-    flags = (uint16_t)readValue(reader, 2);
+    //flags = (uint16_t)readValue(reader, 2);
     number_client_data_values = (uint16_t)readValue(reader, 2);
 
     if (namelength > 0)

framework/resources/convhull_3d/convhull_3d.c

@@ -996,7 +996,7 @@ void convhull_nd_build
             reldist[i] += pow(absdist[i*d+j], 2.0);
 
     /* Sort from maximum to minimum relative distance */
-    int num_pleft, cnt;
+    int num_pleft;
     int* ind, *pleft;
     ind = (int*)malloc((nVert-d-1) * sizeof(int));
     pleft = (int*)malloc((nVert-d-1) * sizeof(int));
@@ -1012,10 +1012,6 @@ void convhull_nd_build
      occurs every #iter2del# iterations of this while loop */
     memset(A, 0, (d+1)*(d+1) * sizeof(CH_FLOAT));
 
-    /* cnt is equal to the points having been selected without deletion of
-     nonvisible points (i.e. points inside the current convex hull) */
-    cnt=0;
-
     /* The main loop for the quickhull algorithm */
     CH_FLOAT detA;
     CH_FLOAT* points_cf, *points_s;
@@ -1044,9 +1040,6 @@ void convhull_nd_build
         else
             pleft = (int*)realloc(pleft, num_pleft*sizeof(int));
 
-        /* Update point selection counter */
-        cnt++;
-
         /* find visible faces */
         for(j=0; j<d; j++)
             points_s[j] = points[i*(d+1)+j];

test/src/test__reverb_module.c

@@ -28,7 +28,7 @@ void test__ims_shoebox_RIR(void){
     void* hIms;
     float maxTime_s;
     float mov_src_pos[3], mov_rec_pos[3];
-    int sourceID_1, sourceID_2, sourceID_3, sourceID_4, sourceID_5, receiverID;
+    int sourceID_1, sourceID_3, sourceID_4, receiverID;
     int i;
 
     /* Config */
@@ -53,7 +53,7 @@ void test__ims_shoebox_RIR(void){
     /* Set-up the shoebox room simulator, with two sources and one spherical harmonic receiver */
     ims_shoebox_create(&hIms, (float*)roomdims, (float*)abs_wall, 125.0f, nBands, 343.0f, 48e3f);
     sourceID_1 = ims_shoebox_addSource(hIms, (float*)src_pos, NULL);
-    sourceID_2 = ims_shoebox_addSource(hIms, (float*)src2_pos, NULL);
+    ims_shoebox_addSource(hIms, (float*)src2_pos, NULL);
     receiverID = ims_shoebox_addReceiverSH(hIms, sh_order, (float*)rec_pos, NULL);
 
     /* Moving source No.1 and the receiver */
@@ -76,7 +76,7 @@ void test__ims_shoebox_RIR(void){
      * (Just messing around, trying to trip up an IMS internal assertion) */
     sourceID_3 = ims_shoebox_addSource(hIms, (float*)src3_pos, NULL);
     sourceID_4 = ims_shoebox_addSource(hIms, (float*)src4_pos, NULL);
-    sourceID_5 = ims_shoebox_addSource(hIms, (float*)src5_pos, NULL);
+    ims_shoebox_addSource(hIms, (float*)src5_pos, NULL);
     ims_shoebox_removeSource(hIms, sourceID_3);
     ims_shoebox_removeSource(hIms, sourceID_4);
     sourceID_4 = ims_shoebox_addSource(hIms, (float*)src4_pos, NULL);

test/src/test__sh_module.c

@@ -419,7 +419,7 @@ void test__computeSectorCoeffsEP(void){
 }
 
 void test__checkCondNumberSHTReal(void){
-    int i, j, nDirs, order, nSH;
+    int i, j, nDirs, order;
     float* t_dirs_deg, *cond_N;
     float** t_dirs_rad;
 
@@ -431,7 +431,6 @@ void test__checkCondNumberSHTReal(void){
     /* Loop over orders */
     for(i=0; i<nTestOrders; i++) {
         order = testOrders[i];
-        nSH = ORDER2NSH(order);
 
         /* Pull an appropriate t-design */
         t_dirs_deg = (float*)__HANDLES_Tdesign_dirs_deg[2 * order];

test/src/test__sofa_reader_module.c

@@ -37,6 +37,7 @@ void test__saf_sofa_open(void){
         /* Note that saf_sofa_open() reverts to mysofa_load(), if SAF_ENABLE_NETCDF is not defined */
         error = saf_sofa_open(&sofa, SAF_TEST_SOFA_FILE_PATH, SAF_SOFA_READER_OPTION_DEFAULT);
         saf_sofa_close(&sofa);
+        TEST_ASSERT_TRUE( (error==SAF_SOFA_OK) || (error==SAF_SOFA_ERROR_FORMAT_UNEXPECTED) );
     }
 }
 

test/src/test__utilities_module.c

@@ -521,7 +521,7 @@ void test__smb_pitchShifter(void){
     float* inputData, *outputData;
     void* hPS, *hFFT;
     float frequency;
-    int i, smbLatency, ind;
+    int i, ind;
 
     /* Config */
     const int sampleRate = 48000;
@@ -536,8 +536,7 @@ void test__smb_pitchShifter(void){
     frequency = (float)sampleRate/8.0f;
     for(i=0; i<nSamples; i++) /* sine tone at quarter Nyquist: */
         inputData[i] = sinf(2.0f * SAF_PI * (float)i * frequency/(float)sampleRate);
-    smbLatency = FFTsize - (FFTsize/osfactor);
-
+    
     /* Pitch shift down one octave */
     smb_pitchShift_apply(hPS, 0.5, nSamples, inputData, outputData);
 

test/test.xcodeproj/project.pbxproj

@@ -1336,6 +1336,7 @@
 				OTHER_CFLAGS = (
 					"-Wall",
 					"-Wextra",
+					"-Wno-strict-prototypes",
 				);
 				OTHER_CPLUSPLUSFLAGS = "";
 				OTHER_LDFLAGS = "";
@@ -1372,6 +1373,7 @@
 				OTHER_CFLAGS = (
 					"-Wall",
 					"-Wextra",
+					"-Wno-strict-prototypes",
 				);
 				OTHER_CPLUSPLUSFLAGS = "";
 				OTHER_LDFLAGS = "";