Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

Lab 4 summary #12

@igor-leshkevych

Description

@igor-leshkevych

Hi guys.

I won't discuss your app (it works). What I want to discuss is this:
image

  1. First @Marchuk773 pushes commit where he adds files for Redux and some stuff related to his screens in his personal branch
  2. Then @Markot96 adds SAME redux files (+ some minor stuff related to his screens) in a new commit to his own branch
  3. Then @S7pt adds SAME redux files and SAME copypasted UI code in a new commit to his own branch
  4. Those 3 branches are completely unrelated (you didn't merge them one into another) and created almost at the same time.

This is a next level example of team collaboration

@Marchuk773 has 8/10:

  • local state is nice
  • global state is implemented only partially: there are actions and reducers, but they are not used

@Markot96 has 5/10

  • local state is nice
  • global state is copypasted from @Marchuk773 commit (I don't care who actually coded that, he pushed first, so he gets the score)

@S7pt has 2/10

  • no local state
  • global state is copypasted from @Marchuk773

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions