Skip to content

Commit 63c7192

Browse files
authored
Merge pull request #161 from ericoporto/patch-1
toolchain: fix typos and grammar
2 parents e6a5505 + 3ee895d commit 63c7192

File tree

1 file changed

+21
-21
lines changed

1 file changed

+21
-21
lines changed

ios.toolchain.cmake

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
# ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
3838
# POSSIBILITY OF SUCH DAMAGE.
3939
#
40-
# This file is based off of the Platform/Darwin.cmake and
40+
# This file is based on the Platform/Darwin.cmake and
4141
# Platform/UnixPaths.cmake files which are included with CMake 2.8.4
4242
# It has been altered for iOS development.
4343
#
@@ -80,15 +80,15 @@
8080
# can also be manually specified (although this should not be required).
8181
#
8282
# CMAKE_DEVELOPER_ROOT: Path to the Developer directory for the platform
83-
# being compiled for. By default this is automatically determined from
83+
# being compiled for. By default, this is automatically determined from
8484
# CMAKE_OSX_SYSROOT, but can also be manually specified (although this should
8585
# not be required).
8686
#
8787
# DEPLOYMENT_TARGET: Minimum SDK version to target. Default 2.0 on watchOS and 9.0 on tvOS+iOS
8888
#
8989
# NAMED_LANGUAGE_SUPPORT:
9090
# ON (default) = Will require "enable_language(OBJC) and/or enable_language(OBJCXX)" for full OBJC|OBJCXX support
91-
# OFF = Will embed the OBJC and OBJCXX flags into the CMAKE_C_FLAGS and CMAKE_CXX_FLAGS (legacy behaviour, CMake version < 3.16)
91+
# OFF = Will embed the OBJC and OBJCXX flags into the CMAKE_C_FLAGS and CMAKE_CXX_FLAGS (legacy behavior, CMake version < 3.16)
9292
#
9393
# ENABLE_BITCODE: (ON|OFF) Enables or disables bitcode support. Default ON
9494
#
@@ -126,7 +126,7 @@
126126
# XCODE_VERSION: Version number (not including Build version) of Xcode detected.
127127
# SDK_VERSION: Version of SDK being used.
128128
# OSX_ARCHITECTURES: Architectures being compiled for (generated from PLATFORM).
129-
# APPLE_TARGET_TRIPLE: Used by autoconf build systems. NOTE: If "ARCHS" are overridden, this will *NOT* be set!
129+
# APPLE_TARGET_TRIPLE: Used by autoconf build systems. NOTE: If "ARCHS" is overridden, this will *NOT* be set!
130130
#
131131
# This toolchain defines the following macros for use externally:
132132
#
@@ -167,9 +167,9 @@ endif()
167167

168168
# Get the Xcode version being used.
169169
# Problem: CMake runs toolchain files multiple times, but can't read cache variables on some runs.
170-
# Workaround: On first run (in which cache variables are always accessible), set an intermediary environment variable.
170+
# Workaround: On the first run (in which cache variables are always accessible), set an intermediary environment variable.
171171
#
172-
# NOTE: This pattern is used i many places in this toolchain to speed up checks of all sorts
172+
# NOTE: This pattern is used in many places in this toolchain to speed up checks of all sorts
173173
if(DEFINED XCODE_VERSION_INT)
174174
# Environment variables are always preserved.
175175
set(ENV{_XCODE_VERSION_INT} "${XCODE_VERSION_INT}")
@@ -207,7 +207,7 @@ elseif(NOT DEFINED PLATFORM)
207207
endif ()
208208

209209
if(PLATFORM MATCHES ".*COMBINED" AND NOT CMAKE_GENERATOR MATCHES "Xcode")
210-
message(FATAL_ERROR "The combined builds support requires Xcode to be used as generator via '-G Xcode' command-line argument in CMake")
210+
message(FATAL_ERROR "The combined builds support requires Xcode to be used as a generator via '-G Xcode' command-line argument in CMake")
211211
endif()
212212

213213
# Safeguard that the platform value is set and is one of the supported values
@@ -223,7 +223,7 @@ if(PLATFORM MATCHES "^(MAC_ARM64)$|^(MAC_CATALYST_ARM64)$" AND ${CMAKE_VERSION}
223223
message(FATAL_ERROR "Apple Silicon builds requires a minimum of CMake 3.19.5")
224224
endif()
225225

226-
# Touch toolchain variable to suppress "unused variable" warning.
226+
# Touch the toolchain variable to suppress the "unused variable" warning.
227227
# This happens if CMake is invoked with the same command line the second time.
228228
if(CMAKE_TOOLCHAIN_FILE)
229229
endif()
@@ -240,29 +240,29 @@ if(NOT DEFINED NAMED_LANGUAGE_SUPPORT AND ${CMAKE_VERSION} VERSION_GREATER_EQUAL
240240
message(STATUS "[DEFAULTS] Using explicit named language support! E.g., enable_language(CXX) is needed in the project files.")
241241
elseif(NOT DEFINED NAMED_LANGUAGE_SUPPORT AND ${CMAKE_VERSION} VERSION_LESS "3.16")
242242
set(NAMED_LANGUAGE_SUPPORT OFF)
243-
message(STATUS "[DEFAULTS] Disabling explicit named language support. Falling back to legacy behaviour.")
243+
message(STATUS "[DEFAULTS] Disabling explicit named language support. Falling back to legacy behavior.")
244244
elseif(DEFINED NAMED_LANGUAGE_SUPPORT AND ${CMAKE_VERSION} VERSION_LESS "3.16")
245245
message(FATAL_ERROR "CMake named language support for OBJC and OBJCXX was added in CMake 3.16.")
246246
endif()
247247
set(NAMED_LANGUAGE_SUPPORT_INT ${NAMED_LANGUAGE_SUPPORT} CACHE BOOL
248248
"Whether or not to enable explicit named language support" FORCE)
249249

250-
# Specify minimum version of deployment target.
250+
# Specify the minimum version of the deployment target.
251251
if(NOT DEFINED DEPLOYMENT_TARGET)
252252
if (PLATFORM MATCHES "WATCHOS")
253253
# Unless specified, SDK version 4.0 is used by default as minimum target version (watchOS).
254254
set(DEPLOYMENT_TARGET "4.0")
255255
elseif(PLATFORM STREQUAL "MAC")
256-
# Unless specified, SDK version 10.13 (High sierra) is used by default as minimum target version (macos).
256+
# Unless specified, SDK version 10.13 (High Sierra) is used by default as the minimum target version (macos).
257257
set(DEPLOYMENT_TARGET "10.13")
258258
elseif(PLATFORM STREQUAL "MAC_ARM64")
259-
# Unless specified, SDK version 11.0 (Big Sur) is used by default as minimum target version (macos on arm).
259+
# Unless specified, SDK version 11.0 (Big Sur) is used by default as the minimum target version (macOS on arm).
260260
set(DEPLOYMENT_TARGET "11.0")
261261
elseif(PLATFORM STREQUAL "MAC_CATALYST" OR PLATFORM STREQUAL "MAC_CATALYST_ARM64")
262-
# Unless specified, SDK version 13.0 is used by default as minimum target version (mac catalyst minimum requirement).
262+
# Unless specified, SDK version 13.0 is used by default as the minimum target version (mac catalyst minimum requirement).
263263
set(DEPLOYMENT_TARGET "13.1")
264264
else()
265-
# Unless specified, SDK version 11.0 is used by default as minimum target version (iOS, tvOS).
265+
# Unless specified, SDK version 11.0 is used by default as the minimum target version (iOS, tvOS).
266266
set(DEPLOYMENT_TARGET "11.0")
267267
endif()
268268
message(STATUS "[DEFAULTS] Using the default min-version since DEPLOYMENT_TARGET not provided!")
@@ -302,7 +302,7 @@ elseif(PLATFORM_INT STREQUAL "OS64")
302302
set(SDK_NAME iphoneos)
303303
if(NOT ARCHS)
304304
if (XCODE_VERSION_INT VERSION_GREATER 10.0)
305-
set(ARCHS arm64) # FIXME: Add arm64e when Apple have fixed the integration issues with it, libarclite_iphoneos.a is currently missung bitcode markers for example
305+
set(ARCHS arm64) # FIXME: Add arm64e when Apple has fixed the integration issues with it, libarclite_iphoneos.a is currently missing bitcode markers for example
306306
else()
307307
set(ARCHS arm64)
308308
endif()
@@ -315,7 +315,7 @@ elseif(PLATFORM_INT STREQUAL "OS64COMBINED")
315315
if(MODERN_CMAKE)
316316
if(NOT ARCHS)
317317
if (XCODE_VERSION_INT VERSION_GREATER 10.0)
318-
set(ARCHS arm64 x86_64) # FIXME: Add arm64e when Apple have fixed the integration issues with it, libarclite_iphoneos.a is currently missung bitcode markers for example
318+
set(ARCHS arm64 x86_64) # FIXME: Add arm64e when Apple has fixed the integration issues with it, libarclite_iphoneos.a is currently missing bitcode markers for example
319319
set(CMAKE_XCODE_ATTRIBUTE_ARCHS[sdk=iphoneos*] "arm64")
320320
set(CMAKE_XCODE_ATTRIBUTE_ARCHS[sdk=iphonesimulator*] "x86_64")
321321
set(CMAKE_XCODE_ATTRIBUTE_VALID_ARCHS[sdk=iphoneos*] "arm64")
@@ -487,7 +487,7 @@ elseif(CMAKE_GENERATOR MATCHES "Xcode")
487487
endif()
488488
endif()
489489

490-
# If user did not specify the SDK root to use, then query xcodebuild for it.
490+
# If the user did not specify the SDK root to use, then query xcodebuild for it.
491491
if(DEFINED CMAKE_OSX_SYSROOT_INT)
492492
# Environment variables are always preserved.
493493
set(ENV{_CMAKE_OSX_SYSROOT_INT} "${CMAKE_OSX_SYSROOT_INT}")
@@ -631,7 +631,7 @@ foreach(lang ${languages})
631631
set(CMAKE_${lang}_CREATE_STATIC_LIBRARY "${BUILD_LIBTOOL} -static -o <TARGET> <LINK_FLAGS> <OBJECTS> " CACHE INTERNAL "")
632632
endforeach()
633633

634-
# CMake 3.14+ support building for iOS, watchOS and tvOS out of the box.
634+
# CMake 3.14+ support building for iOS, watchOS, and tvOS out of the box.
635635
if(MODERN_CMAKE)
636636
if(SDK_NAME MATCHES "iphone")
637637
set(CMAKE_SYSTEM_NAME iOS)
@@ -651,7 +651,7 @@ elseif(NOT DEFINED CMAKE_SYSTEM_NAME AND ${CMAKE_VERSION} VERSION_GREATER_EQUAL
651651
# Legacy code path prior to CMake 3.14 or fallback if no CMAKE_SYSTEM_NAME specified
652652
set(CMAKE_SYSTEM_NAME iOS)
653653
elseif(NOT DEFINED CMAKE_SYSTEM_NAME)
654-
# Legacy code path prior to CMake 3.14 or fallback if no CMAKE_SYSTEM_NAME specified
654+
# Legacy code path before CMake 3.14 or fallback if no CMAKE_SYSTEM_NAME specified
655655
set(CMAKE_SYSTEM_NAME Darwin)
656656
endif()
657657
# Standard settings.
@@ -800,9 +800,9 @@ if(DEFINED APPLE_TARGET_TRIPLE)
800800
set(APPLE_TARGET_TRIPLE_FLAG "-target ${APPLE_TARGET_TRIPLE}")
801801
endif()
802802

803-
#Check if Xcode generator is used, since that will handle these flags automagically
803+
#Check if Xcode generator is used since that will handle these flags automagically
804804
if(CMAKE_GENERATOR MATCHES "Xcode")
805-
message(STATUS "Not setting any manual command-line buildflags, since Xcode is selected as generator. Modifying the Xcode build-settings directly instead.")
805+
message(STATUS "Not setting any manual command-line buildflags, since Xcode is selected as the generator. Modifying the Xcode build-settings directly instead.")
806806
else()
807807
set(CMAKE_C_FLAGS "${C_TARGET_FLAGS} ${APPLE_TARGET_TRIPLE_FLAG} ${SDK_NAME_VERSION_FLAGS} ${OBJC_LEGACY_VARS} ${BITCODE} ${VISIBILITY} ${CMAKE_C_FLAGS}")
808808
set(CMAKE_C_FLAGS_DEBUG "-O0 -g ${CMAKE_C_FLAGS_DEBUG}")

0 commit comments

Comments
 (0)