fix: [REL-8490] remove ConflictsWith for unbounded and rules, included, excluded (#324)

remove the ConflictsWith for unbounded

Author: sloloris

launchdarkly/resource_launchdarkly_segment_test.go

@@ -99,6 +99,7 @@ resource "launchdarkly_segment" "test" {
 	tags        = ["segmentTag1", "segmentTag2"]
 	included    = ["user1", "user2"]
 	excluded    = ["user3", "user4"]
+	unbounded = false
 	rules {
 		clauses {
 			attribute = "test_att"
@@ -432,6 +433,7 @@ func TestAccSegment_WithRules(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, ENV_KEY, "test"),
 					resource.TestCheckResourceAttr(resourceName, NAME, "segment name"),
 					resource.TestCheckResourceAttr(resourceName, DESCRIPTION, "segment description"),
+					resource.TestCheckResourceAttr(resourceName, UNBOUNDED, "false"),
 					resource.TestCheckResourceAttr(resourceName, "rules.#", "2"),
 					resource.TestCheckResourceAttr(resourceName, "rules.0.clauses.#", "1"),
 					resource.TestCheckResourceAttr(resourceName, "rules.0.clauses.0.attribute", "test_att"),
@@ -475,6 +477,7 @@ func TestAccSegment_WithRules(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, ENV_KEY, "test"),
 					resource.TestCheckResourceAttr(resourceName, NAME, "segment name"),
 					resource.TestCheckResourceAttr(resourceName, DESCRIPTION, "segment description"),
+					resource.TestCheckResourceAttr(resourceName, UNBOUNDED, "false"),
 					resource.TestCheckResourceAttr(resourceName, "tags.#", "2"),
 					resource.TestCheckResourceAttr(resourceName, "tags.0", "segmentTag1"),
 					resource.TestCheckResourceAttr(resourceName, "tags.1", "segmentTag2"),

launchdarkly/segments_helper.go

@@ -25,36 +25,32 @@ func baseSegmentSchema(options segmentSchemaOptions) map[string]*schema.Schema {
 		},
 		TAGS: tagsSchema(tagsSchemaOptions(options)),
 		INCLUDED: {
-			Type:          schema.TypeList,
-			Elem:          &schema.Schema{Type: schema.TypeString},
-			Optional:      !options.isDataSource,
-			Computed:      options.isDataSource,
-			Description:   "List of user keys included in the segment. To target on other context kinds, use the included_contexts block attribute. This attribute is not valid when `unbounded` is set to `true`.",
-			ConflictsWith: []string{UNBOUNDED},
+			Type:        schema.TypeList,
+			Elem:        &schema.Schema{Type: schema.TypeString},
+			Optional:    !options.isDataSource,
+			Computed:    options.isDataSource,
+			Description: "List of user keys included in the segment. To target on other context kinds, use the included_contexts block attribute. This attribute is not valid when `unbounded` is set to `true`.",
 		},
 		EXCLUDED: {
-			Type:          schema.TypeList,
-			Elem:          &schema.Schema{Type: schema.TypeString},
-			Optional:      !options.isDataSource,
-			Computed:      options.isDataSource,
-			Description:   "List of user keys excluded from the segment. To target on other context kinds, use the excluded_contexts block attribute. This attribute is not valid when `unbounded` is set to `true`.",
-			ConflictsWith: []string{UNBOUNDED},
+			Type:        schema.TypeList,
+			Elem:        &schema.Schema{Type: schema.TypeString},
+			Optional:    !options.isDataSource,
+			Computed:    options.isDataSource,
+			Description: "List of user keys excluded from the segment. To target on other context kinds, use the excluded_contexts block attribute. This attribute is not valid when `unbounded` is set to `true`.",
 		},
 		INCLUDED_CONTEXTS: {
-			Type:          schema.TypeList,
-			Elem:          &schema.Resource{Schema: segmentTargetsSchema()},
-			Optional:      !options.isDataSource,
-			Computed:      options.isDataSource,
-			Description:   "List of non-user target objects included in the segment. This attribute is not valid when `unbounded` is set to `true`.",
-			ConflictsWith: []string{UNBOUNDED},
+			Type:        schema.TypeList,
+			Elem:        &schema.Resource{Schema: segmentTargetsSchema()},
+			Optional:    !options.isDataSource,
+			Computed:    options.isDataSource,
+			Description: "List of non-user target objects included in the segment. This attribute is not valid when `unbounded` is set to `true`.",
 		},
 		EXCLUDED_CONTEXTS: {
-			Type:          schema.TypeList,
-			Elem:          &schema.Resource{Schema: segmentTargetsSchema()},
-			Optional:      !options.isDataSource,
-			Computed:      options.isDataSource,
-			Description:   "List of non-user target objects excluded from the segment. This attribute is not valid when `unbounded` is set to `true`.",
-			ConflictsWith: []string{UNBOUNDED},
+			Type:        schema.TypeList,
+			Elem:        &schema.Resource{Schema: segmentTargetsSchema()},
+			Optional:    !options.isDataSource,
+			Computed:    options.isDataSource,
+			Description: "List of non-user target objects excluded from the segment. This attribute is not valid when `unbounded` is set to `true`.",
 		},
 		CREATION_DATE: {
 			Type:        schema.TypeInt,
@@ -63,14 +59,13 @@ func baseSegmentSchema(options segmentSchemaOptions) map[string]*schema.Schema {
 		},
 		RULES: segmentRulesSchema(segmentRulesSchemaOptions(options)),
 		UNBOUNDED: {
-			Type:          schema.TypeBool,
-			Required:      false,
-			Optional:      !options.isDataSource,
-			Computed:      options.isDataSource,
-			Default:       false,
-			Description:   addForceNewDescription("Whether to create a standard segment (`false`) or a Big Segment (`true`). Standard segments include rule-based and smaller list-based segments. Big Segments include larger list-based segments and synced segments. Only use a Big Segment if you need to add more than 15,000 individual targets. It is not possible to manage the list of targeted contexts for Big Segments with Terraform.", !options.isDataSource),
-			ForceNew:      !options.isDataSource,
-			ConflictsWith: []string{INCLUDED, EXCLUDED, INCLUDED_CONTEXTS, EXCLUDED_CONTEXTS, RULES},
+			Type:        schema.TypeBool,
+			Required:    false,
+			Optional:    !options.isDataSource,
+			Computed:    options.isDataSource,
+			Default:     false,
+			Description: addForceNewDescription("Whether to create a standard segment (`false`) or a Big Segment (`true`). Standard segments include rule-based and smaller list-based segments. Big Segments include larger list-based segments and synced segments. Only use a Big Segment if you need to add more than 15,000 individual targets. It is not possible to manage the list of targeted contexts for Big Segments with Terraform.", !options.isDataSource),
+			ForceNew:    !options.isDataSource,
 		},
 		UNBOUNDED_CONTEXT_KIND: {
 			Type:          schema.TypeString,