update unit tests to use node-server-sdk 6.0 persistent data store test suite (#11)

* update unit tests to use node-server-sdk 6.0 persistent data store test suite

* lint

Author: eli-darkly

.eslintrc.js

@@ -3,6 +3,9 @@ module.exports = {
         "node": true,
         "es6": true
     },
+    "parserOptions": {
+        "ecmaVersion": 2017,
+    },
     "extends": "eslint:recommended",
     "rules": {
         "indent": [

tests/.eslintrc.js

@@ -2,25 +2,7 @@ module.exports = {
     "env": {
         "node": true,
         "es6": true,
+        "jasmine": true,
         "jest": true
     },
-    "extends": "eslint:recommended",
-    "rules": {
-        "indent": [
-            "error",
-            2
-        ],
-        "linebreak-style": [
-            "error",
-            "unix"
-        ],
-        "quotes": [
-            "error",
-            "single"
-        ],
-        "semi": [
-            "error",
-            "always"
-        ]
-    }
 };

tests/consul_feature_store-test.js

@@ -1,53 +1,38 @@
-var ConsulFeatureStore = require('../consul_feature_store');
-var testBase = require('launchdarkly-node-server-sdk/test/feature_store_test_base');
-var consul = require('consul');
-
-function stubLogger() {
-  return {
-    debug: jest.fn(),
-    info: jest.fn(),
-    warn: jest.fn(),
-    error: jest.fn()
-  };
-}
-
-describe('ConsulFeatureStore', function() {
+const ConsulFeatureStore = require('../consul_feature_store');
+const {
+  runPersistentFeatureStoreTests,
+} = require('launchdarkly-node-server-sdk/sharedtest/store_tests');
+const consul = require('consul');
 
-  var client = consul();
+// Runs the standard test suites provided by the SDK's store_tests module.
 
-  function clearTable(done) {
-    client.kv.del({ key: 'launchdarkly', recurse: true }, function() {
-      done();
-    });
-  }
+function actualPrefix(prefix) {
+  return prefix || 'launchdarkly';
+}
 
-  const sdkConfig = { logger: stubLogger() };
+function clearAllData(client) {
+  return async (prefix) => {
+    await client.kv.del({ key: actualPrefix(prefix), recurse: true });
+  };
+}
 
-  function makeStore() {
-    return ConsulFeatureStore()(sdkConfig);
-  }
+describe('ConsulFeatureStore', function() {
 
-  function makeStoreWithoutCache() {
-    return ConsulFeatureStore({ cacheTTL: 0 })(sdkConfig);
-  }
+  const client = consul({ promisify: true });
 
-  function makeStoreWithPrefix(prefix) {
-    return ConsulFeatureStore({ prefix: prefix, cacheTTL: 0 })(sdkConfig);
+  function createStore(prefix, cacheTTL, logger) {
+    return ConsulFeatureStore({ prefix, cacheTTL })({ logger });
   }
 
-  function makeStoreWithHook(hook) {
-    var store = makeStore();
+  function createStoreWithConcurrentUpdateHook(prefix, logger, hook) {
+    const store = createStore(prefix, 0, logger);
     store.underlyingStore.testUpdateHook = hook;
     return store;
   }
 
-  describe('cached', function() {
-    testBase.baseFeatureStoreTests(makeStore, clearTable, true);
-  });
-
-  describe('uncached', function() {
-    testBase.baseFeatureStoreTests(makeStoreWithoutCache, clearTable, false, makeStoreWithPrefix);
-  });
-
-  testBase.concurrentModificationTests(makeStore, makeStoreWithHook);
+  runPersistentFeatureStoreTests(
+    createStore,
+    clearAllData(client),
+    createStoreWithConcurrentUpdateHook,
+  );
 });