chore: fixing lint issues

Author: joker23

packages/shared/sdk-client/package.json

@@ -37,7 +37,7 @@
     "build": "npx tsc --noEmit && rollup -c rollup.config.js && npm run make-package-jsons",
     "clean": "rimraf dist",
     "lint": "npx eslint . --ext .ts",
-    "lint:fix": "yarn run lint -- --fix",
+    "lint:fix": "npx eslint . --ext .ts --fix",
     "prettier": "prettier --write 'src/*.@(js|ts|tsx|json)'",
     "check": "yarn && yarn prettier && yarn lint && tsc && yarn test"
   },

packages/shared/sdk-client/src/LDClientImpl.ts

@@ -32,6 +32,10 @@ import { LDIdentifyOptions } from './api/LDIdentifyOptions';
 import { createAsyncTaskQueue } from './async/AsyncTaskQueue';
 import { Configuration, ConfigurationImpl, LDClientInternalOptions } from './configuration';
 import { addAutoEnv } from './context/addAutoEnv';
+import {
+  ActiveContextTracker,
+  createActiveContextTracker,
+} from './context/createActiveContextTracker';
 import { ensureKey } from './context/ensureKey';
 import { DataManager, DataManagerFactory } from './DataManager';
 import createDiagnosticsManager from './diagnostics/createDiagnosticsManager';
@@ -43,13 +47,12 @@ import createEventProcessor from './events/createEventProcessor';
 import EventFactory from './events/EventFactory';
 import DefaultFlagManager, { FlagManager } from './flag-manager/FlagManager';
 import { FlagChangeType } from './flag-manager/FlagUpdater';
+import { ItemDescriptor } from './flag-manager/ItemDescriptor';
 import HookRunner from './HookRunner';
 import { getInspectorHook } from './inspection/getInspectorHook';
 import InspectorManager from './inspection/InspectorManager';
 import LDEmitter, { EventName } from './LDEmitter';
 import { createPluginEnvironmentMetadata } from './plugins/createPluginEnvironmentMetadata';
-import { ActiveContextTracker, createActiveContextTracker } from './context/createActiveContextTracker';
-import { ItemDescriptor } from './flag-manager/ItemDescriptor';
 
 const { ClientMessages, ErrorKinds } = internal;
 
@@ -61,7 +64,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
   private _eventProcessor?: internal.EventProcessor;
   readonly logger: LDLogger;
 
-  private _activeContextTracker: ActiveContextTracker = createActiveContextTracker()
+  private _activeContextTracker: ActiveContextTracker = createActiveContextTracker();
 
   private readonly _highTimeoutThreshold: number = 15;
 
@@ -202,7 +205,9 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
     // code.  We are returned the unchecked context so that if a consumer identifies with an invalid context
     // and then calls getContext, they get back the same context they provided, without any assertion about
     // validity.
-    return this._activeContextTracker.hasContext() ? clone<LDContext>(this._activeContextTracker.getPristineContext()) : undefined;
+    return this._activeContextTracker.hasContext()
+      ? clone<LDContext>(this._activeContextTracker.getPristineContext())
+      : undefined;
   }
 
   protected getInternalContext(): Context | undefined {
@@ -302,7 +307,7 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
               this.emitter.emit('error', context, error);
               return Promise.reject(error);
             }
-            this._activeContextTracker.set(context, checkedContext)
+            this._activeContextTracker.set(context, checkedContext);
 
             this._eventProcessor?.sendEvent(
               this._eventFactoryDefault.identifyEvent(checkedContext),
@@ -376,7 +381,12 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
 
     this._eventProcessor?.sendEvent(
       this._config.trackEventModifier(
-        this._eventFactoryDefault.customEvent(key, this._activeContextTracker.getContext()!, data, metricValue),
+        this._eventFactoryDefault.customEvent(
+          key,
+          this._activeContextTracker.getContext()!,
+          data,
+          metricValue,
+        ),
       ),
     );
 
@@ -401,9 +411,11 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
 
     // NOTE: we will be changing this behavior soon once we have a tracker on the
     // client initialization state.
-    const hasContext = this._activeContextTracker.hasContext()
+    const hasContext = this._activeContextTracker.hasContext();
     if (!hasContext) {
-      this.logger?.warn('Flag evaluation called before client is fully initialized, data from this evaulation could be stale.')
+      this.logger?.warn(
+        'Flag evaluation called before client is fully initialized, data from this evaulation could be stale.',
+      );
     }
 
     const evalContext = this._activeContextTracker.getContext()!;
@@ -416,9 +428,11 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
       );
 
       this.emitter.emit('error', this._activeContextTracker.getPristineContext(), error);
-      hasContext && this._eventProcessor?.sendEvent(
-        this._eventFactoryDefault.unknownFlagEvent(flagKey, defVal, evalContext),
-      );
+      if (hasContext) {
+        this._eventProcessor?.sendEvent(
+          this._eventFactoryDefault.unknownFlagEvent(flagKey, defVal, evalContext),
+        );
+      }
       return createErrorEvaluationDetail(ErrorKinds.FlagNotFound, defaultValue);
     }
 
@@ -427,16 +441,18 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
     if (typeChecker) {
       const [matched, type] = typeChecker(value);
       if (!matched) {
-        hasContext && this._eventProcessor?.sendEvent(
-          eventFactory.evalEventClient(
-            flagKey,
-            defaultValue, // track default value on type errors
-            defaultValue,
-            foundItem.flag,
-            evalContext,
-            reason,
-          ),
-        );
+        if (hasContext) {
+          this._eventProcessor?.sendEvent(
+            eventFactory.evalEventClient(
+              flagKey,
+              defaultValue, // track default value on type errors
+              defaultValue,
+              foundItem.flag,
+              evalContext,
+              reason,
+            ),
+          );
+        }
         const error = new LDClientError(
           `Wrong type "${type}" for feature flag "${flagKey}"; returning default value`,
         );
@@ -454,16 +470,18 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
     prerequisites?.forEach((prereqKey) => {
       this._variationInternal(prereqKey, undefined, this._eventFactoryDefault);
     });
-    hasContext && this._eventProcessor?.sendEvent(
-      eventFactory.evalEventClient(
-        flagKey,
-        value,
-        defaultValue,
-        foundItem.flag,
-        evalContext,
-        reason,
-      ),
-    );
+    if (hasContext) {
+      this._eventProcessor?.sendEvent(
+        eventFactory.evalEventClient(
+          flagKey,
+          value,
+          defaultValue,
+          foundItem.flag,
+          evalContext,
+          reason,
+        ),
+      );
+    }
     return successDetail;
   }
 
@@ -477,8 +495,11 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
     return value;
   }
   variationDetail(flagKey: string, defaultValue?: LDFlagValue): LDEvaluationDetail {
-    return this._hookRunner.withEvaluation(flagKey, this._activeContextTracker.getPristineContext(), defaultValue, () =>
-      this._variationInternal(flagKey, defaultValue, this._eventFactoryWithReasons),
+    return this._hookRunner.withEvaluation(
+      flagKey,
+      this._activeContextTracker.getPristineContext(),
+      defaultValue,
+      () => this._variationInternal(flagKey, defaultValue, this._eventFactoryWithReasons),
     );
   }
 
@@ -488,8 +509,11 @@ export default class LDClientImpl implements LDClient, LDClientIdentifyResult {
     eventFactory: EventFactory,
     typeChecker: (value: unknown) => [boolean, string],
   ): LDEvaluationDetailTyped<T> {
-    return this._hookRunner.withEvaluation(key, this._activeContextTracker.getPristineContext(), defaultValue, () =>
-      this._variationInternal(key, defaultValue, eventFactory, typeChecker),
+    return this._hookRunner.withEvaluation(
+      key,
+      this._activeContextTracker.getPristineContext(),
+      defaultValue,
+      () => this._variationInternal(key, defaultValue, eventFactory, typeChecker),
     );
   }
 

packages/shared/sdk-client/src/context/createActiveContextTracker.ts

@@ -1,12 +1,12 @@
-import { Context, LDContext } from "@launchdarkly/js-sdk-common"
+import { Context, LDContext } from '@launchdarkly/js-sdk-common';
 
 /**
  * ActiveContextTracker is an internal class that helps tracks the current active context
  * used by the client.
  */
 export interface ActiveContextTracker {
-  _pristineContext?: LDContext
-  _context?: Context
+  _pristineContext?: LDContext;
+  _context?: Context;
 
   /**
    * Set the active context and pristine context. This will only be called when the passed in context
@@ -15,46 +15,46 @@ export interface ActiveContextTracker {
    * @param pristineContext - The pristine context, which is the context as it was passed in to the SDK.
    * @param context - The active context, which is the context as it was checked and validated.
    */
-  set(pristineContext: LDContext, context: Context): void
+  set(pristineContext: LDContext, context: Context): void;
 
   /**
    * Get the active context.
    *
    * @returns The active context or undefined if it has not been set.
    */
-  getContext(): Context | undefined
+  getContext(): Context | undefined;
 
   /**
    * Get the pristine context.
    *
    * @returns The pristine context or undefined if it has not been set.
    */
-  getPristineContext(): LDContext | undefined
+  getPristineContext(): LDContext | undefined;
 
   /**
    * Create a new identification promise. To allow other parts of the SDK to track the identification process.
-   * 
+   *
    * TODO(self): this is a very generic method so maybe it doesn't belong here?
    */
   newIdentificationPromise(): {
     identifyPromise: Promise<void>;
     identifyResolve: () => void;
     identifyReject: (err: Error) => void;
-  }
+  };
 
   /**
    * Check if the active context is set. Regardless of whether it is valid or not.
    *
    * @returns True if the active context is set, false otherwise.
    */
-  hasContext(): boolean
+  hasContext(): boolean;
 
   /**
    * Check if the active context is valid.
    *
    * @returns True if the active context is valid, false otherwise.
    */
-  hasValidContext(): boolean
+  hasValidContext(): boolean;
 }
 
 export function createActiveContextTracker(): ActiveContextTracker {
@@ -65,8 +65,12 @@ export function createActiveContextTracker(): ActiveContextTracker {
       this._pristineContext = pristineContext;
       this._context = context;
     },
-    getContext() { return this._context; },
-    getPristineContext() { return this._pristineContext; },
+    getContext() {
+      return this._context;
+    },
+    getPristineContext() {
+      return this._pristineContext;
+    },
     newIdentificationPromise() {
       let res: () => void;
       let rej: (err: Error) => void;
@@ -78,7 +82,11 @@ export function createActiveContextTracker(): ActiveContextTracker {
 
       return { identifyPromise: basePromise, identifyResolve: res!, identifyReject: rej! };
     },
-    hasContext() { return this._context !== undefined; },
-    hasValidContext() { return this.hasContext() && this._context!.valid; },
+    hasContext() {
+      return this._context !== undefined;
+    },
+    hasValidContext() {
+      return this.hasContext() && this._context!.valid;
+    },
   };
 }

packages/shared/sdk-client/src/flag-manager/FlagManager.ts

@@ -40,7 +40,6 @@ export interface FlagManager {
    */
   loadCached(context: Context): Promise<boolean>;
 
-
   /**
    * Updates in-memory storage with the specified flags without a context
    * or persistent storage. Flags set in this way are considered emphemeral and

packages/shared/sdk-client/src/flag-manager/FlagUpdater.ts

@@ -42,7 +42,7 @@ export default class FlagUpdater {
   }
 
   init(context: Context, newFlags: { [key: string]: ItemDescriptor }) {
-    this._activeContext = context
+    this._activeContext = context;
     const oldFlags = this._flagStore.getAll();
     this._flagStore.init(newFlags);
     const changed = calculateChangedKeys(oldFlags, newFlags);