prepare 2.5.0 release (#20)

Author: LaunchDarklyReleaseBot

.circleci/config.yml

@@ -7,12 +7,19 @@ workflows:
   workflow:
     jobs:
       - go-test:
-          name: Go 1.15
-          docker-image: circleci/golang:1.15
+          name: Go 1.17
+          docker-image: cimg/go:1.17
+          run-lint: true
           with-coverage: true
+      - go-test:
+          name: Go 1.16
+          docker-image: cimg/go:1.16
+      - go-test:
+          name: Go 1.15
+          docker-image: cimg/go:1.15
       - go-test:
           name: Go 1.14
-          docker-image: circleci/golang:1.14
+          docker-image: cimg/go:1.14
       - go-test-windows:
           name: Windows
       - benchmarks
@@ -24,9 +31,7 @@ jobs:
         type: string
       run-lint:
         type: boolean
-        default: true
-        # We are currently linting in all Go versions, but this parameter lets us turn it off for some, in
-        # case we need to support more versions than a single version of golangci-lint is compatible with
+        default: false
       with-coverage:
         type: boolean
         default: false
@@ -111,7 +116,7 @@ jobs:
 
   benchmarks:
     docker:
-      - image: circleci/golang:1.15
+      - image: cimg/go:1.15
         environment:
           CIRCLE_ARTIFACTS: /tmp/circle-artifacts
 

.golangci.yml

@@ -18,18 +18,17 @@ linters:
     - godox
     - gofmt
     - goimports
-    - golint
     - gosec
     - gosimple
     - govet
     - ineffassign
-    - interfacer
     - lll
     - megacheck
     - misspell
     - nakedret
     - nolintlint
     - prealloc
+    - revive
     - staticcheck
     - structcheck
     - stylecheck

.ldrelease/config.yml

@@ -1,13 +1,18 @@
+version: 2
+
 repo:
   public: go-sdk-common
   private: go-sdk-common-private
 
-template:
-  name: go
-  env:
-    LD_RELEASE_GO_IMPORT_PATH: gopkg.in/launchdarkly/go-sdk-common.v2
+jobs:
+  - docker:
+      image: golang:1.14-buster
+    template:
+      name: go
+    env:
+      LD_RELEASE_GO_IMPORT_PATH: gopkg.in/launchdarkly/go-sdk-common.v2
 
-releasableBranches:
+branches:
   - name: v2
     description: 2.x - for Go SDK 5+
   - name: v1

CONTRIBUTING.md

@@ -1,6 +1,6 @@
 # Contributing to this project
 
-LaunchDarkly has published an [SDK contributor's guide](https://docs.launchdarkly.com/docs/sdk-contributors-guide) that provides a detailed explanation of how our SDKs work. See below for additional information on how to contribute to this project.
+LaunchDarkly has published an [SDK contributor's guide](https://docs.launchdarkly.com/sdk/concepts/contributors-guide) that provides a detailed explanation of how our SDKs work. See below for additional information on how to contribute to this project.
 
 ## Submitting bug reports and feature requests
 

Makefile

@@ -1,5 +1,5 @@
 
-GOLANGCI_LINT_VERSION=v1.27.0
+GOLANGCI_LINT_VERSION=v1.42.1
 
 LINTER=./bin/golangci-lint
 LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION)
@@ -37,8 +37,7 @@ test-easyjson: build-easyjson
 	go test -tags $(EASYJSON_TAG) -race -v ./...
 
 test-coverage: $(COVERAGE_PROFILE_RAW)
-	if [ -z "$(which go-coverage-enforcer)" ]; then go install github.com/launchdarkly-labs/go-coverage-enforcer; fi
-	go-coverage-enforcer $(COVERAGE_ENFORCER_FLAGS) -outprofile $(COVERAGE_PROFILE_FILTERED) $(COVERAGE_PROFILE_RAW)
+	go run github.com/launchdarkly-labs/go-coverage-enforcer@latest $(COVERAGE_ENFORCER_FLAGS) -outprofile $(COVERAGE_PROFILE_FILTERED) $(COVERAGE_PROFILE_RAW)
 	go tool cover -html $(COVERAGE_PROFILE_FILTERED) -o $(COVERAGE_PROFILE_FILTERED_HTML)
 	go tool cover -html $(COVERAGE_PROFILE_RAW) -o $(COVERAGE_PROFILE_RAW_HTML)
 

README.md

@@ -37,7 +37,7 @@ We encourage pull requests and other contributions from the community. Check out
     * Gradually roll out a feature to an increasing percentage of users, and track the effect that the feature has on key metrics (for instance, how likely is a user to complete a purchase if they have feature A versus feature B?).
     * Turn off a feature that you realize is causing performance problems in production, without needing to re-deploy, or even restart the application with a changed configuration file.
     * Grant access to certain features based on user attributes, like payment plan (eg: users on the ‘gold’ plan get access to more features than users in the ‘silver’ plan). Disable parts of your application to facilitate maintenance, without taking everything offline.
-* LaunchDarkly provides feature flag SDKs for a wide variety of languages and technologies. Check out [our documentation](https://docs.launchdarkly.com/docs) for a complete list.
+* LaunchDarkly provides feature flag SDKs for a wide variety of languages and technologies. Read [our documentation](https://docs.launchdarkly.com/sdk) for a complete list.
 * Explore LaunchDarkly
     * [launchdarkly.com](https://www.launchdarkly.com/ "LaunchDarkly Main Website") for more information
     * [docs.launchdarkly.com](https://docs.launchdarkly.com/  "LaunchDarkly Documentation") for our documentation and SDK reference guides

lduser/user.go

@@ -105,7 +105,7 @@ func (u User) GetKey() string {
 // GetSecondaryKey returns the secondary key of the user, if any.
 //
 // This affects feature flag targeting
-// (https://docs.launchdarkly.com/docs/targeting-users#section-targeting-rules-based-on-user-attributes)
+// (https://docs.launchdarkly.com/home/flags/targeting-users#targeting-rules-based-on-user-attributes)
 // as follows: if you have chosen to bucket users by a specific attribute, the secondary key (if set)
 // is used to further distinguish between users who are otherwise identical according to that attribute.
 func (u User) GetSecondaryKey() ldvalue.OptionalString {

lduser/user_builder.go

@@ -39,7 +39,7 @@ type UserBuilder interface {
 	// Secondary sets the secondary key attribute for the user being built.
 	//
 	// This affects feature flag targeting
-	// (https://docs.launchdarkly.com/docs/targeting-users#section-targeting-rules-based-on-user-attributes)
+	// (https://docs.launchdarkly.com/home/flags/targeting-users#targeting-rules-based-on-user-attributes)
 	// as follows: if you have chosen to bucket users by a specific attribute, the secondary key (if set)
 	// is used to further distinguish between users who are otherwise identical according to that attribute.
 	Secondary(value string) UserBuilderCanMakeAttributePrivate