Skip to content

Commit e218a18

Browse files
authored
enable github integration (#98)
1 parent 190a865 commit e218a18

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

internal/ldclient/flag_links.go

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -125,20 +125,19 @@ func makeFlagLinkRep(event *github.PullRequestEvent, flagKey, message string) *l
125125
timestamp = &m
126126
}
127127

128-
// TODO enable integration once capability is available
129-
// integration := "github"
128+
integration := "github"
130129
id := strconv.FormatInt(*pr.ID, 10)
131130
// key must be unique
132131
key := fmt.Sprintf("github-pr-%s-%s", id, flagKey)
133132

134133
return &ldapi.FlagLinkPost{
135-
DeepLink: pr.HTMLURL,
136-
Key: &key,
137-
// IntegrationKey: &integration,
138-
Timestamp: timestamp,
139-
Title: getLinkTitle(event),
140-
Description: pr.Body,
141-
Metadata: &metadata,
134+
DeepLink: pr.HTMLURL,
135+
Key: &key,
136+
IntegrationKey: &integration,
137+
Timestamp: timestamp,
138+
Title: getLinkTitle(event),
139+
Description: pr.Body,
140+
Metadata: &metadata,
142141
}
143142
}
144143

testdata/test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ show-widgets
55
oldPricingBanner
66
show_widgets
77
oldPricingBanner
8+
mobile-app-promo-ios

0 commit comments

Comments
 (0)