Additional tests to achieve 100% code coverage

Author: pascalbaljet

src/Exceptions/CouldNotSendNotification.php

@@ -30,11 +30,4 @@ public static function invalidReceiver(): self
             method or a phone_number attribute to your notifiable.'
         );
     }
-
-    public static function missingAlphaNumericSender(): self
-    {
-        return new static(
-            'Notification was not sent. Missing `alphanumeric_sender` in config'
-        );
-    }
 }

tests/Integration/TwilioProviderTest.php

@@ -41,6 +41,15 @@ public function it_can_create_the_application_with_sid()
         $this->assertInstanceOf(TwilioChannel::class, $this->app->get(TwilioChannel::class));
     }
 
+    /** @test */
+    public function it_can_create_the_application_with_token_auth()
+    {
+        $this->app['config']->set('twilio-notification-channel.auth_token', 'token');
+        $this->app['config']->set('twilio-notification-channel.account_sid', '1234');
+
+        $this->assertInstanceOf(TwilioChannel::class, $this->app->get(TwilioChannel::class));
+    }
+
     /** @test */
     public function it_provides_three_classes()
     {

tests/Unit/IntegrationTest.php

@@ -3,9 +3,11 @@
 namespace NotificationChannels\Twilio\Tests\Unit;
 
 use Illuminate\Contracts\Events\Dispatcher;
+use Illuminate\Notifications\Events\NotificationFailed;
 use Illuminate\Notifications\Notification;
 use Mockery;
 use Mockery\Adapter\Phpunit\MockeryTestCase;
+use NotificationChannels\Twilio\Exceptions\CouldNotSendNotification;
 use NotificationChannels\Twilio\Twilio;
 use NotificationChannels\Twilio\TwilioCallMessage;
 use NotificationChannels\Twilio\TwilioChannel;
@@ -28,7 +30,7 @@ class IntegrationTest extends MockeryTestCase
     /** @var Dispatcher */
     protected $events;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -144,6 +146,27 @@ public function it_can_make_a_call()
         $channel->send(new NotifiableWithAttribute, $this->notification);
     }
 
+    /** @test */
+    public function it_cant_make_a_call_when_the_from_config_is_missing()
+    {
+        $message = TwilioCallMessage::create('http://example.com');
+        $this->notification->shouldReceive('toTwilio')->andReturn($message);
+
+        $config = new TwilioConfig([]);
+        $twilio = new Twilio($this->twilioService, $config);
+        $channel = new TwilioChannel($twilio, $this->events);
+
+        $this->twilioService->calls->shouldNotReceive('create');
+
+        $this->events->shouldReceive('dispatch')
+            ->atLeast()->once()
+            ->with(Mockery::type(NotificationFailed::class));
+
+        $this->expectException(CouldNotSendNotification::class);
+
+        $channel->send(new NotifiableWithAttribute, $this->notification);
+    }
+
     protected function smsMessageWillBeSentToTwilioWith(...$args)
     {
         $this->twilioService->messages->shouldReceive('create')

tests/Unit/TwilioChannelTest.php

@@ -26,7 +26,7 @@ class TwilioChannelTest extends MockeryTestCase
     /** @var Dispatcher */
     protected $dispatcher;
 
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -91,6 +91,22 @@ public function it_will_send_a_sms_message_to_the_result_of_the_route_method_of_
         $this->channel->send($notifiable, $notification);
     }
 
+    /** @test */
+    public function it_will_send_a_sms_message_to_the_result_of_the_route_method_of_the_notifiable_if_it_uses_the_twilio_channel_explicitly()
+    {
+        $notifiable = new NotifiableWithTwilioChannel;
+        $notification = Mockery::mock(Notification::class);
+
+        $message = new TwilioSmsMessage('Message text');
+        $notification->shouldReceive('toTwilio')->andReturn($message);
+
+        $this->twilio->shouldReceive('sendMessage')
+            ->atLeast()->once()
+            ->with($message, '+1111111111', false);
+
+        $this->channel->send($notifiable, $notification);
+    }
+
     /** @test */
     public function it_will_make_a_call_to_the_phone_number_attribute_of_the_notifiable()
     {
@@ -240,6 +256,16 @@ class Notifiable
     public function routeNotificationFor() {}
 }
 
+class NotifiableWithTwilioChannel
+{
+    public function routeNotificationFor(string $channel)
+    {
+        if ($channel === 'twilio') {
+            return '+1111111111';
+        }
+    }
+}
+
 class NotifiableWithMethod
 {
     public function routeNotificationFor()

tests/Unit/TwilioSmsMessageTest.php

@@ -6,7 +6,7 @@
 
 class TwilioSmsMessageTest extends TwilioMessageTestCase
 {
-    public function setUp(): void
+    protected function setUp(): void
     {
         parent::setUp();
 
@@ -47,6 +47,15 @@ public function it_can_return_the_alphanumeric_sender_if_set()
         $this->assertEquals('TestSender', $message->getFrom());
     }
 
+    /** @test */
+    public function it_can_return_the_messaging_service_sid_if_set()
+    {
+        $message = TwilioSmsMessage::create('myMessage');
+        $message->messagingServiceSid('TestSid');
+
+        $this->assertEquals('TestSid', $message->getMessagingServiceSid());
+    }
+
     /** @test */
     public function it_can_set_optional_parameters()
     {