Unit tests

AntonTrekov · web-flow · commit 87b177908765 · 2019-01-22T14:22:05.000+03:00
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 /vendor/
 /composer.lock
-/.php_cs.cache
+/.php_cs.cache
+/tests/_support/_generated/
diff --git a/.scrutinizer.yml b/.scrutinizer.yml
@@ -0,0 +1,19 @@
+checks:
+  php:
+    code_rating: true
+    duplication: true
+
+build:
+  environment:
+    php:
+      version: 7.1
+  tests:
+    override:
+      - command: vendor/bin/codecept run unit --coverage-xml=build/clover.xml
+        coverage:
+          file: tests/_output/build/clover.xml
+          format: clover
+
+filter:
+  excluded_paths:
+    - "./tests"
diff --git a/.travis.yml b/.travis.yml
@@ -0,0 +1,21 @@
+language: php
+
+php:
+  - 7.1
+  - 7.2
+  - nightly
+
+sudo: false
+
+matrix:
+  fast_finish: true
+  allow_failures:
+    - php: nightly
+
+before_install:
+  - travis_retry composer self-update
+
+install:
+  - composer --prefer-dist --dev install
+
+script: vendor/bin/codecept run unit
diff --git a/Makefile b/Makefile
@@ -4,4 +4,7 @@ php-cs-check:
 	$(WORKING_DIR)/vendor/bin/php-cs-fixer fix --dry-run --format=junit --diff
 
 php-cs-fix:
-	$(WORKING_DIR)/vendor/bin/php-cs-fixer fix
+	$(WORKING_DIR)/vendor/bin/php-cs-fixer fix
+
+test-unit:
+	./vendor/bin/codecept run unit
diff --git a/README.md b/README.md
@@ -1,5 +1,10 @@
 # Codeception FlySystem Extension
 
+[![Build Status](https://travis-ci.org/lamoda/codeception-flysystem.svg?branch=master)](https://travis-ci.org/lamoda/codeception-flysystem)
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/?branch=master)
+[![Code Coverage](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/?branch=master)
+[![Build Status](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/badges/build.png?b=master)](https://scrutinizer-ci.com/g/lamoda/codeception-flysystem/build-status/master)
+
 This extension supports working with [FlySystem](https://flysystem.thephpleague.com/) with several adapters.
 
 Provides a set of methods for checking and modifying files on remote storage.
@@ -133,3 +138,11 @@ $fileSystem->dontSeeFileFoundMatches('/test$/', '/path/to/dir');
 make php-cs-check
 make php-cs-fix
 ```
+
+### Tests
+
+Unit
+
+```bash
+make test-unit
+```
diff --git a/codeception.yml b/codeception.yml
@@ -0,0 +1,14 @@
+paths:
+    tests: tests
+    output: tests/_output
+    data: tests/_data
+    support: tests/_support
+    envs: tests/_envs
+actor_suffix: Tester
+extensions:
+    enabled:
+        - Codeception\Extension\RunFailed
+coverage:
+    enabled: true
+    include:
+        - src/*
diff --git a/src/Extension/FileSystem.php b/src/Extension/FileSystem.php
@@ -67,7 +67,7 @@ public function copyFile($path, $newPath)
      *
      * @return array
      */
-    public function grabFileList($path)
+    public function grabFileList($path = '')
     {
         $list = [];
         $content = $this->flySystem->listContents($path);
diff --git a/src/Extension/FlySystemModule.php b/src/Extension/FlySystemModule.php
@@ -6,7 +6,6 @@
 use Codeception\Exception\TestRuntimeException;
 use Codeception\Module as CodeceptionModule;
 use Lamoda\Codeception\Extension\AdapterFactory\AdapterFactoryInterface;
-use Exception;
 use League\Flysystem\Filesystem as FlySystem;
 
 class FlySystemModule extends CodeceptionModule
@@ -88,13 +87,13 @@ private function validateAdapterConfig(array $config, $name)
      */
     private function createAdapterFactory($className)
     {
-        try {
-            $adapterFactory = new $className();
-        } catch (Exception $exception) {
-            $message = sprintf('Unexpected error happened on creation adapter factory, %s', $className);
-            throw new ModuleConfigException(__CLASS__, $message, $exception);
+        if (!class_exists($className)) {
+            $message = sprintf('Adapter %s does not exist, please use another one', $className);
+            throw new ModuleConfigException(__CLASS__, $message);
         }
 
+        $adapterFactory = new $className();
+
         if (!$adapterFactory instanceof AdapterFactoryInterface) {
             $message = sprintf('Adapter factory class must implement %s, %s adapter factory given', AdapterFactoryInterface::class, $className);
             throw new ModuleConfigException(__CLASS__, $message);
diff --git a/tests/_data/.gitkeep b/tests/_data/.gitkeep
diff --git a/tests/_output/.gitignore b/tests/_output/.gitignore
@@ -0,0 +1,2 @@
+*
+!.gitignore
diff --git a/tests/_support/FunctionalTester.php b/tests/_support/FunctionalTester.php
@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * Inherited Methods.
+ *
+ * @method void wantToTest($text)
+ * @method void wantTo($text)
+ * @method void execute($callable)
+ * @method void expectTo($prediction)
+ * @method void expect($prediction)
+ * @method void amGoingTo($argumentation)
+ * @method void am($role)
+ * @method void lookForwardTo($achieveValue)
+ * @method void comment($description)
+ * @method \Codeception\Lib\Friend haveFriend($name, $actorClass = NULL)
+ *
+ * @SuppressWarnings(PHPMD)
+ */
+class FunctionalTester extends \Codeception\Actor
+{
+    use _generated\FunctionalTesterActions;
+
+    /**
+     * Define custom actions here.
+     */
+}
diff --git a/tests/_support/Helper/Functional.php b/tests/_support/Helper/Functional.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace Helper;
+
+class Functional extends \Codeception\Module
+{
+}
diff --git a/tests/_support/Helper/Unit.php b/tests/_support/Helper/Unit.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace Helper;
+
+class Unit extends \Codeception\Module
+{
+    /**
+     * @param object $object
+     * @param string $propertyName
+     *
+     * @throws \ReflectionException
+     *
+     * @return mixed $value
+     */
+    public function getProtectedProperty($object, $propertyName)
+    {
+        $reflection = new \ReflectionClass($object);
+        $property = $reflection->getProperty($propertyName);
+        $property->setAccessible(true);
+        $value = $property->getValue($object);
+        $property->setAccessible(false);
+
+        return $value;
+    }
+}
diff --git a/tests/_support/UnitTester.php b/tests/_support/UnitTester.php
@@ -0,0 +1,26 @@
+<?php
+
+/**
+ * Inherited Methods.
+ *
+ * @method void wantToTest($text)
+ * @method void wantTo($text)
+ * @method void execute($callable)
+ * @method void expectTo($prediction)
+ * @method void expect($prediction)
+ * @method void amGoingTo($argumentation)
+ * @method void am($role)
+ * @method void lookForwardTo($achieveValue)
+ * @method void comment($description)
+ * @method \Codeception\Lib\Friend haveFriend($name, $actorClass = NULL)
+ *
+ * @SuppressWarnings(PHPMD)
+ */
+class UnitTester extends \Codeception\Actor
+{
+    use _generated\UnitTesterActions;
+
+    /**
+     * Define custom actions here.
+     */
+}
diff --git a/tests/functional.suite.yml b/tests/functional.suite.yml
@@ -0,0 +1,4 @@
+actor: FunctionalTester
+modules:
+    enabled:
+        - \Helper\Functional
diff --git a/tests/unit.suite.yml b/tests/unit.suite.yml
@@ -0,0 +1,5 @@
+actor: UnitTester
+modules:
+    enabled:
+        - Asserts
+        - \Helper\Unit
diff --git a/tests/unit/Extension/AdapterFactory/SftpAdapterFactoryTest.php b/tests/unit/Extension/AdapterFactory/SftpAdapterFactoryTest.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Lamoda\Codeception\Tests\Extension\AdapterFactory;
+
+use Codeception\Test\Unit;
+use Lamoda\Codeception\Extension\AdapterFactory\SftpAdapterFactory;
+use League\Flysystem\Sftp\SftpAdapter;
+
+class SftpAdapterFactoryTest extends Unit
+{
+    public function testCreateAdapter()
+    {
+        $adapter = SftpAdapterFactory::createAdapter([]);
+        $this->assertInstanceOf(SftpAdapter::class, $adapter);
+    }
+}
diff --git a/tests/unit/Extension/AdapterFactory/WebdavAdapterFactoryTest.php b/tests/unit/Extension/AdapterFactory/WebdavAdapterFactoryTest.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Lamoda\Codeception\Tests\Extension\AdapterFactory;
+
+use Codeception\Test\Unit;
+use Lamoda\Codeception\Extension\AdapterFactory\WebdavAdapterFactory;
+use League\Flysystem\WebDAV\WebDAVAdapter;
+
+class WebdavAdapterFactoryTest extends Unit
+{
+    public function testCreateAdapter()
+    {
+        $adapter = WebdavAdapterFactory::createAdapter(['baseUri' => 'base/uri']);
+        $this->assertInstanceOf(WebDAVAdapter::class, $adapter);
+    }
+}
diff --git a/tests/unit/Extension/FileSystemTest.php b/tests/unit/Extension/FileSystemTest.php
diff --git a/tests/unit/Extension/FlySystemModuleTest.php b/tests/unit/Extension/FlySystemModuleTest.php

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function copyFile($path, $newPath)`
`67`	`67`	`*`
`68`	`68`	`* @return array`
`69`	`69`	`*/`
`70`		`- public function grabFileList($path)`
	`70`	`+ public function grabFileList($path = '')`
`71`	`71`	`{`
`72`	`72`	`$list = [];`
`73`	`73`	`$content = $this->flySystem->listContents($path);`