replace randomString with rand.Text()?

[miekg]

rand.Text() was recently added to the std lib, you could prolly replace randomString with just that one call and also not deal with any security of that anymore.

Only downside is that there is no way to specify a length, but we may not care.

Should I send a PR?

side note: this bumps the required Go version to a fairly new one, not sure if that is on the cards

[aldas]

The implementation of rand.Text() differs slightly. Its output is limited to the characters ABCDEFGHIJKLMNOPQRSTUVWXYZ234567, whereas Echo’s random generator produces characters from ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz.

Go standard library rand.Text()
https://github.com/golang/go/blob/d00e96d3aeccb11c373d125418316f0b019f4fb0/src/crypto/rand/text.go#L7

Echo

echo/middleware/util.go

Lines 68 to 73 in 321530d

	const randomStringCharset = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
	const randomStringCharsetLen = 52 // len(randomStringCharset)
	const randomStringMaxByte = 255 - (256 % randomStringCharsetLen)
	func randomString(length uint8) string {
	reader := randomReaderPool.Get().(*bufio.Reader)

[miekg]

true. happy to close this if that is prohibitive for doing this change