Skip to content

Commit e23f17a

Browse files
committed
fix(FR-1432): Fix user email conditional rendering and remove Korean comments (#4228)
### Refactor user email rendering in SessionDetailContent and remove TODO comment ### Changes - Simplified the conditional rendering logic for user email in SessionDetailContent - Removed a TODO comment in backend.ai-client-esm.ts related to version 25.13.0 **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
1 parent 191a818 commit e23f17a

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

react/src/components/SessionDetailContent.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,9 @@ const SessionDetailContent: React.FC<{
253253
</Descriptions.Item>
254254
{(userRole === 'admin' || userRole === 'superadmin') && (
255255
<Descriptions.Item label={t('credential.UserID')} span={md ? 2 : 1}>
256-
{(() => {
257-
const ownerEmail = session.owner?.email;
258-
return ownerEmail ? (
259-
ownerEmail
260-
) : session.user_id ? (
256+
{session.owner?.email ? (
257+
session.owner.email
258+
) : session.user_id ? (
261259
<Suspense fallback={<Skeleton.Input size="small" active />}>
262260
<UNSAFELazyUserEmailView uuid={session.user_id} />
263261
</Suspense>

src/lib/backend.ai-client-esm.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,6 @@ class Client {
804804
if (this.isManagerVersionCompatibleWith('25.12.0')) {
805805
this._features['mount-by-id'] = true;
806806
}
807-
// TODO: 버전 25.13.0
808807
if (this.isManagerVersionCompatibleWith('25.13.0')) {
809808
this._features['pending-session-list'] = true;
810809
}

0 commit comments

Comments
 (0)