Skip to content

Commit c005f5d

Browse files
committed
fix(FR-1212): The resource number has different size NVIDIA logos. (#3908)
Resolves #3907 ([FR-1212](https://lablup.atlassian.net/browse/FR-1212)) # Fix NVIDIA icon display in ResourceTypeIcon component This PR addresses two issues: 1. Adds explicit width styling to the ImageWithFallback component in ResourceTypeIcon to ensure proper icon sizing 2. Replaces the NVIDIA SVG icon with a more standardized version that has better proportions The previous NVIDIA icon had inconsistent dimensions which caused display issues. The new icon maintains the same visual identity but with proper scaling and viewBox settings. Before: ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/27d46cd4-ab24-43c5-803d-0476797d5068.png) After: (Nvidia logo changed to the same file with gpu1.svg) ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/0c3b6592-b558-4101-a858-5cdbb0492f86.png) **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1212]: https://lablup.atlassian.net/browse/FR-1212?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 6aea5d6 commit c005f5d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

react/src/components/ResourceNumber.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ export const ResourceTypeIcon: React.FC<AccTypeIconProps> = ({
154154
<ImageWithFallback
155155
{...props}
156156
style={{
157+
width: size,
157158
height: size,
158159
alignSelf: 'center',
159160
...(props.style || {}),

resources/icons/nvidia.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)