Commit 9dce65a
committed
Resolves #2781 ([FR-55](https://lablup.atlassian.net/browse/FR-55))
This PR enhances accelerator selection by using the `supported_accelerators` field from images instead of relying on accelerator limits. The implementation:
1. Adds `supported_accelerators` to the GraphQL query in ImageEnvironmentSelectFormItems
2. Replaces the previous accelerator filtering logic with a new approach that:
- Checks if an accelerator type is supported by the image using the `supported_accelerators` field
- Supports wildcard matching with '*' or empty string to indicate all accelerators are supported
- Allows prefix matching for accelerator types
- Maintains backward compatibility with manual image input
This change improves the user experience by showing only relevant accelerator options based on what the selected image actually supports.
[FR-55]: https://lablup.atlassian.net/browse/FR-55?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 2682468 commit 9dce65a
File tree
5 files changed
+51
-35
lines changed- react/src
- components
- SessionFormItems
- helper
- hooks
5 files changed
+51
-35
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
52 | 53 | | |
53 | 54 | | |
54 | 55 | | |
| |||
Lines changed: 45 additions & 35 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | 169 | | |
176 | 170 | | |
177 | 171 | | |
| |||
187 | 181 | | |
188 | 182 | | |
189 | 183 | | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
197 | 202 | | |
198 | 203 | | |
199 | | - | |
| 204 | + | |
200 | 205 | | |
201 | 206 | | |
202 | 207 | | |
203 | 208 | | |
204 | 209 | | |
205 | 210 | | |
206 | | - | |
| 211 | + | |
207 | 212 | | |
208 | 213 | | |
209 | 214 | | |
| |||
226 | 231 | | |
227 | 232 | | |
228 | 233 | | |
229 | | - | |
| 234 | + | |
230 | 235 | | |
231 | | - | |
| 236 | + | |
232 | 237 | | |
233 | 238 | | |
234 | 239 | | |
| |||
360 | 365 | | |
361 | 366 | | |
362 | 367 | | |
363 | | - | |
| 368 | + | |
364 | 369 | | |
365 | 370 | | |
366 | 371 | | |
| |||
1066 | 1071 | | |
1067 | 1072 | | |
1068 | 1073 | | |
1069 | | - | |
1070 | | - | |
1071 | | - | |
| 1074 | + | |
| 1075 | + | |
| 1076 | + | |
| 1077 | + | |
| 1078 | + | |
1072 | 1079 | | |
1073 | 1080 | | |
1074 | | - | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
1075 | 1084 | | |
1076 | 1085 | | |
1077 | 1086 | | |
| |||
1086 | 1095 | | |
1087 | 1096 | | |
1088 | 1097 | | |
1089 | | - | |
1090 | | - | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
1091 | 1105 | | |
1092 | 1106 | | |
1093 | 1107 | | |
1094 | 1108 | | |
1095 | 1109 | | |
1096 | 1110 | | |
1097 | | - | |
| 1111 | + | |
1098 | 1112 | | |
1099 | 1113 | | |
1100 | 1114 | | |
1101 | 1115 | | |
1102 | 1116 | | |
1103 | | - | |
| 1117 | + | |
1104 | 1118 | | |
1105 | 1119 | | |
1106 | 1120 | | |
1107 | 1121 | | |
1108 | 1122 | | |
1109 | 1123 | | |
1110 | | - | |
1111 | | - | |
1112 | | - | |
1113 | | - | |
1114 | | - | |
1115 | | - | |
1116 | | - | |
1117 | | - | |
| 1124 | + | |
| 1125 | + | |
| 1126 | + | |
| 1127 | + | |
1118 | 1128 | | |
1119 | 1129 | | |
1120 | 1130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| 169 | + | |
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
| |||
223 | 224 | | |
224 | 225 | | |
225 | 226 | | |
| 227 | + | |
226 | 228 | | |
227 | 229 | | |
228 | 230 | | |
| |||
281 | 283 | | |
282 | 284 | | |
283 | 285 | | |
| 286 | + | |
284 | 287 | | |
285 | 288 | | |
286 | 289 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
| |||
0 commit comments