Skip to content

Commit 96450ef

Browse files
committed
fix(FR-1403): improve lifecycle stage filter logic for active serving instances (#4181)
Resolves ([FR-1403](https://lablup.atlassian.net/browse/FR-1403)) This PR improves the lifecycle stage filter logic for active serving instances in the ServingPage component. ## Changes - Updated lifecycle stage filter from specific inclusion logic (`lifecycle_stage == "created" | lifecycle_stage == "destroying"`) to exclusion logic (`lifecycle_stage != "destroyed"`) - This provides better coverage of all non-destroyed lifecycle stages when filtering for "active" serving instances ## Impact - Users will see a more comprehensive view of active serving instances - Improves accuracy of filtering serving instances by their lifecycle stage - Better alignment with the intended behavior of showing all active (non-destroyed) services **Checklist:** - [x] Code follows project conventions - [x] Changes are focused and minimal - [ ] Documentation (not applicable) - [ ] Test coverage (existing tests cover this logic) [FR-1403]: https://lablup.atlassian.net/browse/FR-1403?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 6c9a90a commit 96450ef

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

react/src/pages/ServingPage.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const ServingPage: React.FC = () => {
4747

4848
const lifecycleStageFilter =
4949
queryParams.lifecycleStage === 'active'
50-
? `lifecycle_stage == "created" | lifecycle_stage == "destroying"`
50+
? `lifecycle_stage != "destroyed"`
5151
: `lifecycle_stage == "${queryParams.lifecycleStage}"`;
5252

5353
const queryVariables = useMemo(

0 commit comments

Comments
 (0)