Commit 69ae6aa
committed
Resolves #4113 ([FR-1355](https://lablup.atlassian.net/browse/FR-1355))
## Summary
- Enhanced BAIPropertyFilter component to display user-friendly labels instead of raw values in filter tags
- Added valueLabel support to FilterInput interface for better UX
- Updated tag display logic to prioritize readable labels over raw values
- Added permission filter options to VFolderNodeListPage
- Maintains full backward compatibility
## Changes Made
- **BAIPropertyFilter.tsx**: Added valueLabel field and logic to display user-friendly labels
- **VFolderNodeListPage.tsx**: Added permission filter options with proper labels
## Example Improvement
- **Before**: "Type: group" (confusing raw value)
- **After**: "Type: Project" (user-friendly label)
## Test Plan
- [ ] Verify filter tags show readable labels when available
- [ ] Verify fallback to raw values when no label is provided
- [ ] Test both new and existing filter functionality
- [ ] Confirm backward compatibility with existing implementations
[FR-1355]: https://lablup.atlassian.net/browse/FR-1355?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 649937f commit 69ae6aa
File tree
2 files changed
+38
-7
lines changed- packages/backend.ai-ui/src/components
- react/src/pages
2 files changed
+38
-7
lines changedLines changed: 26 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
215 | 216 | | |
216 | 217 | | |
217 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
218 | 228 | | |
219 | 229 | | |
220 | 230 | | |
221 | 231 | | |
222 | 232 | | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
223 | 241 | | |
224 | 242 | | |
225 | 243 | | |
226 | 244 | | |
227 | 245 | | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
233 | 249 | | |
234 | 250 | | |
235 | 251 | | |
| |||
297 | 313 | | |
298 | 314 | | |
299 | 315 | | |
| 316 | + | |
300 | 317 | | |
301 | 318 | | |
302 | 319 | | |
303 | 320 | | |
304 | 321 | | |
305 | | - | |
| 322 | + | |
| 323 | + | |
306 | 324 | | |
307 | 325 | | |
308 | 326 | | |
| |||
383 | 401 | | |
384 | 402 | | |
385 | 403 | | |
386 | | - | |
| 404 | + | |
| 405 | + | |
387 | 406 | | |
388 | 407 | | |
389 | 408 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
565 | 565 | | |
566 | 566 | | |
567 | 567 | | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
568 | 580 | | |
569 | 581 | | |
570 | 582 | | |
| |||
0 commit comments