Commit 6616480
committed
# Refactor TensorBoard App Launching Process
resolves #4695 ([FR-1723](https://lablup.atlassian.net/browse/FR-1723))
This PR refactors the TensorBoard app launching process by:
1. Removing the special case handling for TensorBoard in `AppLauncherModal.tsx`
2. Enhancing the `_openTensorboardDialog` method in `backend-ai-app-launcher.ts` to accept configuration parameters
3. Adding internationalization strings for TensorBoard-related status messages
4. Improving the user experience with better status notifications during TensorBoard initialization
The changes ensure that TensorBoard launches properly through the standard app launching flow while providing better feedback to users about the preparation process.
**Checklist:**
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
[FR-1723]: https://lablup.atlassian.net/browse/FR-1723?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 2f368e6 commit 6616480
File tree
23 files changed
+176
-37
lines changed- react/src/components/ComputeSessionNodeItems
- resources/i18n
- src/components
23 files changed
+176
-37
lines changedLines changed: 0 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
163 | | - | |
164 | 158 | | |
165 | 159 | | |
166 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1459 | 1459 | | |
1460 | 1460 | | |
1461 | 1461 | | |
| 1462 | + | |
1462 | 1463 | | |
1463 | 1464 | | |
1464 | 1465 | | |
| |||
1500 | 1501 | | |
1501 | 1502 | | |
1502 | 1503 | | |
| 1504 | + | |
1503 | 1505 | | |
1504 | 1506 | | |
1505 | 1507 | | |
| |||
1600 | 1602 | | |
1601 | 1603 | | |
1602 | 1604 | | |
| 1605 | + | |
1603 | 1606 | | |
1604 | 1607 | | |
1605 | 1608 | | |
| |||
1614 | 1617 | | |
1615 | 1618 | | |
1616 | 1619 | | |
| 1620 | + | |
1617 | 1621 | | |
1618 | 1622 | | |
1619 | 1623 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1458 | 1458 | | |
1459 | 1459 | | |
1460 | 1460 | | |
| 1461 | + | |
1461 | 1462 | | |
1462 | 1463 | | |
1463 | 1464 | | |
| |||
1499 | 1500 | | |
1500 | 1501 | | |
1501 | 1502 | | |
| 1503 | + | |
1502 | 1504 | | |
1503 | 1505 | | |
1504 | 1506 | | |
| |||
1599 | 1601 | | |
1600 | 1602 | | |
1601 | 1603 | | |
| 1604 | + | |
1602 | 1605 | | |
1603 | 1606 | | |
1604 | 1607 | | |
| |||
1613 | 1616 | | |
1614 | 1617 | | |
1615 | 1618 | | |
| 1619 | + | |
1616 | 1620 | | |
1617 | 1621 | | |
1618 | 1622 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1467 | 1467 | | |
1468 | 1468 | | |
1469 | 1469 | | |
| 1470 | + | |
1470 | 1471 | | |
1471 | 1472 | | |
1472 | 1473 | | |
| |||
1508 | 1509 | | |
1509 | 1510 | | |
1510 | 1511 | | |
| 1512 | + | |
1511 | 1513 | | |
1512 | 1514 | | |
1513 | 1515 | | |
| |||
1609 | 1611 | | |
1610 | 1612 | | |
1611 | 1613 | | |
| 1614 | + | |
1612 | 1615 | | |
1613 | 1616 | | |
1614 | 1617 | | |
| |||
1623 | 1626 | | |
1624 | 1627 | | |
1625 | 1628 | | |
| 1629 | + | |
1626 | 1630 | | |
1627 | 1631 | | |
1628 | 1632 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1461 | 1461 | | |
1462 | 1462 | | |
1463 | 1463 | | |
| 1464 | + | |
1464 | 1465 | | |
1465 | 1466 | | |
1466 | 1467 | | |
| |||
1502 | 1503 | | |
1503 | 1504 | | |
1504 | 1505 | | |
| 1506 | + | |
1505 | 1507 | | |
1506 | 1508 | | |
1507 | 1509 | | |
| |||
1602 | 1604 | | |
1603 | 1605 | | |
1604 | 1606 | | |
| 1607 | + | |
1605 | 1608 | | |
1606 | 1609 | | |
1607 | 1610 | | |
| |||
1616 | 1619 | | |
1617 | 1620 | | |
1618 | 1621 | | |
| 1622 | + | |
1619 | 1623 | | |
1620 | 1624 | | |
1621 | 1625 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1460 | 1460 | | |
1461 | 1461 | | |
1462 | 1462 | | |
| 1463 | + | |
1463 | 1464 | | |
1464 | 1465 | | |
1465 | 1466 | | |
| |||
1501 | 1502 | | |
1502 | 1503 | | |
1503 | 1504 | | |
| 1505 | + | |
1504 | 1506 | | |
1505 | 1507 | | |
1506 | 1508 | | |
| |||
1601 | 1603 | | |
1602 | 1604 | | |
1603 | 1605 | | |
| 1606 | + | |
1604 | 1607 | | |
1605 | 1608 | | |
1606 | 1609 | | |
| |||
1615 | 1618 | | |
1616 | 1619 | | |
1617 | 1620 | | |
| 1621 | + | |
1618 | 1622 | | |
1619 | 1623 | | |
1620 | 1624 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1461 | 1461 | | |
1462 | 1462 | | |
1463 | 1463 | | |
| 1464 | + | |
1464 | 1465 | | |
1465 | 1466 | | |
1466 | 1467 | | |
| |||
1502 | 1503 | | |
1503 | 1504 | | |
1504 | 1505 | | |
| 1506 | + | |
1505 | 1507 | | |
1506 | 1508 | | |
1507 | 1509 | | |
| |||
1602 | 1604 | | |
1603 | 1605 | | |
1604 | 1606 | | |
| 1607 | + | |
1605 | 1608 | | |
1606 | 1609 | | |
1607 | 1610 | | |
| |||
1616 | 1619 | | |
1617 | 1620 | | |
1618 | 1621 | | |
| 1622 | + | |
1619 | 1623 | | |
1620 | 1624 | | |
1621 | 1625 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1459 | 1459 | | |
1460 | 1460 | | |
1461 | 1461 | | |
| 1462 | + | |
1462 | 1463 | | |
1463 | 1464 | | |
1464 | 1465 | | |
| |||
1501 | 1502 | | |
1502 | 1503 | | |
1503 | 1504 | | |
| 1505 | + | |
1504 | 1506 | | |
1505 | 1507 | | |
1506 | 1508 | | |
| |||
1601 | 1603 | | |
1602 | 1604 | | |
1603 | 1605 | | |
| 1606 | + | |
1604 | 1607 | | |
1605 | 1608 | | |
1606 | 1609 | | |
| |||
1615 | 1618 | | |
1616 | 1619 | | |
1617 | 1620 | | |
| 1621 | + | |
1618 | 1622 | | |
1619 | 1623 | | |
1620 | 1624 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1458 | 1458 | | |
1459 | 1459 | | |
1460 | 1460 | | |
| 1461 | + | |
1461 | 1462 | | |
1462 | 1463 | | |
1463 | 1464 | | |
| |||
1499 | 1500 | | |
1500 | 1501 | | |
1501 | 1502 | | |
| 1503 | + | |
1502 | 1504 | | |
1503 | 1505 | | |
1504 | 1506 | | |
| |||
1599 | 1601 | | |
1600 | 1602 | | |
1601 | 1603 | | |
| 1604 | + | |
1602 | 1605 | | |
1603 | 1606 | | |
1604 | 1607 | | |
| |||
1613 | 1616 | | |
1614 | 1617 | | |
1615 | 1618 | | |
| 1619 | + | |
1616 | 1620 | | |
1617 | 1621 | | |
1618 | 1622 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1460 | 1460 | | |
1461 | 1461 | | |
1462 | 1462 | | |
| 1463 | + | |
1463 | 1464 | | |
1464 | 1465 | | |
1465 | 1466 | | |
| |||
1501 | 1502 | | |
1502 | 1503 | | |
1503 | 1504 | | |
| 1505 | + | |
1504 | 1506 | | |
1505 | 1507 | | |
1506 | 1508 | | |
| |||
1601 | 1603 | | |
1602 | 1604 | | |
1603 | 1605 | | |
| 1606 | + | |
1604 | 1607 | | |
1605 | 1608 | | |
1606 | 1609 | | |
| |||
1615 | 1618 | | |
1616 | 1619 | | |
1617 | 1620 | | |
| 1621 | + | |
1618 | 1622 | | |
1619 | 1623 | | |
1620 | 1624 | | |
| |||
0 commit comments