Skip to content

Commit 612b477

Browse files
committed
feat(FR-1493): remove non-functional admin and monitor roles from user management interfaces (#4305)
Resolves #4304 ([FR-1493](https://lablup.atlassian.net/browse/FR-1493)) ## Summary This PR removes non-functional admin and monitor roles from the user management interfaces to prevent confusion. This PR applies the same changes as in lablup/backend.ai-control-panel#1150 ## Changes - Removed admin and monitor role options from the user list filter dropdown - Removed admin and monitor roles from the permission range configuration in user settings modal ## Why these changes? Admin and monitor roles are currently non-functional in the system but still visible in the UI, causing confusion for users who attempt to assign or filter by these roles. By removing these options, we streamline the user management workflow to only show functional roles: - superadmin (full administrative privileges) - user (standard user privileges) [FR-1493]: https://lablup.atlassian.net/browse/FR-1493?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 2c1f0a9 commit 612b477

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

react/src/components/UserNodeList.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,18 +192,18 @@ const UserNodeList: React.FC<UserNodeListProps> = () => {
192192
label: 'superadmin',
193193
value: 'superadmin',
194194
},
195-
{
196-
label: 'admin',
197-
value: 'admin',
198-
},
195+
// {
196+
// label: 'admin',
197+
// value: 'admin',
198+
// },
199199
{
200200
label: 'user',
201201
value: 'user',
202202
},
203-
{
204-
label: 'monitor',
205-
value: 'monitor',
206-
},
203+
// {
204+
// label: 'monitor',
205+
// value: 'monitor',
206+
// },
207207
],
208208
},
209209
{

react/src/components/UserSettingModal.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,17 @@ type UserRole = {
3939
[key: string]: string[];
4040
};
4141
const permissionRangeOfRoleChanges: UserRole = {
42-
superadmin: ['superadmin', 'admin', 'user', 'monitor'],
43-
admin: ['admin', 'user', 'monitor'],
42+
superadmin: [
43+
'superadmin',
44+
// 'admin',
45+
'user',
46+
// 'monitor'
47+
],
48+
admin: [
49+
// 'admin',
50+
'user',
51+
// 'monitor'
52+
],
4453
};
4554

4655
interface UserSettingModalProps extends BAIModalProps {

0 commit comments

Comments
 (0)