Skip to content

Commit 8db926f

Browse files
authored
Apply maintainer feedback
1 parent 56ca2fa commit 8db926f

File tree

1 file changed

+10
-3
lines changed
  • content/en/docs/concepts/services-networking

1 file changed

+10
-3
lines changed

content/en/docs/concepts/services-networking/ingress.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,8 @@ For general information about working with config files, see
105105
[deploying applications](/docs/tasks/run-application/run-stateless-application-deployment/),
106106
[configuring containers](/docs/tasks/configure-pod-container/configure-pod-configmap/),
107107
[managing resources](/docs/concepts/workloads/management/).
108+
Ingress controllers frequently use [annotations](/docs/concepts/overview/working-with-objects/annotations/) to configure behavior.
109+
Review the documentation for your choice of ingress controller to learn which annotations are expected and / or supported.
108110

109111
The [Ingress spec](/docs/reference/kubernetes-api/service-resources/ingress-v1/#IngressSpec)
110112
has all the information needed to configure a load balancer or proxy server. Most importantly, it
@@ -114,6 +116,11 @@ for directing HTTP(S) traffic.
114116
If the `ingressClassName` is omitted, a [default Ingress class](#default-ingress-class)
115117
should be defined.
116118

119+
Some ingress controllers work even without the definition of a
120+
default IngressClass. Even if you use an ingress controller that is able
121+
to operate without any IngressClass, the Kubernetes project still recommends
122+
that you define a default IngressClass.
123+
117124
### Ingress rules
118125

119126
Each HTTP rule contains the following information:
@@ -379,7 +386,7 @@ an `ingressClassName` specified. You can resolve this by ensuring that at most 1
379386
IngressClass is marked as default in your cluster.
380387
{{< /caution >}}
381388

382-
There are some ingress controllers, that work without the definition of a
389+
Start by defining a
383390
default IngressClass. It is recommended though, to specify the default
384391
IngressClass:
385392

@@ -522,8 +529,8 @@ section.
522529
{{% code_sample file="service/networking/tls-example-ingress.yaml" %}}
523530

524531
{{< note >}}
525-
There is a gap between TLS features supported by various Ingress controllers.
526-
Please refer to documentation for the Ingress controller you've chosen to
532+
There is a gap between TLS features supported by various ingress controllers.
533+
You should refer to the documentation for the ingress controller(s) you've chosen to
527534
understand how TLS works in your environment.
528535
{{< /note >}}
529536

0 commit comments

Comments
 (0)