Skip to content

fix: pogGroupController panic when no selected pod #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 1 commit into from
Dec 5, 2025
+3 −1
Merged

fix: pogGroupController panic when no selected pod #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/controllers/podgroup_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ func (r *PodGroupReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
case schedv1alpha1.PodGroupPending:
if len(pods) >= int(pg.Spec.MinMember) {
pgCopy.Status.Phase = schedv1alpha1.PodGroupScheduling
fillOccupiedObj(pgCopy, &pods[0])
if len(pods) > 0 {
Copy link
Member

@googs1025 googs1025 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if the panic is really due to this 🤔 : If I understand correctly, the added len(pods) > 0 seems redundant because:

pg.Spec.MinMember is forced to be ≥ 1 by +kubebuilder:validation:Minimum=1

scheduler-plugins/apis/scheduling/v1alpha1/types.go

Line 150 in d21b970

// +kubebuilder:validation:Minimum=1

The condition len(pods) >= int(pg.Spec.MinMember) already implies len(pods) >= 1

Therefore, it is safe to access pods[0] here, and the original code is correct.

Copy link
Member

@googs1025 googs1025 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Colvin-Y

fillOccupiedObj(pgCopy, &pods[0])
}
}
default:
pgCopy.Status.Running, pgCopy.Status.Succeeded, pgCopy.Status.Failed = getCurrentPodStats(pods)
Expand Down